From: Adam Kropelin <akropel1@rochester.rr.com>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org, davej@suse.de
Subject: Re: 2.5.8-dj1 : arch/i386/kernel/smpboot.c error
Date: Tue, 16 Apr 2002 22:47:07 -0400 [thread overview]
Message-ID: <20020417024707.GA24105@www.kroptech.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0204152216590.18109-100000@localhost.localdomain>
On Mon, Apr 15, 2002 at 10:19:24PM -0400, Frank Davis wrote:
> Hello all,
> While a 'make bzImage', I received the following compile error:
> Regards,
> Frank
>
> smpboot.c:1008: parse error before `0'
> smpboot.c: In function `smp_boot_cpus':
> smpboot.c:1023: invalid lvalue in assignment
> make[1]: *** [smpboot.o] Error 1
> make[1]: Leaving directory `/usr/src/linux/arch/i386/kernel'
> make: *** [_dir_arch/i386/kernel] Error 2
There's an optimization in io.h for !CONFIG_MULTIQUAD which doesn't seem to have been
carried through all the way...
The following patch seems logical, but I'm no expert. In particular, I'm not sure
if the ioremapping bit ever needs to be run when !CONFIG_MULTIQUAD...
--Adam
--- linux-2.5.8-dj1-virgin/arch/i386/kernel/smpboot.c Tue Apr 16 16:21:24 2002
+++ linux-2.5.8-dj1+smpboot-fix/arch/i386/kernel/smpboot.c Tue Apr 16 21:12:13 2002
@@ -1004,8 +1004,11 @@
extern int prof_counter[NR_CPUS];
static int boot_cpu_logical_apicid;
+
/* Where the IO area was mapped on multiquad, always 0 otherwise */
+#ifdef CONFIG_MULTIQUAD
void *xquad_portio = NULL;
+#endif
int cpu_sibling_map[NR_CPUS] __cacheline_aligned;
@@ -1013,6 +1016,7 @@
{
int apicid, cpu, bit;
+#ifdef CONFIG_MULTIQUAD
if (clustered_apic_mode && (numnodes > 1)) {
printk("Remapping cross-quad port I/O for %d quads\n",
numnodes);
@@ -1022,6 +1026,7 @@
xquad_portio = ioremap (XQUAD_PORTIO_BASE,
numnodes * XQUAD_PORTIO_LEN);
}
+#endif
#ifdef CONFIG_MTRR
/* Must be done before other processors booted */
next prev parent reply other threads:[~2002-04-17 2:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-16 2:19 2.5.8-dj1 : arch/i386/kernel/smpboot.c error Frank Davis
2002-04-17 2:47 ` Adam Kropelin [this message]
2002-04-17 4:59 ` Martin J. Bligh
2002-04-17 12:30 ` Adam Kropelin
2002-04-17 12:40 ` Adam Kropelin
2002-04-17 15:28 ` Martin J. Bligh
2002-04-17 19:17 ` Adam Kropelin
2002-04-17 19:31 ` Rick Stevens
2002-04-17 20:53 ` Martin J. Bligh
2002-04-17 20:40 ` Adam Kropelin
2002-04-17 21:17 ` Rick Stevens
2002-04-17 21:49 ` Adam Kropelin
2002-04-17 22:06 ` J.A. Magallon
2002-04-18 0:34 ` Martin J. Bligh
2002-04-18 2:16 ` Stevie O
2002-04-17 20:49 ` Martin J. Bligh
2002-04-17 22:56 ` Stevie O
2002-04-18 0:29 ` Martin J. Bligh
2002-04-21 13:37 ` [PATCH] " Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020417024707.GA24105@www.kroptech.com \
--to=akropel1@rochester.rr.com \
--cc=davej@suse.de \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox