From: Jens Axboe <axboe@suse.de>
To: Andre Hedrick <andre@linux-ide.org>
Cc: Gerard Beekmans <gerard@linuxfromscratch.org>,
linux-kernel@vger.kernel.org,
Martin Dalecki <dalecki@evision-ventures.com>
Subject: Re: make xconfig fails in 2.5.8 kernel, trivial change to fix it
Date: Wed, 17 Apr 2002 10:00:11 +0200 [thread overview]
Message-ID: <20020417080011.GW1097@suse.de> (raw)
In-Reply-To: <20020416224524.GA5651@gwaihir.linuxfromscratch.org> <Pine.LNX.4.10.10204161902220.11230-100000@master.linux-ide.org>
On Tue, Apr 16 2002, Andre Hedrick wrote:
> > Hi,
> >
> > There is a very trivial problem in line 52 of the drivers/ide/Config.in
> > file. It reads:
> > if [ $CONFIG_BLK_DEV_IDE_TCQ_DEFAULT != "n" ]; then
> >
> > 'make xconfig' fails on this saying that it is a bad if condition:
> >
> > cat header.tk >> ./kconfig.tk
> > ./tkparse < ../arch/i386/config.in >> kconfig.tk
> > drivers/ide/Config.in: 52: bad if condition
> >
> > It is easily fixed by enclosing $CONFIG_BLK_DEV_IDE_TCQ_DEFAULT in double
> > quotes. There are other if conditions in this same file that do have those
> > quotes and Tk doesn't complain about them.
> >
> > Does anybody use xconfig these days anyways since nobody apprarently has
> > noticed it before? I saw this broken a few 2.5 releases ago too but never
> > got around looking into it.
The problem is new to 2.5.8, since that very option did not exist in
earlier releases. And it's fixed in the latest ide patch sets.
--
Jens Axboe
prev parent reply other threads:[~2002-04-17 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020416224524.GA5651@gwaihir.linuxfromscratch.org>
2002-04-17 2:04 ` make xconfig fails in 2.5.8 kernel, trivial change to fix it Andre Hedrick
2002-04-17 2:35 ` Gerard Beekmans
2002-04-17 8:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020417080011.GW1097@suse.de \
--to=axboe@suse.de \
--cc=andre@linux-ide.org \
--cc=dalecki@evision-ventures.com \
--cc=gerard@linuxfromscratch.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox