* [BK PATCH] USB device support for 2.5.8
@ 2002-04-16 22:54 Greg KH
2002-04-16 22:58 ` Greg KH
2002-04-17 2:51 ` [BK PATCH] USB device support for 2.5.8 (take 2) Greg KH
0 siblings, 2 replies; 26+ messages in thread
From: Greg KH @ 2002-04-16 22:54 UTC (permalink / raw)
To: torvalds; +Cc: linux-usb-devel, linux-kernel
These changesets add USB device support to the kernel. It is the Lineo
code cleaned up a bit and dropped into the drivers/usb/device/
directory. Over time, the code will migrate into other usb directories
as the core of the device and host code merge together. This release
provides a version that builds properly, and provides a good base for
people to start working with.
Thanks to Stuart Lynne from Lineo for releasing this code and working to
have it included in the tree.
Pull from: bk://linuxusb.bkbits.net/usbd-2.5
drivers/usb/Config.in | 2
drivers/usb/Makefile | 7
drivers/usb/device/Config.help | 76 +
drivers/usb/device/Config.in | 42
drivers/usb/device/Makefile | 84 +
drivers/usb/device/bi/Config.in | 31
drivers/usb/device/bi/Makefile | 32
drivers/usb/device/bi/gen/Config.in | 7
drivers/usb/device/bi/gen/Makefile | 24
drivers/usb/device/bi/gen/udc.c | 600 ++++++++
drivers/usb/device/bi/gen/udc.h | 37
drivers/usb/device/bi/l7205/Config.help | 2
drivers/usb/device/bi/l7205/Config.in | 8
drivers/usb/device/bi/l7205/Makefile | 71
drivers/usb/device/bi/l7205/hardware.h | 623 ++++++++
drivers/usb/device/bi/l7205/l7205.h | 179 ++
drivers/usb/device/bi/l7205/udc.c | 1494 ++++++++++++++++++++
drivers/usb/device/bi/l7205/udc.h | 38
drivers/usb/device/bi/sa1100/Config.help | 11
drivers/usb/device/bi/sa1100/Config.in | 13
drivers/usb/device/bi/sa1100/Makefile | 77 +
drivers/usb/device/bi/sa1100/ctl.h | 320 ++++
drivers/usb/device/bi/sa1100/dma-sa1100.c | 270 +++
drivers/usb/device/bi/sa1100/dma.h | 64
drivers/usb/device/bi/sa1100/ep0.c | 522 +++++++
drivers/usb/device/bi/sa1100/recv.c | 379 +++++
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 144 +
drivers/usb/device/bi/sa1100/sa1100.h | 198 ++
drivers/usb/device/bi/sa1100/send.c | 282 +++
drivers/usb/device/bi/sa1100/tick.c | 200 ++
drivers/usb/device/bi/sa1100/udc.c | 1096 ++++++++++++++
drivers/usb/device/bi/sa1100/udc.h | 38
drivers/usb/device/bi/sl11/Config.help | 6
drivers/usb/device/bi/sl11/Config.in | 7
drivers/usb/device/bi/sl11/Makefile | 73
drivers/usb/device/bi/sl11/sl11.h | 222 +++
drivers/usb/device/bi/sl11/udc.c | 1387 ++++++++++++++++++
drivers/usb/device/bi/sl11/udc.h | 37
drivers/usb/device/bi/superh/Config.help | 4
drivers/usb/device/bi/superh/Config.in | 7
drivers/usb/device/bi/superh/Makefile | 71
drivers/usb/device/bi/superh/hardware.h | 173 ++
drivers/usb/device/bi/superh/lio.c | 71
drivers/usb/device/bi/superh/udc.c | 877 +++++++++++
drivers/usb/device/bi/superh/udc.h | 37
drivers/usb/device/bi/usbd-bi.c | 1063 ++++++++++++++
drivers/usb/device/bi/usbd-bi.h | 302 ++++
drivers/usb/device/crc10.c | 48
drivers/usb/device/crc10.h | 83 +
drivers/usb/device/crc16.c | 65
drivers/usb/device/crc16.h | 78 +
drivers/usb/device/crc32.c | 63
drivers/usb/device/crc32.h | 77 +
drivers/usb/device/crc8.c | 63
drivers/usb/device/crc8.h | 80 +
drivers/usb/device/ep0.c | 676 +++++++++
drivers/usb/device/net_fd/Config.help | 83 +
drivers/usb/device/net_fd/Config.in | 45
drivers/usb/device/net_fd/Makefile | 14
drivers/usb/device/net_fd/net-fd.c | 1701 +++++++++++++++++++++++
drivers/usb/device/net_fd/net-fd.h | 30
drivers/usb/device/net_fd/netproto.c | 1129 +++++++++++++++
drivers/usb/device/net_fd/netproto.h | 501 ++++++
drivers/usb/device/net_fd/rndis.c | 148 ++
drivers/usb/device/serial_fd/Config.help | 68
drivers/usb/device/serial_fd/Config.in | 29
drivers/usb/device/serial_fd/Makefile | 59
drivers/usb/device/serial_fd/serial.c | 998 +++++++++++++
drivers/usb/device/serial_fd/serproto.c | 812 ++++++++++
drivers/usb/device/serial_fd/serproto.h | 44
drivers/usb/device/usbd-arch.h | 306 ++++
drivers/usb/device/usbd-bus.c | 532 +++++++
drivers/usb/device/usbd-bus.h | 91 +
drivers/usb/device/usbd-debug.c | 261 +++
drivers/usb/device/usbd-debug.h | 112 +
drivers/usb/device/usbd-func.c | 1100 ++++++++++++++
drivers/usb/device/usbd-func.h | 713 +++++++++
drivers/usb/device/usbd-inline.h | 475 ++++++
drivers/usb/device/usbd-module.h | 60
drivers/usb/device/usbd-monitor.c | 782 ++++++++++
drivers/usb/device/usbd-serialnumber.c | 216 ++
drivers/usb/device/usbd.c | 1297 +++++++++++++++++
drivers/usb/device/usbd.h | 898 ++++++++++++
83 files changed, 25044 insertions(+), 1 deletion(-)
------
ChangeSet@1.492, 2002-04-16 14:15:02-07:00, greg@kroah.com
USB device code
- cleaned up the Makefiles
- removed hotplug.c and hotplug.h
- added MODULE_LICENSE() for some of the modules
- fixed a few compiler errors and warnings.
drivers/usb/device/hotplug.c | 92 ---------------------------------
drivers/usb/device/hotplug.h | 28 ----------
drivers/usb/device/Makefile | 69 +++---------------------
drivers/usb/device/bi/Makefile | 59 ++-------------------
drivers/usb/device/bi/gen/Makefile | 48 -----------------
drivers/usb/device/bi/gen/udc.c | 16 ++---
drivers/usb/device/bi/gen/udc.h | 2
drivers/usb/device/net_fd/Makefile | 46 ----------------
drivers/usb/device/net_fd/net-fd.c | 1
drivers/usb/device/usbd-monitor.c | 22 ++++---
drivers/usb/device/usbd-serialnumber.c | 16 ++---
drivers/usb/device/usbd.c | 53 +++++++++++++------
drivers/usb/device/usbd.h | 12 ++--
13 files changed, 89 insertions(+), 375 deletions(-)
------
ChangeSet@1.456.2.16, 2002-04-15 10:37:22-07:00, sl@lineo.com
[PATCH] remove reference to current->nice
USB device minor change
remove reference to current->nice
drivers/usb/device/bi/usbd-bi.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
------
ChangeSet@1.456.2.15, 2002-04-15 10:36:43-07:00, greg@kroah.com
USB devices
added the device tree to the build process.
drivers/usb/Makefile | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletion(-)
------
ChangeSet@1.456.2.14, 2002-04-12 14:17:31-07:00, greg@kroah.com
USB device
Added Config.help entries for the USB device configure items.
drivers/usb/device/Config.help | 76 ++++++++++++++++++++++++++++
drivers/usb/device/bi/l7205/Config.help | 2
drivers/usb/device/bi/sa1100/Config.help | 11 ++++
drivers/usb/device/bi/sl11/Config.help | 6 ++
drivers/usb/device/bi/superh/Config.help | 4 +
drivers/usb/device/net_fd/Config.help | 83 +++++++++++++++++++++++++++++++
drivers/usb/device/serial_fd/Config.help | 68 +++++++++++++++++++++++++
7 files changed, 250 insertions(+)
------
ChangeSet@1.456.2.13, 2002-04-12 14:02:52-07:00, greg@kroah.com
USB devices
fixed up some Config.in problems.
drivers/usb/device/Config.in | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
------
ChangeSet@1.456.2.11, 2002-04-11 16:54:12-07:00, greg@kroah.com
USB device
removed some files accidentally checked in.
drivers/usb/device/bi/l7205/save/ctl.c | 1598 ---------------------------
drivers/usb/device/bi/l7205/save/ctl.h | 305 -----
drivers/usb/device/bi/l7205/save/recv.c | 181 ---
drivers/usb/device/bi/l7205/save/send.c | 259 ----
drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 47
5 files changed, 2390 deletions(-)
------
ChangeSet@1.456.2.10, 2002-04-11 16:43:19-07:00, greg@kroah.com
USB device code
ran Lindent on the code
drivers/usb/device/moduse.c | 16
drivers/usb/device/test10.c | 150 -
drivers/usb/device/test8.c | 71
drivers/usb/device/usbd-build.h | 1
drivers/usb/device/usbd-export.h | 1
drivers/usb/device/bi/gen/udc.c | 321 +--
drivers/usb/device/bi/gen/udc.h | 2
drivers/usb/device/bi/l7205/l7205.h | 72
drivers/usb/device/bi/l7205/udc.c | 1916 ++++++++++----------
drivers/usb/device/bi/l7205/udc.h | 2
drivers/usb/device/bi/sa1100/ctl.h | 95 -
drivers/usb/device/bi/sa1100/dma-sa1100.c | 291 +--
drivers/usb/device/bi/sa1100/dma.h | 15
drivers/usb/device/bi/sa1100/ep0.c | 691 +++----
drivers/usb/device/bi/sa1100/recv.c | 502 ++---
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 121 -
drivers/usb/device/bi/sa1100/sa1100.h | 79
drivers/usb/device/bi/sa1100/send.c | 321 +--
drivers/usb/device/bi/sa1100/tick.c | 165 -
drivers/usb/device/bi/sa1100/udc.c | 1069 +++++------
drivers/usb/device/bi/sa1100/udc.h | 5
drivers/usb/device/bi/sl11/sl11.h | 37
drivers/usb/device/bi/sl11/udc.c | 1460 +++++++--------
drivers/usb/device/bi/sl11/udc.h | 5
drivers/usb/device/bi/superh/hardware.h | 2
drivers/usb/device/bi/superh/lio.c | 60
drivers/usb/device/bi/superh/udc.c | 861 ++++-----
drivers/usb/device/bi/superh/udc.h | 4
drivers/usb/device/bi/usbd-bi.c | 1378 +++++++-------
drivers/usb/device/bi/usbd-bi.h | 71
drivers/usb/device/crc10.c | 36
drivers/usb/device/crc10.h | 41
drivers/usb/device/crc16.c | 66
drivers/usb/device/crc16.h | 31
drivers/usb/device/crc32.c | 65
drivers/usb/device/crc32.h | 32
drivers/usb/device/crc8.c | 67
drivers/usb/device/crc8.h | 31
drivers/usb/device/ep0.c | 946 +++++-----
drivers/usb/device/hotplug.c | 54
drivers/usb/device/hotplug.h | 4
drivers/usb/device/net_fd/net-fd.c | 2150 +++++++++++------------
drivers/usb/device/net_fd/netproto.c | 1213 ++++++------
drivers/usb/device/net_fd/netproto.h | 363 +--
drivers/usb/device/net_fd/rndis.c | 79
drivers/usb/device/serial_fd/serial.c | 1158 ++++++------
drivers/usb/device/serial_fd/serproto.c | 1120 +++++------
drivers/usb/device/serial_fd/serproto.h | 21
drivers/usb/device/usbd-bus.c | 661 +++----
drivers/usb/device/usbd-bus.h | 23
drivers/usb/device/usbd-debug.c | 477 ++---
drivers/usb/device/usbd-debug.h | 21
drivers/usb/device/usbd-func.c | 1621 ++++++++---------
drivers/usb/device/usbd-func.h | 732 +++----
drivers/usb/device/usbd-inline.h | 525 ++---
drivers/usb/device/usbd-monitor.c | 876 ++++-----
drivers/usb/device/usbd-serialnumber.c | 140 -
drivers/usb/device/usbd.c | 1626 ++++++++---------
drivers/usb/device/usbd.h | 401 ++--
59 files changed, 11957 insertions(+), 12407 deletions(-)
------
ChangeSet@1.456.2.9, 2002-04-11 15:31:48-07:00, sl@lineo.com
USB device controller
Added initial USB device controller support.
drivers/usb/Config.in | 2
drivers/usb/device/Config.in | 46
drivers/usb/device/Makefile | 131 +
drivers/usb/device/bi/Config.in | 37
drivers/usb/device/bi/Makefile | 79 +
drivers/usb/device/bi/gen/Config.in | 13
drivers/usb/device/bi/gen/Makefile | 72
drivers/usb/device/bi/gen/udc.c | 597 ++++++++
drivers/usb/device/bi/gen/udc.h | 37
drivers/usb/device/bi/l7205/Config.in | 14
drivers/usb/device/bi/l7205/Makefile | 71
drivers/usb/device/bi/l7205/hardware.h | 623 ++++++++
drivers/usb/device/bi/l7205/l7205.h | 179 ++
drivers/usb/device/bi/l7205/save/ctl.c | 1598 +++++++++++++++++++++
drivers/usb/device/bi/l7205/save/ctl.h | 305 ++++
drivers/usb/device/bi/l7205/save/recv.c | 181 ++
drivers/usb/device/bi/l7205/save/send.c | 259 +++
drivers/usb/device/bi/l7205/udc.c | 1472 ++++++++++++++++++++
drivers/usb/device/bi/l7205/udc.h | 38
drivers/usb/device/bi/sa1100/Config.in | 23
drivers/usb/device/bi/sa1100/Makefile | 77 +
drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 89 +
drivers/usb/device/bi/sa1100/ctl.h | 325 ++++
drivers/usb/device/bi/sa1100/dma-sa1100.c | 271 +++
drivers/usb/device/bi/sa1100/dma.h | 65
drivers/usb/device/bi/sa1100/ep0.c | 533 +++++++
drivers/usb/device/bi/sa1100/recv.c | 369 +++++
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 145 +
drivers/usb/device/bi/sa1100/sa1100.h | 199 ++
drivers/usb/device/bi/sa1100/send.c | 281 +++
drivers/usb/device/bi/sa1100/tick.c | 213 ++
drivers/usb/device/bi/sa1100/udc.c | 1081 ++++++++++++++
drivers/usb/device/bi/sa1100/udc.h | 41
drivers/usb/device/bi/sl11/Config.in | 12
drivers/usb/device/bi/sl11/Makefile | 73
drivers/usb/device/bi/sl11/sl11.h | 223 +++
drivers/usb/device/bi/sl11/udc.c | 1395 +++++++++++++++++++
drivers/usb/device/bi/sl11/udc.h | 38
drivers/usb/device/bi/superh/Config.in | 12
drivers/usb/device/bi/superh/Makefile | 71
drivers/usb/device/bi/superh/hardware.h | 175 ++
drivers/usb/device/bi/superh/lio.c | 71
drivers/usb/device/bi/superh/udc.c | 870 +++++++++++
drivers/usb/device/bi/superh/udc.h | 37
drivers/usb/device/bi/usbd-bi.c | 1065 ++++++++++++++
drivers/usb/device/bi/usbd-bi.h | 301 ++++
drivers/usb/device/crc10.c | 52
drivers/usb/device/crc10.h | 86 +
drivers/usb/device/crc16.c | 67
drivers/usb/device/crc16.h | 81 +
drivers/usb/device/crc32.c | 64
drivers/usb/device/crc32.h | 81 +
drivers/usb/device/crc8.c | 66
drivers/usb/device/crc8.h | 83 +
drivers/usb/device/ep0.c | 648 ++++++++
drivers/usb/device/hotplug.c | 94 +
drivers/usb/device/hotplug.h | 30
drivers/usb/device/moduse.c | 16
drivers/usb/device/net_fd/Config.in | 59
drivers/usb/device/net_fd/Makefile | 58
drivers/usb/device/net_fd/net-fd.c | 1682 +++++++++++++++++++++++
drivers/usb/device/net_fd/net-fd.h | 30
drivers/usb/device/net_fd/netproto.c | 1132 +++++++++++++++
drivers/usb/device/net_fd/netproto.h | 504 ++++++
drivers/usb/device/net_fd/rndis.c | 147 ++
drivers/usb/device/serial_fd/Config.in | 44
drivers/usb/device/serial_fd/Makefile | 59
drivers/usb/device/serial_fd/serial.c | 982 +++++++++++++
drivers/usb/device/serial_fd/serproto.c | 832 +++++++++++
drivers/usb/device/serial_fd/serproto.h | 43
drivers/usb/device/test10.c | 150 ++
drivers/usb/device/test8.c | 71
drivers/usb/device/usbd-arch.h | 306 ++++
drivers/usb/device/usbd-build.h | 1
drivers/usb/device/usbd-bus.c | 523 +++++++
drivers/usb/device/usbd-bus.h | 92 +
drivers/usb/device/usbd-debug.c | 278 +++
drivers/usb/device/usbd-debug.h | 117 +
drivers/usb/device/usbd-export.h | 1
drivers/usb/device/usbd-func.c | 1205 ++++++++++++++++
drivers/usb/device/usbd-func.h | 713 +++++++++
drivers/usb/device/usbd-inline.h | 488 ++++++
drivers/usb/device/usbd-module.h | 60
drivers/usb/device/usbd-monitor.c | 796 ++++++++++
drivers/usb/device/usbd-serialnumber.c | 218 ++
drivers/usb/device/usbd.c | 1348 ++++++++++++++++++
drivers/usb/device/usbd.h | 911 ++++++++++++
87 files changed, 28027 insertions(+)
------
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8
2002-04-16 22:54 [BK PATCH] USB device support for 2.5.8 Greg KH
@ 2002-04-16 22:58 ` Greg KH
2002-04-17 2:51 ` [BK PATCH] USB device support for 2.5.8 (take 2) Greg KH
1 sibling, 0 replies; 26+ messages in thread
From: Greg KH @ 2002-04-16 22:58 UTC (permalink / raw)
To: linux-usb-devel, linux-kernel
On Tue, Apr 16, 2002 at 03:54:33PM -0700, Greg KH wrote:
>
> These changesets add USB device support to the kernel. It is the Lineo
> code cleaned up a bit and dropped into the drivers/usb/device/
> directory. Over time, the code will migrate into other usb directories
> as the core of the device and host code merge together. This release
> provides a version that builds properly, and provides a good base for
> people to start working with.
>
> Thanks to Stuart Lynne from Lineo for releasing this code and working to
> have it included in the tree.
>
> Pull from: bk://linuxusb.bkbits.net/usbd-2.5
These changesets can be found in a single patch at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/usb/2.5/usbd-2.5.8.patch.gz
for those who don't want to mess with Bitkeeper.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-16 22:54 [BK PATCH] USB device support for 2.5.8 Greg KH
2002-04-16 22:58 ` Greg KH
@ 2002-04-17 2:51 ` Greg KH
2002-04-17 2:53 ` Greg KH
2002-04-17 4:35 ` Linus Torvalds
1 sibling, 2 replies; 26+ messages in thread
From: Greg KH @ 2002-04-17 2:51 UTC (permalink / raw)
To: torvalds; +Cc: linux-usb-devel, linux-kernel
Linus, here is an updated changeset series with the USB device support.
It removes the arm sa1100 code from the last series, as the USB driver
in the ARM tree should be used, instead of the previous old version. I
will work with the ARM people to merge that into this portion of the
tree.
Pull from: bk://linuxusb.bkbits.net/usbd-2.5
drivers/usb/Config.in | 2
drivers/usb/Makefile | 7
drivers/usb/device/Config.help | 76 +
drivers/usb/device/Config.in | 42
drivers/usb/device/Makefile | 84 +
drivers/usb/device/bi/Config.in | 26
drivers/usb/device/bi/Makefile | 31
drivers/usb/device/bi/gen/Config.in | 7
drivers/usb/device/bi/gen/Makefile | 24
drivers/usb/device/bi/gen/udc.c | 600 ++++++++++
drivers/usb/device/bi/gen/udc.h | 37
drivers/usb/device/bi/l7205/Config.help | 2
drivers/usb/device/bi/l7205/Config.in | 8
drivers/usb/device/bi/l7205/Makefile | 71 +
drivers/usb/device/bi/l7205/hardware.h | 623 +++++++++++
drivers/usb/device/bi/l7205/l7205.h | 179 +++
drivers/usb/device/bi/l7205/udc.c | 1494 +++++++++++++++++++++++++++
drivers/usb/device/bi/l7205/udc.h | 38
drivers/usb/device/bi/sl11/Config.help | 6
drivers/usb/device/bi/sl11/Config.in | 7
drivers/usb/device/bi/sl11/Makefile | 73 +
drivers/usb/device/bi/sl11/sl11.h | 222 ++++
drivers/usb/device/bi/sl11/udc.c | 1387 +++++++++++++++++++++++++
drivers/usb/device/bi/sl11/udc.h | 37
drivers/usb/device/bi/superh/Config.help | 4
drivers/usb/device/bi/superh/Config.in | 7
drivers/usb/device/bi/superh/Makefile | 71 +
drivers/usb/device/bi/superh/hardware.h | 173 +++
drivers/usb/device/bi/superh/lio.c | 71 +
drivers/usb/device/bi/superh/udc.c | 877 +++++++++++++++
drivers/usb/device/bi/superh/udc.h | 37
drivers/usb/device/bi/usbd-bi.c | 1063 +++++++++++++++++++
drivers/usb/device/bi/usbd-bi.h | 302 +++++
drivers/usb/device/crc10.c | 48
drivers/usb/device/crc10.h | 83 +
drivers/usb/device/crc16.c | 65 +
drivers/usb/device/crc16.h | 78 +
drivers/usb/device/crc32.c | 63 +
drivers/usb/device/crc32.h | 77 +
drivers/usb/device/crc8.c | 63 +
drivers/usb/device/crc8.h | 80 +
drivers/usb/device/ep0.c | 676 ++++++++++++
drivers/usb/device/net_fd/Config.help | 83 +
drivers/usb/device/net_fd/Config.in | 45
drivers/usb/device/net_fd/Makefile | 14
drivers/usb/device/net_fd/net-fd.c | 1701 +++++++++++++++++++++++++++++++
drivers/usb/device/net_fd/net-fd.h | 30
drivers/usb/device/net_fd/netproto.c | 1129 ++++++++++++++++++++
drivers/usb/device/net_fd/netproto.h | 501 +++++++++
drivers/usb/device/net_fd/rndis.c | 148 ++
drivers/usb/device/serial_fd/Config.help | 68 +
drivers/usb/device/serial_fd/Config.in | 29
drivers/usb/device/serial_fd/Makefile | 59 +
drivers/usb/device/serial_fd/serial.c | 998 ++++++++++++++++++
drivers/usb/device/serial_fd/serproto.c | 812 ++++++++++++++
drivers/usb/device/serial_fd/serproto.h | 44
drivers/usb/device/usbd-arch.h | 306 +++++
drivers/usb/device/usbd-bus.c | 532 +++++++++
drivers/usb/device/usbd-bus.h | 91 +
drivers/usb/device/usbd-debug.c | 261 ++++
drivers/usb/device/usbd-debug.h | 112 ++
drivers/usb/device/usbd-func.c | 1100 ++++++++++++++++++++
drivers/usb/device/usbd-func.h | 713 ++++++++++++
drivers/usb/device/usbd-inline.h | 475 ++++++++
drivers/usb/device/usbd-module.h | 60 +
drivers/usb/device/usbd-monitor.c | 782 ++++++++++++++
drivers/usb/device/usbd-serialnumber.c | 216 +++
drivers/usb/device/usbd.c | 1297 +++++++++++++++++++++++
drivers/usb/device/usbd.h | 898 ++++++++++++++++
69 files changed, 21424 insertions(+), 1 deletion(-)
-----
ChangeSet@1.493, 2002-04-16 17:56:53-07:00, greg@kroah.com
USB devices
Deleted the SA1100 code due to conflicting code in the ARM tree.
drivers/usb/device/bi/sa1100/Config.help | 11
drivers/usb/device/bi/sa1100/Config.in | 13
drivers/usb/device/bi/sa1100/Makefile | 77 -
drivers/usb/device/bi/sa1100/ctl.h | 320 ------
drivers/usb/device/bi/sa1100/dma-sa1100.c | 270 -----
drivers/usb/device/bi/sa1100/dma.h | 64 -
drivers/usb/device/bi/sa1100/ep0.c | 522 ----------
drivers/usb/device/bi/sa1100/recv.c | 379 -------
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 144 ---
drivers/usb/device/bi/sa1100/sa1100.h | 198 ----
drivers/usb/device/bi/sa1100/send.c | 282 -----
drivers/usb/device/bi/sa1100/tick.c | 200 ----
drivers/usb/device/bi/sa1100/udc.c | 1096 -----------------------
drivers/usb/device/bi/sa1100/udc.h | 38
drivers/usb/device/bi/Config.in | 5
drivers/usb/device/bi/Makefile | 1
16 files changed, 3620 deletions(-)
-----
ChangeSet@1.492, 2002-04-16 14:15:02-07:00, greg@kroah.com
USB device code
- cleaned up the Makefiles
- removed hotplug.c and hotplug.h
- added MODULE_LICENSE() for some of the modules
- fixed a few compiler errors and warnings.
drivers/usb/device/hotplug.c | 92 ---------------------------------
drivers/usb/device/hotplug.h | 28 ----------
drivers/usb/device/Makefile | 69 +++---------------------
drivers/usb/device/bi/Makefile | 59 ++-------------------
drivers/usb/device/bi/gen/Makefile | 48 -----------------
drivers/usb/device/bi/gen/udc.c | 16 ++---
drivers/usb/device/bi/gen/udc.h | 2
drivers/usb/device/net_fd/Makefile | 46 ----------------
drivers/usb/device/net_fd/net-fd.c | 1
drivers/usb/device/usbd-monitor.c | 22 ++++---
drivers/usb/device/usbd-serialnumber.c | 16 ++---
drivers/usb/device/usbd.c | 53 +++++++++++++------
drivers/usb/device/usbd.h | 12 ++--
13 files changed, 89 insertions(+), 375 deletions(-)
-----
ChangeSet@1.456.2.16, 2002-04-15 10:37:22-07:00, sl@lineo.com
[PATCH] remove reference to current->nice
USB device minor change
remove reference to current->nice
drivers/usb/device/bi/usbd-bi.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
-----
ChangeSet@1.456.2.15, 2002-04-15 10:36:43-07:00, greg@kroah.com
USB devices
added the device tree to the build process.
drivers/usb/Makefile | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletion(-)
-----
ChangeSet@1.456.2.14, 2002-04-12 14:17:31-07:00, greg@kroah.com
USB device
Added Config.help entries for the USB device configure items.
drivers/usb/device/Config.help | 76 ++++++++++++++++++++++++++++
drivers/usb/device/bi/l7205/Config.help | 2
drivers/usb/device/bi/sa1100/Config.help | 11 ++++
drivers/usb/device/bi/sl11/Config.help | 6 ++
drivers/usb/device/bi/superh/Config.help | 4 +
drivers/usb/device/net_fd/Config.help | 83 +++++++++++++++++++++++++++++++
drivers/usb/device/serial_fd/Config.help | 68 +++++++++++++++++++++++++
7 files changed, 250 insertions(+)
-----
ChangeSet@1.456.2.13, 2002-04-12 14:02:52-07:00, greg@kroah.com
USB devices
fixed up some Config.in problems.
drivers/usb/device/Config.in | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
-----
ChangeSet@1.456.2.11, 2002-04-11 16:54:12-07:00, greg@kroah.com
USB device
removed some files accidentally checked in.
drivers/usb/device/bi/l7205/save/ctl.c | 1598 ---------------------------
drivers/usb/device/bi/l7205/save/ctl.h | 305 -----
drivers/usb/device/bi/l7205/save/recv.c | 181 ---
drivers/usb/device/bi/l7205/save/send.c | 259 ----
drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 47
5 files changed, 2390 deletions(-)
-----
ChangeSet@1.456.2.10, 2002-04-11 16:43:19-07:00, greg@kroah.com
USB device code
ran Lindent on the code
drivers/usb/device/moduse.c | 16
drivers/usb/device/test10.c | 150 -
drivers/usb/device/test8.c | 71
drivers/usb/device/usbd-build.h | 1
drivers/usb/device/usbd-export.h | 1
drivers/usb/device/bi/gen/udc.c | 321 +--
drivers/usb/device/bi/gen/udc.h | 2
drivers/usb/device/bi/l7205/l7205.h | 72
drivers/usb/device/bi/l7205/udc.c | 1916 ++++++++++----------
drivers/usb/device/bi/l7205/udc.h | 2
drivers/usb/device/bi/sa1100/ctl.h | 95 -
drivers/usb/device/bi/sa1100/dma-sa1100.c | 291 +--
drivers/usb/device/bi/sa1100/dma.h | 15
drivers/usb/device/bi/sa1100/ep0.c | 691 +++----
drivers/usb/device/bi/sa1100/recv.c | 502 ++---
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 121 -
drivers/usb/device/bi/sa1100/sa1100.h | 79
drivers/usb/device/bi/sa1100/send.c | 321 +--
drivers/usb/device/bi/sa1100/tick.c | 165 -
drivers/usb/device/bi/sa1100/udc.c | 1069 +++++------
drivers/usb/device/bi/sa1100/udc.h | 5
drivers/usb/device/bi/sl11/sl11.h | 37
drivers/usb/device/bi/sl11/udc.c | 1460 +++++++--------
drivers/usb/device/bi/sl11/udc.h | 5
drivers/usb/device/bi/superh/hardware.h | 2
drivers/usb/device/bi/superh/lio.c | 60
drivers/usb/device/bi/superh/udc.c | 861 ++++-----
drivers/usb/device/bi/superh/udc.h | 4
drivers/usb/device/bi/usbd-bi.c | 1378 +++++++-------
drivers/usb/device/bi/usbd-bi.h | 71
drivers/usb/device/crc10.c | 36
drivers/usb/device/crc10.h | 41
drivers/usb/device/crc16.c | 66
drivers/usb/device/crc16.h | 31
drivers/usb/device/crc32.c | 65
drivers/usb/device/crc32.h | 32
drivers/usb/device/crc8.c | 67
drivers/usb/device/crc8.h | 31
drivers/usb/device/ep0.c | 946 +++++-----
drivers/usb/device/hotplug.c | 54
drivers/usb/device/hotplug.h | 4
drivers/usb/device/net_fd/net-fd.c | 2150 +++++++++++------------
drivers/usb/device/net_fd/netproto.c | 1213 ++++++------
drivers/usb/device/net_fd/netproto.h | 363 +--
drivers/usb/device/net_fd/rndis.c | 79
drivers/usb/device/serial_fd/serial.c | 1158 ++++++------
drivers/usb/device/serial_fd/serproto.c | 1120 +++++------
drivers/usb/device/serial_fd/serproto.h | 21
drivers/usb/device/usbd-bus.c | 661 +++----
drivers/usb/device/usbd-bus.h | 23
drivers/usb/device/usbd-debug.c | 477 ++---
drivers/usb/device/usbd-debug.h | 21
drivers/usb/device/usbd-func.c | 1621 ++++++++---------
drivers/usb/device/usbd-func.h | 732 +++----
drivers/usb/device/usbd-inline.h | 525 ++---
drivers/usb/device/usbd-monitor.c | 876 ++++-----
drivers/usb/device/usbd-serialnumber.c | 140 -
drivers/usb/device/usbd.c | 1626 ++++++++---------
drivers/usb/device/usbd.h | 401 ++--
59 files changed, 11957 insertions(+), 12407 deletions(-)
-----
ChangeSet@1.456.2.9, 2002-04-11 15:31:48-07:00, sl@lineo.com
USB device controller
Added initial USB device controller support.
except that the repository that you are pushing to is 120 changesets
ahead of your repository. Please do a "bk pull" to get
these changes or do a "bk pull -nl" to see what they are.
drivers/usb/Config.in | 2
drivers/usb/device/Config.in | 46
drivers/usb/device/Makefile | 131 +
drivers/usb/device/bi/Config.in | 37
drivers/usb/device/bi/Makefile | 79 +
drivers/usb/device/bi/gen/Config.in | 13
drivers/usb/device/bi/gen/Makefile | 72
drivers/usb/device/bi/gen/udc.c | 597 ++++++++
drivers/usb/device/bi/gen/udc.h | 37
drivers/usb/device/bi/l7205/Config.in | 14
drivers/usb/device/bi/l7205/Makefile | 71
drivers/usb/device/bi/l7205/hardware.h | 623 ++++++++
drivers/usb/device/bi/l7205/l7205.h | 179 ++
drivers/usb/device/bi/l7205/save/ctl.c | 1598 +++++++++++++++++++++
drivers/usb/device/bi/l7205/save/ctl.h | 305 ++++
drivers/usb/device/bi/l7205/save/recv.c | 181 ++
drivers/usb/device/bi/l7205/save/send.c | 259 +++
drivers/usb/device/bi/l7205/udc.c | 1472 ++++++++++++++++++++
drivers/usb/device/bi/l7205/udc.h | 38
drivers/usb/device/bi/sa1100/Config.in | 23
drivers/usb/device/bi/sa1100/Makefile | 77 +
drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 89 +
drivers/usb/device/bi/sa1100/ctl.h | 325 ++++
drivers/usb/device/bi/sa1100/dma-sa1100.c | 271 +++
drivers/usb/device/bi/sa1100/dma.h | 65
drivers/usb/device/bi/sa1100/ep0.c | 533 +++++++
drivers/usb/device/bi/sa1100/recv.c | 369 +++++
drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 145 +
drivers/usb/device/bi/sa1100/sa1100.h | 199 ++
drivers/usb/device/bi/sa1100/send.c | 281 +++
drivers/usb/device/bi/sa1100/tick.c | 213 ++
drivers/usb/device/bi/sa1100/udc.c | 1081 ++++++++++++++
drivers/usb/device/bi/sa1100/udc.h | 41
drivers/usb/device/bi/sl11/Config.in | 12
drivers/usb/device/bi/sl11/Makefile | 73
drivers/usb/device/bi/sl11/sl11.h | 223 +++
drivers/usb/device/bi/sl11/udc.c | 1395 +++++++++++++++++++
drivers/usb/device/bi/sl11/udc.h | 38
drivers/usb/device/bi/superh/Config.in | 12
drivers/usb/device/bi/superh/Makefile | 71
drivers/usb/device/bi/superh/hardware.h | 175 ++
drivers/usb/device/bi/superh/lio.c | 71
drivers/usb/device/bi/superh/udc.c | 870 +++++++++++
drivers/usb/device/bi/superh/udc.h | 37
drivers/usb/device/bi/usbd-bi.c | 1065 ++++++++++++++
drivers/usb/device/bi/usbd-bi.h | 301 ++++
drivers/usb/device/crc10.c | 52
drivers/usb/device/crc10.h | 86 +
drivers/usb/device/crc16.c | 67
drivers/usb/device/crc16.h | 81 +
drivers/usb/device/crc32.c | 64
drivers/usb/device/crc32.h | 81 +
drivers/usb/device/crc8.c | 66
drivers/usb/device/crc8.h | 83 +
drivers/usb/device/ep0.c | 648 ++++++++
drivers/usb/device/hotplug.c | 94 +
drivers/usb/device/hotplug.h | 30
drivers/usb/device/moduse.c | 16
drivers/usb/device/net_fd/Config.in | 59
drivers/usb/device/net_fd/Makefile | 58
drivers/usb/device/net_fd/net-fd.c | 1682 +++++++++++++++++++++++
drivers/usb/device/net_fd/net-fd.h | 30
drivers/usb/device/net_fd/netproto.c | 1132 +++++++++++++++
drivers/usb/device/net_fd/netproto.h | 504 ++++++
drivers/usb/device/net_fd/rndis.c | 147 ++
drivers/usb/device/serial_fd/Config.in | 44
drivers/usb/device/serial_fd/Makefile | 59
drivers/usb/device/serial_fd/serial.c | 982 +++++++++++++
drivers/usb/device/serial_fd/serproto.c | 832 +++++++++++
drivers/usb/device/serial_fd/serproto.h | 43
drivers/usb/device/test10.c | 150 ++
drivers/usb/device/test8.c | 71
drivers/usb/device/usbd-arch.h | 306 ++++
drivers/usb/device/usbd-build.h | 1
drivers/usb/device/usbd-bus.c | 523 +++++++
drivers/usb/device/usbd-bus.h | 92 +
drivers/usb/device/usbd-debug.c | 278 +++
drivers/usb/device/usbd-debug.h | 117 +
drivers/usb/device/usbd-export.h | 1
drivers/usb/device/usbd-func.c | 1205 ++++++++++++++++
drivers/usb/device/usbd-func.h | 713 +++++++++
drivers/usb/device/usbd-inline.h | 488 ++++++
drivers/usb/device/usbd-module.h | 60
drivers/usb/device/usbd-monitor.c | 796 ++++++++++
drivers/usb/device/usbd-serialnumber.c | 218 ++
drivers/usb/device/usbd.c | 1348 ++++++++++++++++++
drivers/usb/device/usbd.h | 911 ++++++++++++
87 files changed, 28027 insertions(+)
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 2:51 ` [BK PATCH] USB device support for 2.5.8 (take 2) Greg KH
@ 2002-04-17 2:53 ` Greg KH
2002-04-17 4:35 ` Linus Torvalds
1 sibling, 0 replies; 26+ messages in thread
From: Greg KH @ 2002-04-17 2:53 UTC (permalink / raw)
To: linux-usb-devel, linux-kernel
On Tue, Apr 16, 2002 at 07:51:04PM -0700, Greg KH wrote:
>
> Linus, here is an updated changeset series with the USB device support.
> It removes the arm sa1100 code from the last series, as the USB driver
> in the ARM tree should be used, instead of the previous old version. I
> will work with the ARM people to merge that into this portion of the
> tree.
>
>
> Pull from: bk://linuxusb.bkbits.net/usbd-2.5
The updated patch for this can be found at:
http://www.kernel.org/pub/linux/kernel/people/gregkh/usb/2.5/usbd-2.5.8.patch-2.gz
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 2:51 ` [BK PATCH] USB device support for 2.5.8 (take 2) Greg KH
2002-04-17 2:53 ` Greg KH
@ 2002-04-17 4:35 ` Linus Torvalds
2002-04-17 3:52 ` Greg KH
1 sibling, 1 reply; 26+ messages in thread
From: Linus Torvalds @ 2002-04-17 4:35 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb-devel, linux-kernel
On Tue, 16 Apr 2002, Greg KH wrote:
>
> Linus, here is an updated changeset series with the USB device support.
Since I haven't pulled any of the usb device updates yet, might I suggest:
- redoing the BK archive completely without the broken series (ie an
actual "bk undo")
- explaining to me what a "usb device" is, that isn't a normal USB
device? Why is "usb/device/xxx" different from the existing USB device
drivers?
In other words, please explain what the _point_ of this code is?
Especially since the code is obvious crap, from the little I looked at it,
and quite frankly my immediate reaction is that it shouldn't get even
_close_ to the kernel before it has gone through some _major_ cleanup.
Let's face it, look at the absolute SHIT in usbd-debug.c, where somebody
has re-created strcmp/strcpy/etc, except with stupid names, and bad
implementation.
In short, I refuse to pull this crap. The people who wrote it were either
on drugs, incompetent, or just plain crazy. "Just say no".
Linus
> It removes the arm sa1100 code from the last series, as the USB driver
> in the ARM tree should be used, instead of the previous old version. I
> will work with the ARM people to merge that into this portion of the
> tree.
>
>
> Pull from: bk://linuxusb.bkbits.net/usbd-2.5
>
> drivers/usb/Config.in | 2
> drivers/usb/Makefile | 7
> drivers/usb/device/Config.help | 76 +
> drivers/usb/device/Config.in | 42
> drivers/usb/device/Makefile | 84 +
> drivers/usb/device/bi/Config.in | 26
> drivers/usb/device/bi/Makefile | 31
> drivers/usb/device/bi/gen/Config.in | 7
> drivers/usb/device/bi/gen/Makefile | 24
> drivers/usb/device/bi/gen/udc.c | 600 ++++++++++
> drivers/usb/device/bi/gen/udc.h | 37
> drivers/usb/device/bi/l7205/Config.help | 2
> drivers/usb/device/bi/l7205/Config.in | 8
> drivers/usb/device/bi/l7205/Makefile | 71 +
> drivers/usb/device/bi/l7205/hardware.h | 623 +++++++++++
> drivers/usb/device/bi/l7205/l7205.h | 179 +++
> drivers/usb/device/bi/l7205/udc.c | 1494 +++++++++++++++++++++++++++
> drivers/usb/device/bi/l7205/udc.h | 38
> drivers/usb/device/bi/sl11/Config.help | 6
> drivers/usb/device/bi/sl11/Config.in | 7
> drivers/usb/device/bi/sl11/Makefile | 73 +
> drivers/usb/device/bi/sl11/sl11.h | 222 ++++
> drivers/usb/device/bi/sl11/udc.c | 1387 +++++++++++++++++++++++++
> drivers/usb/device/bi/sl11/udc.h | 37
> drivers/usb/device/bi/superh/Config.help | 4
> drivers/usb/device/bi/superh/Config.in | 7
> drivers/usb/device/bi/superh/Makefile | 71 +
> drivers/usb/device/bi/superh/hardware.h | 173 +++
> drivers/usb/device/bi/superh/lio.c | 71 +
> drivers/usb/device/bi/superh/udc.c | 877 +++++++++++++++
> drivers/usb/device/bi/superh/udc.h | 37
> drivers/usb/device/bi/usbd-bi.c | 1063 +++++++++++++++++++
> drivers/usb/device/bi/usbd-bi.h | 302 +++++
> drivers/usb/device/crc10.c | 48
> drivers/usb/device/crc10.h | 83 +
> drivers/usb/device/crc16.c | 65 +
> drivers/usb/device/crc16.h | 78 +
> drivers/usb/device/crc32.c | 63 +
> drivers/usb/device/crc32.h | 77 +
> drivers/usb/device/crc8.c | 63 +
> drivers/usb/device/crc8.h | 80 +
> drivers/usb/device/ep0.c | 676 ++++++++++++
> drivers/usb/device/net_fd/Config.help | 83 +
> drivers/usb/device/net_fd/Config.in | 45
> drivers/usb/device/net_fd/Makefile | 14
> drivers/usb/device/net_fd/net-fd.c | 1701 +++++++++++++++++++++++++++++++
> drivers/usb/device/net_fd/net-fd.h | 30
> drivers/usb/device/net_fd/netproto.c | 1129 ++++++++++++++++++++
> drivers/usb/device/net_fd/netproto.h | 501 +++++++++
> drivers/usb/device/net_fd/rndis.c | 148 ++
> drivers/usb/device/serial_fd/Config.help | 68 +
> drivers/usb/device/serial_fd/Config.in | 29
> drivers/usb/device/serial_fd/Makefile | 59 +
> drivers/usb/device/serial_fd/serial.c | 998 ++++++++++++++++++
> drivers/usb/device/serial_fd/serproto.c | 812 ++++++++++++++
> drivers/usb/device/serial_fd/serproto.h | 44
> drivers/usb/device/usbd-arch.h | 306 +++++
> drivers/usb/device/usbd-bus.c | 532 +++++++++
> drivers/usb/device/usbd-bus.h | 91 +
> drivers/usb/device/usbd-debug.c | 261 ++++
> drivers/usb/device/usbd-debug.h | 112 ++
> drivers/usb/device/usbd-func.c | 1100 ++++++++++++++++++++
> drivers/usb/device/usbd-func.h | 713 ++++++++++++
> drivers/usb/device/usbd-inline.h | 475 ++++++++
> drivers/usb/device/usbd-module.h | 60 +
> drivers/usb/device/usbd-monitor.c | 782 ++++++++++++++
> drivers/usb/device/usbd-serialnumber.c | 216 +++
> drivers/usb/device/usbd.c | 1297 +++++++++++++++++++++++
> drivers/usb/device/usbd.h | 898 ++++++++++++++++
> 69 files changed, 21424 insertions(+), 1 deletion(-)
>
> -----
> ChangeSet@1.493, 2002-04-16 17:56:53-07:00, greg@kroah.com
> USB devices
>
> Deleted the SA1100 code due to conflicting code in the ARM tree.
>
> drivers/usb/device/bi/sa1100/Config.help | 11
> drivers/usb/device/bi/sa1100/Config.in | 13
> drivers/usb/device/bi/sa1100/Makefile | 77 -
> drivers/usb/device/bi/sa1100/ctl.h | 320 ------
> drivers/usb/device/bi/sa1100/dma-sa1100.c | 270 -----
> drivers/usb/device/bi/sa1100/dma.h | 64 -
> drivers/usb/device/bi/sa1100/ep0.c | 522 ----------
> drivers/usb/device/bi/sa1100/recv.c | 379 -------
> drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 144 ---
> drivers/usb/device/bi/sa1100/sa1100.h | 198 ----
> drivers/usb/device/bi/sa1100/send.c | 282 -----
> drivers/usb/device/bi/sa1100/tick.c | 200 ----
> drivers/usb/device/bi/sa1100/udc.c | 1096 -----------------------
> drivers/usb/device/bi/sa1100/udc.h | 38
> drivers/usb/device/bi/Config.in | 5
> drivers/usb/device/bi/Makefile | 1
> 16 files changed, 3620 deletions(-)
>
>
> -----
> ChangeSet@1.492, 2002-04-16 14:15:02-07:00, greg@kroah.com
> USB device code
>
> - cleaned up the Makefiles
> - removed hotplug.c and hotplug.h
> - added MODULE_LICENSE() for some of the modules
> - fixed a few compiler errors and warnings.
>
> drivers/usb/device/hotplug.c | 92 ---------------------------------
> drivers/usb/device/hotplug.h | 28 ----------
> drivers/usb/device/Makefile | 69 +++---------------------
> drivers/usb/device/bi/Makefile | 59 ++-------------------
> drivers/usb/device/bi/gen/Makefile | 48 -----------------
> drivers/usb/device/bi/gen/udc.c | 16 ++---
> drivers/usb/device/bi/gen/udc.h | 2
> drivers/usb/device/net_fd/Makefile | 46 ----------------
> drivers/usb/device/net_fd/net-fd.c | 1
> drivers/usb/device/usbd-monitor.c | 22 ++++---
> drivers/usb/device/usbd-serialnumber.c | 16 ++---
> drivers/usb/device/usbd.c | 53 +++++++++++++------
> drivers/usb/device/usbd.h | 12 ++--
> 13 files changed, 89 insertions(+), 375 deletions(-)
>
>
> -----
> ChangeSet@1.456.2.16, 2002-04-15 10:37:22-07:00, sl@lineo.com
> [PATCH] remove reference to current->nice
>
> USB device minor change
>
> remove reference to current->nice
>
> drivers/usb/device/bi/usbd-bi.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
>
> -----
> ChangeSet@1.456.2.15, 2002-04-15 10:36:43-07:00, greg@kroah.com
> USB devices
>
> added the device tree to the build process.
>
> drivers/usb/Makefile | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletion(-)
>
>
> -----
> ChangeSet@1.456.2.14, 2002-04-12 14:17:31-07:00, greg@kroah.com
> USB device
>
> Added Config.help entries for the USB device configure items.
>
> drivers/usb/device/Config.help | 76 ++++++++++++++++++++++++++++
> drivers/usb/device/bi/l7205/Config.help | 2
> drivers/usb/device/bi/sa1100/Config.help | 11 ++++
> drivers/usb/device/bi/sl11/Config.help | 6 ++
> drivers/usb/device/bi/superh/Config.help | 4 +
> drivers/usb/device/net_fd/Config.help | 83 +++++++++++++++++++++++++++++++
> drivers/usb/device/serial_fd/Config.help | 68 +++++++++++++++++++++++++
> 7 files changed, 250 insertions(+)
>
>
> -----
> ChangeSet@1.456.2.13, 2002-04-12 14:02:52-07:00, greg@kroah.com
> USB devices
>
> fixed up some Config.in problems.
>
> drivers/usb/device/Config.in | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>
> -----
> ChangeSet@1.456.2.11, 2002-04-11 16:54:12-07:00, greg@kroah.com
> USB device
>
> removed some files accidentally checked in.
>
> drivers/usb/device/bi/l7205/save/ctl.c | 1598 ---------------------------
> drivers/usb/device/bi/l7205/save/ctl.h | 305 -----
> drivers/usb/device/bi/l7205/save/recv.c | 181 ---
> drivers/usb/device/bi/l7205/save/send.c | 259 ----
> drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 47
> 5 files changed, 2390 deletions(-)
>
>
> -----
> ChangeSet@1.456.2.10, 2002-04-11 16:43:19-07:00, greg@kroah.com
> USB device code
>
> ran Lindent on the code
>
> drivers/usb/device/moduse.c | 16
> drivers/usb/device/test10.c | 150 -
> drivers/usb/device/test8.c | 71
> drivers/usb/device/usbd-build.h | 1
> drivers/usb/device/usbd-export.h | 1
> drivers/usb/device/bi/gen/udc.c | 321 +--
> drivers/usb/device/bi/gen/udc.h | 2
> drivers/usb/device/bi/l7205/l7205.h | 72
> drivers/usb/device/bi/l7205/udc.c | 1916 ++++++++++----------
> drivers/usb/device/bi/l7205/udc.h | 2
> drivers/usb/device/bi/sa1100/ctl.h | 95 -
> drivers/usb/device/bi/sa1100/dma-sa1100.c | 291 +--
> drivers/usb/device/bi/sa1100/dma.h | 15
> drivers/usb/device/bi/sa1100/ep0.c | 691 +++----
> drivers/usb/device/bi/sa1100/recv.c | 502 ++---
> drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 121 -
> drivers/usb/device/bi/sa1100/sa1100.h | 79
> drivers/usb/device/bi/sa1100/send.c | 321 +--
> drivers/usb/device/bi/sa1100/tick.c | 165 -
> drivers/usb/device/bi/sa1100/udc.c | 1069 +++++------
> drivers/usb/device/bi/sa1100/udc.h | 5
> drivers/usb/device/bi/sl11/sl11.h | 37
> drivers/usb/device/bi/sl11/udc.c | 1460 +++++++--------
> drivers/usb/device/bi/sl11/udc.h | 5
> drivers/usb/device/bi/superh/hardware.h | 2
> drivers/usb/device/bi/superh/lio.c | 60
> drivers/usb/device/bi/superh/udc.c | 861 ++++-----
> drivers/usb/device/bi/superh/udc.h | 4
> drivers/usb/device/bi/usbd-bi.c | 1378 +++++++-------
> drivers/usb/device/bi/usbd-bi.h | 71
> drivers/usb/device/crc10.c | 36
> drivers/usb/device/crc10.h | 41
> drivers/usb/device/crc16.c | 66
> drivers/usb/device/crc16.h | 31
> drivers/usb/device/crc32.c | 65
> drivers/usb/device/crc32.h | 32
> drivers/usb/device/crc8.c | 67
> drivers/usb/device/crc8.h | 31
> drivers/usb/device/ep0.c | 946 +++++-----
> drivers/usb/device/hotplug.c | 54
> drivers/usb/device/hotplug.h | 4
> drivers/usb/device/net_fd/net-fd.c | 2150 +++++++++++------------
> drivers/usb/device/net_fd/netproto.c | 1213 ++++++------
> drivers/usb/device/net_fd/netproto.h | 363 +--
> drivers/usb/device/net_fd/rndis.c | 79
> drivers/usb/device/serial_fd/serial.c | 1158 ++++++------
> drivers/usb/device/serial_fd/serproto.c | 1120 +++++------
> drivers/usb/device/serial_fd/serproto.h | 21
> drivers/usb/device/usbd-bus.c | 661 +++----
> drivers/usb/device/usbd-bus.h | 23
> drivers/usb/device/usbd-debug.c | 477 ++---
> drivers/usb/device/usbd-debug.h | 21
> drivers/usb/device/usbd-func.c | 1621 ++++++++---------
> drivers/usb/device/usbd-func.h | 732 +++----
> drivers/usb/device/usbd-inline.h | 525 ++---
> drivers/usb/device/usbd-monitor.c | 876 ++++-----
> drivers/usb/device/usbd-serialnumber.c | 140 -
> drivers/usb/device/usbd.c | 1626 ++++++++---------
> drivers/usb/device/usbd.h | 401 ++--
> 59 files changed, 11957 insertions(+), 12407 deletions(-)
>
>
> -----
> ChangeSet@1.456.2.9, 2002-04-11 15:31:48-07:00, sl@lineo.com
> USB device controller
>
> Added initial USB device controller support.
>
> except that the repository that you are pushing to is 120 changesets
> ahead of your repository. Please do a "bk pull" to get
> these changes or do a "bk pull -nl" to see what they are.
> drivers/usb/Config.in | 2
> drivers/usb/device/Config.in | 46
> drivers/usb/device/Makefile | 131 +
> drivers/usb/device/bi/Config.in | 37
> drivers/usb/device/bi/Makefile | 79 +
> drivers/usb/device/bi/gen/Config.in | 13
> drivers/usb/device/bi/gen/Makefile | 72
> drivers/usb/device/bi/gen/udc.c | 597 ++++++++
> drivers/usb/device/bi/gen/udc.h | 37
> drivers/usb/device/bi/l7205/Config.in | 14
> drivers/usb/device/bi/l7205/Makefile | 71
> drivers/usb/device/bi/l7205/hardware.h | 623 ++++++++
> drivers/usb/device/bi/l7205/l7205.h | 179 ++
> drivers/usb/device/bi/l7205/save/ctl.c | 1598 +++++++++++++++++++++
> drivers/usb/device/bi/l7205/save/ctl.h | 305 ++++
> drivers/usb/device/bi/l7205/save/recv.c | 181 ++
> drivers/usb/device/bi/l7205/save/send.c | 259 +++
> drivers/usb/device/bi/l7205/udc.c | 1472 ++++++++++++++++++++
> drivers/usb/device/bi/l7205/udc.h | 38
> drivers/usb/device/bi/sa1100/Config.in | 23
> drivers/usb/device/bi/sa1100/Makefile | 77 +
> drivers/usb/device/bi/sa1100/PATCH-NOCALYPSO | 89 +
> drivers/usb/device/bi/sa1100/ctl.h | 325 ++++
> drivers/usb/device/bi/sa1100/dma-sa1100.c | 271 +++
> drivers/usb/device/bi/sa1100/dma.h | 65
> drivers/usb/device/bi/sa1100/ep0.c | 533 +++++++
> drivers/usb/device/bi/sa1100/recv.c | 369 +++++
> drivers/usb/device/bi/sa1100/sa1100-dma-inline.h | 145 +
> drivers/usb/device/bi/sa1100/sa1100.h | 199 ++
> drivers/usb/device/bi/sa1100/send.c | 281 +++
> drivers/usb/device/bi/sa1100/tick.c | 213 ++
> drivers/usb/device/bi/sa1100/udc.c | 1081 ++++++++++++++
> drivers/usb/device/bi/sa1100/udc.h | 41
> drivers/usb/device/bi/sl11/Config.in | 12
> drivers/usb/device/bi/sl11/Makefile | 73
> drivers/usb/device/bi/sl11/sl11.h | 223 +++
> drivers/usb/device/bi/sl11/udc.c | 1395 +++++++++++++++++++
> drivers/usb/device/bi/sl11/udc.h | 38
> drivers/usb/device/bi/superh/Config.in | 12
> drivers/usb/device/bi/superh/Makefile | 71
> drivers/usb/device/bi/superh/hardware.h | 175 ++
> drivers/usb/device/bi/superh/lio.c | 71
> drivers/usb/device/bi/superh/udc.c | 870 +++++++++++
> drivers/usb/device/bi/superh/udc.h | 37
> drivers/usb/device/bi/usbd-bi.c | 1065 ++++++++++++++
> drivers/usb/device/bi/usbd-bi.h | 301 ++++
> drivers/usb/device/crc10.c | 52
> drivers/usb/device/crc10.h | 86 +
> drivers/usb/device/crc16.c | 67
> drivers/usb/device/crc16.h | 81 +
> drivers/usb/device/crc32.c | 64
> drivers/usb/device/crc32.h | 81 +
> drivers/usb/device/crc8.c | 66
> drivers/usb/device/crc8.h | 83 +
> drivers/usb/device/ep0.c | 648 ++++++++
> drivers/usb/device/hotplug.c | 94 +
> drivers/usb/device/hotplug.h | 30
> drivers/usb/device/moduse.c | 16
> drivers/usb/device/net_fd/Config.in | 59
> drivers/usb/device/net_fd/Makefile | 58
> drivers/usb/device/net_fd/net-fd.c | 1682 +++++++++++++++++++++++
> drivers/usb/device/net_fd/net-fd.h | 30
> drivers/usb/device/net_fd/netproto.c | 1132 +++++++++++++++
> drivers/usb/device/net_fd/netproto.h | 504 ++++++
> drivers/usb/device/net_fd/rndis.c | 147 ++
> drivers/usb/device/serial_fd/Config.in | 44
> drivers/usb/device/serial_fd/Makefile | 59
> drivers/usb/device/serial_fd/serial.c | 982 +++++++++++++
> drivers/usb/device/serial_fd/serproto.c | 832 +++++++++++
> drivers/usb/device/serial_fd/serproto.h | 43
> drivers/usb/device/test10.c | 150 ++
> drivers/usb/device/test8.c | 71
> drivers/usb/device/usbd-arch.h | 306 ++++
> drivers/usb/device/usbd-build.h | 1
> drivers/usb/device/usbd-bus.c | 523 +++++++
> drivers/usb/device/usbd-bus.h | 92 +
> drivers/usb/device/usbd-debug.c | 278 +++
> drivers/usb/device/usbd-debug.h | 117 +
> drivers/usb/device/usbd-export.h | 1
> drivers/usb/device/usbd-func.c | 1205 ++++++++++++++++
> drivers/usb/device/usbd-func.h | 713 +++++++++
> drivers/usb/device/usbd-inline.h | 488 ++++++
> drivers/usb/device/usbd-module.h | 60
> drivers/usb/device/usbd-monitor.c | 796 ++++++++++
> drivers/usb/device/usbd-serialnumber.c | 218 ++
> drivers/usb/device/usbd.c | 1348 ++++++++++++++++++
> drivers/usb/device/usbd.h | 911 ++++++++++++
> 87 files changed, 28027 insertions(+)
>
>
>
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 4:35 ` Linus Torvalds
@ 2002-04-17 3:52 ` Greg KH
2002-04-17 5:08 ` Linus Torvalds
0 siblings, 1 reply; 26+ messages in thread
From: Greg KH @ 2002-04-17 3:52 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-usb-devel, linux-kernel
On Tue, Apr 16, 2002 at 09:35:33PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 16 Apr 2002, Greg KH wrote:
> >
> > Linus, here is an updated changeset series with the USB device support.
>
> Since I haven't pulled any of the usb device updates yet, might I suggest:
>
> - redoing the BK archive completely without the broken series (ie an
> actual "bk undo")
Well since you don't want to pull it, I can just trash this tree, it
only contains the Lineo code.
> - explaining to me what a "usb device" is, that isn't a normal USB
> device? Why is "usb/device/xxx" different from the existing USB device
> drivers?
It's code to be a USB client device, not a USB host device, which is
what we currently have. It is used in embedded devices that run Linux,
like the new Sharp device (can't remember the name right now...)
> In other words, please explain what the _point_ of this code is?
> Especially since the code is obvious crap, from the little I looked at it,
> and quite frankly my immediate reaction is that it shouldn't get even
> _close_ to the kernel before it has gone through some _major_ cleanup.
>
> Let's face it, look at the absolute SHIT in usbd-debug.c, where somebody
> has re-created strcmp/strcpy/etc, except with stupid names, and bad
> implementation.
>
> In short, I refuse to pull this crap. The people who wrote it were either
> on drugs, incompetent, or just plain crazy. "Just say no".
Sorry. I spend most of my time on this code just cleaning the format
and removing build errors, instead of looking at the content :(
I'll work on fixing all of the crap before submitting it again.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 3:52 ` Greg KH
@ 2002-04-17 5:08 ` Linus Torvalds
2002-04-17 13:44 ` Greg KH
0 siblings, 1 reply; 26+ messages in thread
From: Linus Torvalds @ 2002-04-17 5:08 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb-devel, linux-kernel
On Tue, 16 Apr 2002, Greg KH wrote:
>
> It's code to be a USB client device, not a USB host device, which is
> what we currently have. It is used in embedded devices that run Linux,
> like the new Sharp device (can't remember the name right now...)
Ahhh.. A dim light goes on.
It would have made more sense (I think) to call it "usb/client" instead of
"usb/device", but maybe that's just because I didn't understand what the
thing was all about.
(Ask Davem some day about my irrational hang-ups about naming, and how I
sometimes like the same code if it's just named differently ;)
> Sorry. I spend most of my time on this code just cleaning the format
> and removing build errors, instead of looking at the content :(
>
> I'll work on fixing all of the crap before submitting it again.
In this case, the only reason I started really looking at the content was
that I didn't know what it was even supposed to do and was confused about
the naming, so I started looked at a few files. Which didn't really make
me go understand what it did, but _did_ make me puke.
Maybe the rest of it is wonderfully beautiful code, and I was just unlucky
in my selection ;)
Linus
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 5:08 ` Linus Torvalds
@ 2002-04-17 13:44 ` Greg KH
2002-04-17 16:00 ` [linux-usb-devel] " David Brownell
0 siblings, 1 reply; 26+ messages in thread
From: Greg KH @ 2002-04-17 13:44 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-usb-devel, linux-kernel
On Tue, Apr 16, 2002 at 10:08:48PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 16 Apr 2002, Greg KH wrote:
> >
> > It's code to be a USB client device, not a USB host device, which is
> > what we currently have. It is used in embedded devices that run Linux,
> > like the new Sharp device (can't remember the name right now...)
>
> Ahhh.. A dim light goes on.
>
> It would have made more sense (I think) to call it "usb/client" instead of
> "usb/device", but maybe that's just because I didn't understand what the
> thing was all about.
We (the linux-usb-devel list) talked about different names for this
stuff, and tried to follow the naming convention used in the USB spec.
However 99% of kernel developers will never read that spec, and 100% of
users never will, and the name "devices" failed to convey any good
meaning to the first person that saw the tree outside of the USB
developers, so changing the name to "client" makes a lot more sense :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 13:44 ` Greg KH
@ 2002-04-17 16:00 ` David Brownell
2002-04-17 17:57 ` Linus Torvalds
0 siblings, 1 reply; 26+ messages in thread
From: David Brownell @ 2002-04-17 16:00 UTC (permalink / raw)
To: Greg KH, Linus Torvalds; +Cc: linux-usb-devel, linux-kernel
> > > It's code to be a USB client device, not a USB host device, which is
> > > what we currently have. It is used in embedded devices that run Linux,
> > > like the new Sharp device (can't remember the name right now...)
> >
> > Ahhh.. A dim light goes on.
> >
> > It would have made more sense (I think) to call it "usb/client" instead of
> > "usb/device", but maybe that's just because I didn't understand what the
> > thing was all about.
>
> We (the linux-usb-devel list) talked about different names for this
> stuff, and tried to follow the naming convention used in the USB spec.
... except that this code does NOT follow those conventions, as
I've argued. And "client" is explicitly contrary to the USB spec,
which uses that as a host-side phrase (though not often).
In fact if you look at USB control messages, they're baby RPCs ...
which always go from "client" (USB host, which initiates) to "server"
(USB device, responds with status and/or data). I'd find "client"
to be wrong, not just confusing (like the X11 usage of that word).
> However 99% of kernel developers will never read that spec, and 100% of
> users never will, and the name "devices" failed to convey any good
> meaning to the first person that saw the tree outside of the USB
> developers, so changing the name to "client" makes a lot more sense :)
The USB "host" vs "device" naming convention is pretty deeply
ingrained in USB specs, but only "device" is end-user-visible.
At Fry's you buy not a "USB client", but a "USB device". I think
you could buy a "USB adapter" (PCI card) though.
I think that from the Linux perspective, "device" is itself ambiguous.
In a USB stack with Linux everywhere (in the host side and in the
device side), I count at least four kinds of code that would in some
context be called a "device driver":
Host side: "client driver" (USB spec term)
interacts with "host controller driver" [HCD] (ditto)
--- traffic goes over USB ---
Device side: "device controller driver" (not a USB spec term) (*)
interacts with "function driver" (USB spec term)
Today one tends to talk about a "USB device driver" rather than
a client driver, although many of us have devices that use two
drivers. (PCI analogy: one PCI card can have many functions,
each with its own driver) Most HCDs are PCI device drivers.
(Although there are other HCDs Linux deals with.)
I wish I had a better term to suggest than "USB device", but I'd
sure prefer to avoid "client". I've spent too many years doing
networking applications for that to make sense to me. What
would it take to make "device" less ambiguous?
- Dave
(*) The USB spec needlessly avoided using symmetrical terminology
here. They did talk about a "bus interface" layer but it shows up on
both host side and device side ... I think they underspecified things
on the device side to accomodate implementation variability. In
fact the bus interface on the device side is in many ways simpler
than on the host side: it doesn't have to multiplex i/o to devices.
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 16:00 ` [linux-usb-devel] " David Brownell
@ 2002-04-17 17:57 ` Linus Torvalds
2002-04-17 18:08 ` Larry McVoy
` (5 more replies)
0 siblings, 6 replies; 26+ messages in thread
From: Linus Torvalds @ 2002-04-17 17:57 UTC (permalink / raw)
To: David Brownell; +Cc: Greg KH, linux-usb-devel, linux-kernel
On Wed, 17 Apr 2002, David Brownell wrote:
>
> ... except that this code does NOT follow those conventions, as
> I've argued. And "client" is explicitly contrary to the USB spec,
> which uses that as a host-side phrase (though not often).
Note that the relevance of the USB spec to most people is exactly 0%.
"USB device" is what people say about the things you call "clients". The
real world takes precedence, and there is absolutely _no_ way a Linux "USB
device driver" will ever mean that the driver turns the box into a USB
device.
A "USB device driver" is driver for the mouse/scanner/whatever, ie the
_other_ end, and that's that. Claiming anything else is just confusing and
silly.
Since we're talking about the other end of a "host" driver, "client" makes
sense - in computers, I've always seen "client" as the reverse of the
"host", but maybe that's just me. Outside of computers, "guest" seems to
be the proper antonym, but that just strikes me as bizarre (a "USB guest
driver"?)
What were the other suggestions?
Linus
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 17:57 ` Linus Torvalds
@ 2002-04-17 18:08 ` Larry McVoy
2002-04-17 18:59 ` Linus Torvalds
2002-04-17 18:17 ` Greg KH
` (4 subsequent siblings)
5 siblings, 1 reply; 26+ messages in thread
From: Larry McVoy @ 2002-04-17 18:08 UTC (permalink / raw)
To: Linus Torvalds; +Cc: David Brownell, Greg KH, linux-usb-devel, linux-kernel
On Wed, Apr 17, 2002 at 10:57:21AM -0700, Linus Torvalds wrote:
> Since we're talking about the other end of a "host" driver, "client" makes
> sense - in computers, I've always seen "client" as the reverse of the
> "host", but maybe that's just me. Outside of computers, "guest" seems to
> be the proper antonym, but that just strikes me as bizarre (a "USB guest
> driver"?)
What about "target"? In SCSI land, it's clear that a target is the device,
and when you talk about code that runs on a computer and makes it be a
SCSI target, everyone knows what you mean, right? So what about code that
makes a computer a USB target? Would that work? That's the only thing I
could think of that was similar. Does USB already use the term target for
something else?
--
---
Larry McVoy lm at bitmover.com http://www.bitmover.com/lm
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 18:08 ` Larry McVoy
@ 2002-04-17 18:59 ` Linus Torvalds
2002-04-17 18:14 ` Greg KH
0 siblings, 1 reply; 26+ messages in thread
From: Linus Torvalds @ 2002-04-17 18:59 UTC (permalink / raw)
To: Larry McVoy; +Cc: David Brownell, Greg KH, linux-usb-devel, linux-kernel
On Wed, 17 Apr 2002, Larry McVoy wrote:
>
> What about "target"?
Well, it sounds unambiguous at least to me, and "makes sense".
Which still leaves the actual code implementation cleanliness issues, of
course (modulo the USB documentation specifying that "target" means a
small USB-controlled fish, thereby confusing all the USB developers).
Linus
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 18:59 ` Linus Torvalds
@ 2002-04-17 18:14 ` Greg KH
0 siblings, 0 replies; 26+ messages in thread
From: Greg KH @ 2002-04-17 18:14 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Larry McVoy, David Brownell, linux-usb-devel, linux-kernel
On Wed, Apr 17, 2002 at 11:59:41AM -0700, Linus Torvalds wrote:
>
>
> On Wed, 17 Apr 2002, Larry McVoy wrote:
> >
> > What about "target"?
>
> Well, it sounds unambiguous at least to me, and "makes sense".
I like "target" or "client", either of them work for me.
> Which still leaves the actual code implementation cleanliness issues, of
> course (modulo the USB documentation specifying that "target" means a
> small USB-controlled fish, thereby confusing all the USB developers).
Yes, I am working on this right now. This will take a bit longer than
just renaming the directory and changing the documentation :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 17:57 ` Linus Torvalds
2002-04-17 18:08 ` Larry McVoy
@ 2002-04-17 18:17 ` Greg KH
2002-04-19 5:37 ` George J Karabin
2002-04-17 18:41 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Stephen J. Gowdy
` (3 subsequent siblings)
5 siblings, 1 reply; 26+ messages in thread
From: Greg KH @ 2002-04-17 18:17 UTC (permalink / raw)
To: Linus Torvalds; +Cc: David Brownell, linux-usb-devel, linux-kernel
On Wed, Apr 17, 2002 at 10:57:21AM -0700, Linus Torvalds wrote:
>
> What were the other suggestions?
"client" was my original choice, which was changed to "device" after a
bit of discussion. There were no other suggestions.
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 18:17 ` Greg KH
@ 2002-04-19 5:37 ` George J Karabin
2002-04-19 5:46 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8(take 2) Oliver Neukum
0 siblings, 1 reply; 26+ messages in thread
From: George J Karabin @ 2002-04-19 5:37 UTC (permalink / raw)
To: Greg KH; +Cc: Linus Torvalds, David Brownell, linux-usb-devel, linux-kernel
Confusing as it may be to non-USB developers, how about using the USB
spec terms "host" (for the PC) and "local host" (for the USB
gadget/client/device/etc...)? I haven't seen those specific terms
suggested yet after quickly searching through the archive.
For shorthand, you might use "h" and "lh" suffixes, i.e., "usbh" for
host code, and "usblh" for local host code. Or something else if that
seems too terse.
One well placed Readme file ought to make the distinction pretty clear
to most end users, and USB developers shouldn't find it a problem at
all.
- George
On Wed, 2002-04-17 at 11:17, Greg KH wrote:
> On Wed, Apr 17, 2002 at 10:57:21AM -0700, Linus Torvalds wrote:
> >
> > What were the other suggestions?
>
> "client" was my original choice, which was changed to "device" after a
> bit of discussion. There were no other suggestions.
>
> greg k-h
>
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8(take 2)
2002-04-19 5:37 ` George J Karabin
@ 2002-04-19 5:46 ` Oliver Neukum
2002-04-19 6:11 ` George J Karabin
0 siblings, 1 reply; 26+ messages in thread
From: Oliver Neukum @ 2002-04-19 5:46 UTC (permalink / raw)
To: George J Karabin, Greg KH
Cc: Linus Torvalds, David Brownell, linux-usb-devel, linux-kernel
On Friday 19 April 2002 07:37, George J Karabin wrote:
> Confusing as it may be to non-USB developers, how about using the USB
> spec terms "host" (for the PC) and "local host" (for the USB
> gadget/client/device/etc...)? I haven't seen those specific terms
> suggested yet after quickly searching through the archive.
>
> For shorthand, you might use "h" and "lh" suffixes, i.e., "usbh" for
> host code, and "usblh" for local host code. Or something else if that
> seems too terse.
>
> One well placed Readme file ought to make the distinction pretty clear
> to most end users, and USB developers shouldn't find it a problem at
> all.
Too short a difference. You easily skip it reading and there's a chance of typos.
Furthermore the first latter should differ for tab completion.
Target is actually quite good a name. It makes clear that there's only
one initiator of transactions on USB.
Regards
Oliver
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8(take 2)
2002-04-19 5:46 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8(take 2) Oliver Neukum
@ 2002-04-19 6:11 ` George J Karabin
2002-04-19 11:06 ` [linux-usb-devel] Re: [BK PATCH] USB device support for2.5.8(take2) Oliver.Neukum
0 siblings, 1 reply; 26+ messages in thread
From: George J Karabin @ 2002-04-19 6:11 UTC (permalink / raw)
To: Oliver Neukum
Cc: Greg KH, Linus Torvalds, David Brownell, linux-usb-devel,
linux-kernel
On Thu, 2002-04-18 at 22:46, Oliver Neukum wrote:
> Too short a difference. You easily skip it reading and there's a chance of typos.
> Furthermore the first latter should differ for tab completion.
> Target is actually quite good a name. It makes clear that there's only
> one initiator of transactions on USB.
Those are good points. The shortcomings you mentioned are solved easily
enough, although the solutions that come to mind may not sound much
better either.
Easy tab completion could be provided using prefixes instead of
suffixes, like l and lh for lhusb and husb. Alternately, you could use
the long forms localusb, local-usb, or local_usb, or hostusb, host-usb,
or host_usb, taking care of the "too short a difference" concern. I'm
not sure these solutions are any better.
That said, target or client or anything else distinctive sounds fine
too. I'm just partial to the spec-derived-naming idea. (Although I
really wish the USB spec folks could have come up with two names that
were more descriptively different...)
- George
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for2.5.8(take2)
2002-04-19 6:11 ` George J Karabin
@ 2002-04-19 11:06 ` Oliver.Neukum
2002-04-19 16:22 ` George J Karabin
0 siblings, 1 reply; 26+ messages in thread
From: Oliver.Neukum @ 2002-04-19 11:06 UTC (permalink / raw)
To: George J Karabin
Cc: Oliver Neukum, Greg KH, Linus Torvalds, David Brownell,
linux-usb-devel, linux-kernel
> That said, target or client or anything else distinctive sounds fine
> too. I'm just partial to the spec-derived-naming idea. (Although I
> really wish the USB spec folks could have come up with two names that
> were more descriptively different...)
Why you do you want to derive a name from the specs ?
Someone who has read them will no what is refered to
whatever we name it. The significance of a the name
is important to those who look into usb code occasionaly.
These typically haven't read the spec.
Regards
Oliver
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for2.5.8(take2)
2002-04-19 11:06 ` [linux-usb-devel] Re: [BK PATCH] USB device support for2.5.8(take2) Oliver.Neukum
@ 2002-04-19 16:22 ` George J Karabin
0 siblings, 0 replies; 26+ messages in thread
From: George J Karabin @ 2002-04-19 16:22 UTC (permalink / raw)
To: Oliver.Neukum
Cc: Oliver Neukum, Greg KH, Linus Torvalds, David Brownell,
linux-usb-devel, linux-kernel
On Fri, 2002-04-19 at 04:06, Oliver.Neukum@lrz.uni-muenchen.de wrote:
> Why you do you want to derive a name from the specs ?
> Someone who has read them will no what is refered to
> whatever we name it. The significance of a the name
> is important to those who look into usb code occasionaly.
> These typically haven't read the spec.
First thing that popped into my head, I guess. I'm not stuck on it - I
guess that's all I have to say on it. Given the lack of other comments,
I guess it's a dead idea anyway, or at least too far down in everyone's
mail queues ;)
- George
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 17:57 ` Linus Torvalds
2002-04-17 18:08 ` Larry McVoy
2002-04-17 18:17 ` Greg KH
@ 2002-04-17 18:41 ` Stephen J. Gowdy
2002-04-17 18:31 ` Greg KH
2002-04-17 18:44 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 arjan
` (2 subsequent siblings)
5 siblings, 1 reply; 26+ messages in thread
From: Stephen J. Gowdy @ 2002-04-17 18:41 UTC (permalink / raw)
To: Linus Torvalds; +Cc: David Brownell, Greg KH, linux-usb-devel, linux-kernel
gadget? non-host?
On Wed, 17 Apr 2002, Linus Torvalds wrote:
>
>
> On Wed, 17 Apr 2002, David Brownell wrote:
> >
> > ... except that this code does NOT follow those conventions, as
> > I've argued. And "client" is explicitly contrary to the USB spec,
> > which uses that as a host-side phrase (though not often).
>
> Note that the relevance of the USB spec to most people is exactly 0%.
>
> "USB device" is what people say about the things you call "clients". The
> real world takes precedence, and there is absolutely _no_ way a Linux "USB
> device driver" will ever mean that the driver turns the box into a USB
> device.
>
> A "USB device driver" is driver for the mouse/scanner/whatever, ie the
> _other_ end, and that's that. Claiming anything else is just confusing and
> silly.
>
> Since we're talking about the other end of a "host" driver, "client" makes
> sense - in computers, I've always seen "client" as the reverse of the
> "host", but maybe that's just me. Outside of computers, "guest" seems to
> be the proper antonym, but that just strikes me as bizarre (a "USB guest
> driver"?)
>
> What were the other suggestions?
>
> Linus
>
>
> _______________________________________________
> linux-usb-devel@lists.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
>
--
/------------------------------------+-------------------------\
|Stephen J. Gowdy | SLAC, MailStop 34, |
|http://www.slac.stanford.edu/~gowdy/ | 2575 Sand Hill Road, |
|http://calendar.yahoo.com/gowdy | Menlo Park CA 94025, USA |
|EMail: gowdy@slac.stanford.edu | Tel: +1 650 926 3144 |
\------------------------------------+-------------------------/
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 18:41 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Stephen J. Gowdy
@ 2002-04-17 18:31 ` Greg KH
0 siblings, 0 replies; 26+ messages in thread
From: Greg KH @ 2002-04-17 18:31 UTC (permalink / raw)
To: Stephen J. Gowdy
Cc: Linus Torvalds, David Brownell, linux-usb-devel, linux-kernel
On Wed, Apr 17, 2002 at 11:41:14AM -0700, Stephen J. Gowdy wrote:
> gadget? non-host?
"gadget" is nice. It's descriptive of what the code is for, without the
bad connotations that "slave" seems to have.
Although those people who actually take USB seriously might not like it
so much, but I don't see any of those people doing Linux development
anyway :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 26+ messages in thread
* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8
2002-04-17 17:57 ` Linus Torvalds
` (2 preceding siblings ...)
2002-04-17 18:41 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Stephen J. Gowdy
@ 2002-04-17 18:44 ` arjan
2002-04-17 19:02 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Oliver Xymoron
2002-04-17 19:20 ` David Brownell
5 siblings, 0 replies; 26+ messages in thread
From: arjan @ 2002-04-17 18:44 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-kernel
In article <Pine.LNX.4.33.0204171043260.17271-100000@home.transmeta.com> you wrote:
>
> What were the other suggestions?
usb-target ?
(ala scsi-target-mode)
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 17:57 ` Linus Torvalds
` (3 preceding siblings ...)
2002-04-17 18:44 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 arjan
@ 2002-04-17 19:02 ` Oliver Xymoron
2002-04-17 19:20 ` David Brownell
5 siblings, 0 replies; 26+ messages in thread
From: Oliver Xymoron @ 2002-04-17 19:02 UTC (permalink / raw)
To: Linus Torvalds; +Cc: David Brownell, Greg KH, linux-usb-devel, linux-kernel
On Wed, 17 Apr 2002, Linus Torvalds wrote:
> A "USB device driver" is driver for the mouse/scanner/whatever, ie the
> _other_ end, and that's that. Claiming anything else is just confusing and
> silly.
>
> Since we're talking about the other end of a "host" driver, "client" makes
> sense - in computers, I've always seen "client" as the reverse of the
> "host", but maybe that's just me. Outside of computers, "guest" seems to
> be the proper antonym, but that just strikes me as bizarre (a "USB guest
> driver"?)
Client isn't quite right, as it may imply the other end is 'server'. And
you can certainly think of a USB drive as a 'server' of disk data. Target
is a SCSIism that's too obscure. I suggest 'slave' or a politically
correct variant thereof.
--
"Love the dolphins," she advised him. "Write by W.A.S.T.E.."
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 17:57 ` Linus Torvalds
` (4 preceding siblings ...)
2002-04-17 19:02 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Oliver Xymoron
@ 2002-04-17 19:20 ` David Brownell
2002-04-17 20:07 ` Johannes Erdfelt
5 siblings, 1 reply; 26+ messages in thread
From: David Brownell @ 2002-04-17 19:20 UTC (permalink / raw)
To: Linus Torvalds; +Cc: linux-usb-devel, linux-kernel
> Note that the relevance of the USB spec to most people is exactly 0%.
But to USB developers, if it's not 100% they're in major trouble!
They're the folk who will be using this terminology/API the most.
The challenge here is to come up with something that doesn't
needlessly confuse the major communities of interest ... such
as by redefining terms that are already in use.
> ... there is absolutely _no_ way a Linux "USB
> device driver" will ever mean that the driver turns the box into a USB
> device.
I tend to agree that the volume of such usage will outshout any
others, since a "device side" driver is mostly of interest to a
person doing embedded systems work. (Or a PDA.) Even
there, the scenario is to write one
> Since we're talking about the other end of a "host" driver, "client" makes
> sense - in computers, I've always seen "client" as the reverse of the
> "host", but maybe that's just me.
Another overloaded word. I've always seen it as the requestor,
in all contexts (restaurants, stores, networking ... :) and in USB
it's the "host" that requests.
> What were the other suggestions?
Of the two I saw coming by this morning ("target" from Larry,
and "gadget" from Stephen) I confess I liked "target" best.
It captures the initating/responding roles quite well.
I don't recall many other suggestions that were forthcoming.
But I'll also toss out "firmware", which is often used in such
contexts: firmware revision for a network adapter, and so on.
"USB firmware" is not likely to be expected on the host side.
"USB target firmware", and so on.
- Dave
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
2002-04-17 19:20 ` David Brownell
@ 2002-04-17 20:07 ` Johannes Erdfelt
0 siblings, 0 replies; 26+ messages in thread
From: Johannes Erdfelt @ 2002-04-17 20:07 UTC (permalink / raw)
To: David Brownell; +Cc: Linus Torvalds, linux-usb-devel, linux-kernel
On Wed, Apr 17, 2002, David Brownell <david-b@pacbell.net> wrote:
> > Note that the relevance of the USB spec to most people is exactly 0%.
>
> But to USB developers, if it's not 100% they're in major trouble!
> They're the folk who will be using this terminology/API the most.
>
> The challenge here is to come up with something that doesn't
> needlessly confuse the major communities of interest ... such
> as by redefining terms that are already in use.
I agree. While the relevance of the USB spec to most people is exactly
0%, the relevance to the USB portion of the kernel is almost exactly 0%
as well. I'd much rather cater to the USB developers since they're the
people who will be looking at those names, not anyone else.
Nonetheless, the current naming is a bit confusing.
> > Since we're talking about the other end of a "host" driver, "client" makes
> > sense - in computers, I've always seen "client" as the reverse of the
> > "host", but maybe that's just me.
>
> Another overloaded word. I've always seen it as the requestor,
> in all contexts (restaurants, stores, networking ... :) and in USB
> it's the "host" that requests.
Hmm, good point.
> > What were the other suggestions?
>
> Of the two I saw coming by this morning ("target" from Larry,
> and "gadget" from Stephen) I confess I liked "target" best.
> It captures the initating/responding roles quite well.
I agree too.
> I don't recall many other suggestions that were forthcoming.
>
> But I'll also toss out "firmware", which is often used in such
> contexts: firmware revision for a network adapter, and so on.
> "USB firmware" is not likely to be expected on the host side.
> "USB target firmware", and so on.
This can also be used too, although I typically picture smaller
controllers when it comes to firmware, whereas software runs on more
general purpose controllers, like the ones people would find running
embedded devices and thusly this software.
Anyway, my opinion is that "target" is the best term to use.
JE
^ permalink raw reply [flat|nested] 26+ messages in thread
* RE: [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2)
@ 2002-04-17 19:58 Adam_Kessler
0 siblings, 0 replies; 26+ messages in thread
From: Adam_Kessler @ 2002-04-17 19:58 UTC (permalink / raw)
To: greg, gowdy; +Cc: torvalds, david-b, linux-usb-devel, linux-kernel
I like gadget! It's unambiguous namespace with a ring.
Target sounds to much like a cross-compiler; and boring.
-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Wednesday, April 17, 2002 1:32 PM
To: Stephen J. Gowdy
Cc: Linus Torvalds; David Brownell;
linux-usb-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org
Subject: Re: [linux-usb-devel] Re: [BK PATCH] USB device support for
2.5.8 (take 2)
On Wed, Apr 17, 2002 at 11:41:14AM -0700, Stephen J. Gowdy wrote:
> gadget? non-host?
"gadget" is nice. It's descriptive of what the code is for, without the
bad connotations that "slave" seems to have.
Although those people who actually take USB seriously might not like it
so much, but I don't see any of those people doing Linux development
anyway :)
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 26+ messages in thread
end of thread, other threads:[~2002-04-19 16:22 UTC | newest]
Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-04-16 22:54 [BK PATCH] USB device support for 2.5.8 Greg KH
2002-04-16 22:58 ` Greg KH
2002-04-17 2:51 ` [BK PATCH] USB device support for 2.5.8 (take 2) Greg KH
2002-04-17 2:53 ` Greg KH
2002-04-17 4:35 ` Linus Torvalds
2002-04-17 3:52 ` Greg KH
2002-04-17 5:08 ` Linus Torvalds
2002-04-17 13:44 ` Greg KH
2002-04-17 16:00 ` [linux-usb-devel] " David Brownell
2002-04-17 17:57 ` Linus Torvalds
2002-04-17 18:08 ` Larry McVoy
2002-04-17 18:59 ` Linus Torvalds
2002-04-17 18:14 ` Greg KH
2002-04-17 18:17 ` Greg KH
2002-04-19 5:37 ` George J Karabin
2002-04-19 5:46 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8(take 2) Oliver Neukum
2002-04-19 6:11 ` George J Karabin
2002-04-19 11:06 ` [linux-usb-devel] Re: [BK PATCH] USB device support for2.5.8(take2) Oliver.Neukum
2002-04-19 16:22 ` George J Karabin
2002-04-17 18:41 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Stephen J. Gowdy
2002-04-17 18:31 ` Greg KH
2002-04-17 18:44 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 arjan
2002-04-17 19:02 ` [linux-usb-devel] Re: [BK PATCH] USB device support for 2.5.8 (take 2) Oliver Xymoron
2002-04-17 19:20 ` David Brownell
2002-04-17 20:07 ` Johannes Erdfelt
-- strict thread matches above, loose matches on Subject: below --
2002-04-17 19:58 Adam_Kessler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox