Re: [PATCH] Wrong IRQ for USB on Sony Vaio (dmi_scan.c, pci-irq.c)

[Pete Zaitcev <zaitcev@redhat.com>]

> Broken BIOS of these notebooks assigns IRQ 10 for USB,
> even though it is actually wired to IRQ 9.
> 
> I use PCG-FX240 model of Sony Vaio, but I have proofs of other users, 
> that exactly the same problem exists on models:
> FX200, FX220, FX250, FX270, FX290, FX370, FX503, R505JS, R505JL
> These models use Intel's 82801BA controller, and Phoenix bios.

> Only problem is I don't have DMI Product names for all involved models.
> That's why I left pretty general:
>   MATCH(DMI_PRODUCT_NAME, "PCG-")

My Z505JE works perfectly without it. In general Z505's are
known to work.

> +	/* Work around broken Sony Vaio Notebooks which assign USB to
> +	 * IRQ 10 even though it is actually wired to IRQ 9 
> +	 * Send comments to: Jan Slupski, jslupski@email.com
> +	 */
> +
> +	if (broken_sony_vaio_bios_irq10 && pirq == 0x63 && dev->irq == 9 &&
> +			dev->vendor == 0x8086 && dev->device == 0x2442){
> +		dev->irq = 9;
> +		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, 9);
> +		r->set(pirq_router_dev, dev, pirq, 9);
> +	}

So...

	if (dev->irq == 9) {
		dev->irq = 9;
	}

Are you sure it's right?

-- Pete