From: "David S. Miller" <davem@redhat.com>
To: rusty@rustcorp.com.au
Cc: marcelo@conectiva.br, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TRIVIAL 2.4.19-pre7: smp_call_function not allowed from bh
Date: Sun, 21 Apr 2002 23:16:15 -0700 (PDT) [thread overview]
Message-ID: <20020421.231615.129368238.davem@redhat.com> (raw)
In-Reply-To: <E16zUc3-0000Rk-00@wagner.rustcorp.com.au>
From: Rusty Russell <rusty@rustcorp.com.au>
Date: Mon, 22 Apr 2002 13:35:34 +1000
It would be nice to fix this up on every other smp_call_function
implementation too. Since this patch is by definition trivial, it
would be equally trivial to make sure every platform is updated
properly as well.
Please do this before installing the change.
Thanks.
--- trivial-2.4.19-pre7/arch/i386/kernel/smp.c.orig Mon Apr 22 13:21:41 2002
+++ trivial-2.4.19-pre7/arch/i386/kernel/smp.c Mon Apr 22 13:21:41 2002
@@ -528,7 +528,7 @@
* remote CPUs are nearly ready to execute <<func>> or are or have executed.
*
* You must not call this function with disabled interrupts or from a
- * hardware interrupt handler, you may call it from a bottom half handler.
+ * hardware interrupt handler or from a bottom half handler.
*/
{
struct call_data_struct data;
@@ -544,7 +544,7 @@
if (wait)
atomic_set(&data.finished, 0);
- spin_lock_bh(&call_lock);
+ spin_lock(&call_lock);
call_data = &data;
wmb();
/* Send a message to all other CPUs and wait for them to respond */
next prev parent reply other threads:[~2002-04-22 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-22 3:35 [PATCH] TRIVIAL 2.4.19-pre7: smp_call_function not allowed from bh Rusty Russell
2002-04-22 6:16 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-04-22 12:06 Dipankar Sarma
2002-04-23 2:27 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020421.231615.129368238.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.br \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox