From: Anton Blanchard <anton@samba.org>
To: linux-kernel@vger.kernel.org
Cc: viro@math.psu.edu
Subject: [PATCH] double down() in nfsd_symlink
Date: Sun, 21 Apr 2002 22:53:32 +1000 [thread overview]
Message-ID: <20020421125332.GA28702@krispykreme> (raw)
Hi,
Probably as a result of the recent BKL removal in notify_change,
nfsd_symlink downs the inode semaphore twice (the first time is in
fh_lock). Al does this patch look OK to you?
--- linux-2.5/fs/nfsd/vfs.c Sun Apr 21 22:48:04 2002
+++ linux-2.5_work/fs/nfsd/vfs.c Sun Apr 21 22:38:28 2002
@@ -1127,9 +1127,7 @@
iap->ia_valid |= ATTR_CTIME;
iap->ia_mode = (iap->ia_mode&S_IALLUGO)
| S_IFLNK;
- down(&dentry->d_inode->i_sem);
err = notify_change(dnew, iap);
- up(&dentry->d_inode->i_sem);
if (!err && EX_ISSYNC(fhp->fh_export))
write_inode_now(dentry->d_inode, 1);
}
Anton
reply other threads:[~2002-04-21 12:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020421125332.GA28702@krispykreme \
--to=anton@samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox