* [PATCH] double down() in nfsd_symlink
@ 2002-04-21 12:53 Anton Blanchard
0 siblings, 0 replies; only message in thread
From: Anton Blanchard @ 2002-04-21 12:53 UTC (permalink / raw)
To: linux-kernel; +Cc: viro
Hi,
Probably as a result of the recent BKL removal in notify_change,
nfsd_symlink downs the inode semaphore twice (the first time is in
fh_lock). Al does this patch look OK to you?
--- linux-2.5/fs/nfsd/vfs.c Sun Apr 21 22:48:04 2002
+++ linux-2.5_work/fs/nfsd/vfs.c Sun Apr 21 22:38:28 2002
@@ -1127,9 +1127,7 @@
iap->ia_valid |= ATTR_CTIME;
iap->ia_mode = (iap->ia_mode&S_IALLUGO)
| S_IFLNK;
- down(&dentry->d_inode->i_sem);
err = notify_change(dnew, iap);
- up(&dentry->d_inode->i_sem);
if (!err && EX_ISSYNC(fhp->fh_export))
write_inode_now(dentry->d_inode, 1);
}
Anton
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-04-21 12:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-04-21 12:53 [PATCH] double down() in nfsd_symlink Anton Blanchard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox