From: "David S. Miller" <davem@redhat.com>
To: kaber@trash.net
Cc: kuznet2@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: bug in sch_generic.c:pfifo_fast_enqueue
Date: Wed, 24 Apr 2002 10:51:28 -0700 (PDT) [thread overview]
Message-ID: <20020424.105128.122083622.davem@redhat.com> (raw)
In-Reply-To: <3CB59613.FA9D8F7D@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Thu, 11 Apr 2002 15:56:35 +0200
"David S. Miller" schrieb:
> From: Patrick McHardy <kaber@trash.net>
> Date: Mon, 1 Apr 2002 21:43:03 +0200 (CEST)
>
> I found a small bug in pfifo_fast_enqueue, instead of
>
> if (list->qlen <= skb->dev->tx_queue_len)
> it should be
> if (list->qlen <= qdisc->dev->tx_queue_len)
>
> skb->dev == qdisc->dev should be invariant when this
> code runs. So the code is correct, albeit possibly
> confusing.
Although in normal circumstances the assumption may be right
it fails in this case. It would be nice if you apply my patch
as it doesn't changes anything and enforces correct behaviour
in cases like mine.
Ok, for the sake of consistency, I've made the change.
prev parent reply other threads:[~2002-04-24 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-01 19:43 bug in sch_generic.c:pfifo_fast_enqueue Patrick McHardy
2002-04-11 4:41 ` David S. Miller
2002-04-11 13:56 ` Patrick McHardy
2002-04-24 17:51 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020424.105128.122083622.davem@redhat.com \
--to=davem@redhat.com \
--cc=kaber@trash.net \
--cc=kuznet2@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox