From: Russell King <rmk@arm.linux.org.uk>
To: Andrea Arcangeli <andrea@suse.de>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-kernel@vger.kernel.org, Ihno Krumreich <ihno@suse.de>,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: get_pid fixes against 2.4.19pre7
Date: Fri, 26 Apr 2002 12:53:47 +0100 [thread overview]
Message-ID: <20020426125347.A18131@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020426134409.C19278@dualathlon.random>
On Fri, Apr 26, 2002 at 01:44:09PM +0200, Andrea Arcangeli wrote:
> + set_bit(p->pid, pid_bitmap);
> + set_bit(p->pgrp, pid_bitmap);
> + set_bit(p->tgid, pid_bitmap);
> + set_bit(p->session, pid_bitmap);
Since we're running under a lock, do we really need the guaranteed
atomic (and therefore expensive) set_bit(), or would __set_bit()
suffice?
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-04-26 11:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-26 11:44 get_pid fixes against 2.4.19pre7 Andrea Arcangeli
2002-04-26 11:53 ` Russell King [this message]
2002-04-26 11:57 ` Andrea Arcangeli
2002-04-26 13:16 ` Hubertus Franke
2002-04-27 0:25 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020426125347.A18131@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=andrea@suse.de \
--cc=ihno@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox