From: Dave Jones <davej@suse.de>
To: Pavel Machek <pavel@ucw.cz>
Cc: Martin Dalecki <dalecki@evision-ventures.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.10 IDE 42
Date: Fri, 26 Apr 2002 19:31:21 +0200 [thread overview]
Message-ID: <20020426193121.Y14343@suse.de> (raw)
In-Reply-To: <1019549894.1450.41.camel@turbulence.megapathdsl.net> <3CC7E358.8050905@evision-ventures.com> <20020425172508.GK3542@suse.de> <20020425173439.GM3542@suse.de> <aa9qtb$d8a$1@penguin.transmeta.com> <3CC904AA.7020706@evision-ventures.com> <20020426160911.GE3783@elf.ucw.cz>
On Fri, Apr 26, 2002 at 06:09:11PM +0200, Pavel Machek wrote:
>
> > @@ -839,7 +834,7 @@
> > printk(", sector=%ld", HWGROUP(drive)->rq->sector);
> > }
> > }
> > -#endif /* FANCY_STATUS_DUMPS */
> > +#endif
> > printk("\n");
> > }
> > __restore_flags (flags); /* local CPU only */
>
> Here to. Comment after endif is good thing; you don't have to add it
> but you should certainly not kill it.
In cases where the #if is several pages before, or there multiple nested
#if's, I agree. But when the #if is just a few lines up with no other #if's
around, it's ugly.
We have functions elsewhere in the kernel like this..
void foo (void)
{
#if MY_MEMORY_SUCKS_BUT_LIKE_SILLY_COMMENTS
one_line_of_code();
#endif /* MY_MEMORY_SUCKS_BUT_I_LIKE_SILLY_COMMENTS */
}
What information is this comment adding ?
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-04-26 17:31 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-23 8:18 2.5.9 -- OOPS in IDE code (symbolic dump and boot log included) Miles Lane
2002-04-23 8:00 ` Martin Dalecki
2002-04-23 9:18 ` Jens Axboe
2002-04-23 8:43 ` Martin Dalecki
2002-04-23 9:54 ` Jens Axboe
2002-04-23 17:39 ` Miles Lane
2002-04-23 17:54 ` Miles Lane
2002-04-24 8:06 ` Martin Dalecki
2002-04-24 9:11 ` Jens Axboe
2002-04-24 8:20 ` Martin Dalecki
2002-04-25 11:07 ` Martin Dalecki
2002-04-25 17:25 ` Jens Axboe
2002-04-25 17:34 ` Jens Axboe
2002-04-25 21:02 ` Linus Torvalds
2002-04-26 7:33 ` [PATCH] 2.5.10 UTS_VERSION Martin Dalecki
2002-04-26 9:52 ` Keith Owens
2002-04-26 8:58 ` Martin Dalecki
2002-04-26 7:41 ` [PATCH] 2.5.10 IDE 42 Martin Dalecki
2002-04-26 16:09 ` Pavel Machek
2002-04-26 17:31 ` Dave Jones [this message]
2002-04-26 17:37 ` Linus Torvalds
2002-04-26 20:05 ` Oliver Xymoron
2002-04-26 21:34 ` Martin Dalecki
2002-04-26 22:25 ` Martin Dalecki
2002-04-26 21:32 ` Martin Dalecki
2002-04-26 23:21 ` Rene Rebe
2002-04-26 21:42 ` Martin Dalecki
2002-04-26 16:10 ` Sebastian Droege
2002-04-26 21:28 ` Martin Dalecki
2002-04-26 22:44 ` Padraig Brady
2002-04-28 9:18 ` Kai Henningsen
2002-05-05 15:54 ` [PATCH] 2.5.13 IDE 52 Martin Dalecki
2002-05-05 17:09 ` Jens Axboe
2002-05-05 16:16 ` Martin Dalecki
2002-05-05 15:55 ` [PATCH] 2.5.13 IDE 53 Martin Dalecki
2002-05-06 9:53 ` Russell King
2002-05-06 8:55 ` Martin Dalecki
2002-05-06 23:48 ` jw schultz
2002-05-05 15:56 ` [PATCH 2.5.13 IDE 54 Martin Dalecki
2002-05-07 12:52 ` Paul Mackerras
2002-05-07 12:06 ` Martin Dalecki
2002-05-07 14:40 ` benh
2002-05-07 13:40 ` Martin Dalecki
2002-05-07 15:18 ` benh
2002-05-07 14:07 ` Alan Cox
2002-05-07 13:24 ` Martin Dalecki
2002-04-24 9:29 ` 2.5.9 -- OOPS in IDE code (symbolic dump and boot log included) Luigi Genoni
2002-04-23 18:23 ` Melchior FRANZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020426193121.Y14343@suse.de \
--to=davej@suse.de \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox