From: Dave Jones <davej@suse.de>
To: Corey Minyard <minyard@acm.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH} SMBIOS support
Date: Sat, 27 Apr 2002 05:18:20 +0200 [thread overview]
Message-ID: <20020427051820.D14743@suse.de> (raw)
In-Reply-To: <3CCA1462.9010405@acm.org>
On Fri, Apr 26, 2002 at 10:00:50PM -0500, Corey Minyard wrote:
Hi Corey,
> --- ./arch/i386/kernel/pci-pc.c.smbios Fri Apr 26 10:59:55 2002
> +++ ./arch/i386/kernel/pci-pc.c Fri Apr 26 11:00:13 2002
> @@ -1293,6 +1293,10 @@
> return;
> }
>
> +#ifdef CONFIG_SMBIOS
> +extern void smbios_init(void);
> +#endif
> +
> void __init pcibios_init(void)
> {
> int quad;
> @@ -1322,6 +1326,10 @@
>
> pcibios_fixup_irqs();
> pcibios_resource_survey();
> +
> +#ifdef CONFIG_SMBIOS
> + smbios_init();
> +#endif
>
> #ifdef CONFIG_PCI_BIOS
> if ((pci_probe & PCI_BIOS_SORT) && !(pci_probe & PCI_NO_SORT))
Any reason for initialising it there instead of using a subsys_initcall
from smbios.c ?
> +void __init hexdump (u8 *data, int len)
Something this generic sounding should be static.
> + char str[80];
Worth adding a if (len>80) return here in case of crap biosen?
Or am I overly paranoid?
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-04-27 3:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-27 3:00 [PATCH} SMBIOS support Corey Minyard
2002-04-27 3:18 ` Dave Jones [this message]
2002-04-27 14:45 ` Corey Minyard
2002-04-27 15:01 ` Dave Jones
2002-04-27 15:22 ` Alan Cox
2002-04-28 20:48 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020427051820.D14743@suse.de \
--to=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox