From: Dave Jones <davej@suse.de>
To: Corey Minyard <minyard@acm.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH} SMBIOS support
Date: Sat, 27 Apr 2002 17:01:01 +0200 [thread overview]
Message-ID: <20020427170101.L14743@suse.de> (raw)
In-Reply-To: <3CCA1462.9010405@acm.org> <20020427051820.D14743@suse.de> <3CCAB976.9010109@acm.org>
On Sat, Apr 27, 2002 at 09:45:10AM -0500, Corey Minyard wrote:
> >Any reason for initialising it there instead of using a subsys_initcall
> >from smbios.c ?
> Can you control other orders within the subsystem?
Use different types of _initcall. See include/linux/init.h
> Other things that come later in this subsystem might need it
> Actually, it might be needed before this, I've moved it to before the PCI
> initialization,
> since this contains interrupt information and possible PCI information.
Ok, I overlooked the relationship of PCI to SMBIOS.
As pci is initialised with subsys_initcall, you could initialise
earlier by using core_initcall.
> > > + char str[80];
> >Worth adding a if (len>80) return here in case of crap biosen?
> >Or am I overly paranoid?
> It's printing 16 hex characters every time, so it doesn't matter. And
> it's only debug code, anyway.
Ok.
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-04-27 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-27 3:00 [PATCH} SMBIOS support Corey Minyard
2002-04-27 3:18 ` Dave Jones
2002-04-27 14:45 ` Corey Minyard
2002-04-27 15:01 ` Dave Jones [this message]
2002-04-27 15:22 ` Alan Cox
2002-04-28 20:48 ` Corey Minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020427170101.L14743@suse.de \
--to=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox