public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] TRIVIAL 2.5.12 WP security warning
@ 2002-05-01  7:23 Rusty Russell
  2002-05-01 11:33 ` Dave Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Rusty Russell @ 2002-05-01  7:23 UTC (permalink / raw)
  To: torvalds; +Cc: linux-kernel, Pavel Machek

Pavel Machek <pavel@ucw.cz>: Warn users about machines with non-working WP bit:
  Hi!
  
  This might be good idea, as those machines are not safe for multiuser
  systems.
  

--- trivial-2.5.12/arch/i386/mm/init.c.orig	Wed May  1 17:15:10 2002
+++ trivial-2.5.12/arch/i386/mm/init.c	Wed May  1 17:15:10 2002
@@ -384,7 +384,7 @@
 	local_flush_tlb();
 
 	if (!boot_cpu_data.wp_works_ok) {
-		printk("No.\n");
+		printk("No (that's security hole).\n");
 #ifdef CONFIG_X86_WP_WORKS_OK
 		panic("This kernel doesn't support CPU's with broken WP. Recompile it for a 386!");
 #endif

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] TRIVIAL 2.5.12 WP security warning
  2002-05-01  7:23 [PATCH] TRIVIAL 2.5.12 WP security warning Rusty Russell
@ 2002-05-01 11:33 ` Dave Jones
  2002-05-01 20:21   ` Pavel Machek
  0 siblings, 1 reply; 4+ messages in thread
From: Dave Jones @ 2002-05-01 11:33 UTC (permalink / raw)
  To: Rusty Russell; +Cc: torvalds, linux-kernel, Pavel Machek

On Wed, May 01, 2002 at 05:23:47PM +1000, Rusty Russell wrote:
 > Pavel Machek <pavel@ucw.cz>: Warn users about machines with non-working WP bit:
 >   Hi!
 >   
 >   This might be good idea, as those machines are not safe for multiuser
 >   systems.
 >   
 > -		printk("No.\n");
 > +		printk("No (that's security hole).\n");
 >  #ifdef CONFIG_X86_WP_WORKS_OK

Maybe be a little more explicit in the wording ?

"No. This system is insecure in a multiuser environment.\n" perhaps ?

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] TRIVIAL 2.5.12 WP security warning
  2002-05-01 11:33 ` Dave Jones
@ 2002-05-01 20:21   ` Pavel Machek
  2002-05-01 20:27     ` arjan
  0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2002-05-01 20:21 UTC (permalink / raw)
  To: Dave Jones, Rusty Russell, torvalds, linux-kernel, Pavel Machek

Hi!

>  > Pavel Machek <pavel@ucw.cz>: Warn users about machines with non-working WP bit:
>  >   Hi!
>  >   
>  >   This might be good idea, as those machines are not safe for multiuser
>  >   systems.
>  >   
>  > -		printk("No.\n");
>  > +		printk("No (that's security hole).\n");
>  >  #ifdef CONFIG_X86_WP_WORKS_OK
> 
> Maybe be a little more explicit in the wording ?
> 
> "No. This system is insecure in a multiuser environment.\n" perhaps ?

Looks good.
								Pavel
-- 
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] TRIVIAL 2.5.12 WP security warning
  2002-05-01 20:21   ` Pavel Machek
@ 2002-05-01 20:27     ` arjan
  0 siblings, 0 replies; 4+ messages in thread
From: arjan @ 2002-05-01 20:27 UTC (permalink / raw)
  To: Pavel Machek; +Cc: linux-kernel

In article <20020501202110.GD31317@atrey.karlin.mff.cuni.cz> you wrote:
>> "No. This system is insecure in a multiuser environment.\n" perhaps ?
> 
> Looks good.

bonus points if you make it default to runlevel 1 ;)

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-05-01 20:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-01  7:23 [PATCH] TRIVIAL 2.5.12 WP security warning Rusty Russell
2002-05-01 11:33 ` Dave Jones
2002-05-01 20:21   ` Pavel Machek
2002-05-01 20:27     ` arjan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox