Re: Bug: Discontigmem virt_to_page() [Alpha,ARM,Mips64?]

Andrea Arcangeli
2002-05-03T07:03:53Z

On Thu, May 02, 2002 at 03:39:54PM -0700, Martin J. Bligh wrote:
> > The difference is that if you use discontigmem you don't clobber the
> > common code in any way, there is no "logical/ordinal" abstraction,
> > there is no special table, it's all hidden in the arch section, and the
> > pgdat you need them anyways to allocate from affine memory with numa.
>
> I *want* the logical / ordinal abstraction. That's not a negative thing -
> it reduces the number of complicated things I have to think about,
> allowing me to think more clearly, and write correct code ;-)

That's just overhead. you don't need an additional table
ordinal/logical things.

the only case nonlinear will pay off is when you have to deal with a
single pgdat with physical huge holes in the middle of its per-node
mem_map. You don't have those holes in the middle of the mem_map of each
node, so it's cleaner and faster to avoid nonlinear for you, it's just
overhead.

nonlinear instead definitely pays off with the origin 2k layout shown by
Ralf, or with the iseries machine if the partitioning mandates an huge
number of discontigous chunks.

>
> Not having a multitude of zones to balance in the normal discontigmem
> case also seems like a powerful argument to me ...
>
> M.

Andrea