Re: Bug: Discontigmem virt_to_page() [Alpha,ARM,Mips64?]

Roman Zippel
2002-05-10T00:13:17Z

Hi,

Daniel Phillips wrote:

> Show me where the 'physical' address is actually treated as a physical address.
> You can't, because it isn't. The 'physical' address is merely a zero-based
> logical address, and the code *relies* on it being contiguous.

Most of the code doesn't care about physical addresses, because they
either work with virtual memory or with the page structure. Physical
addresses are only interesting to pass them to the hardware or to put
them into the page table.

> Your code is going to do __pa there, and you are going to go walking into places
> you don't expect. Even you need my logical address space abstraction, or else you
> want to go making global changes to the common kernel code that just add cruft.

So far I've only seen a virtual address with some offset. You can maybe
move that offset around, but you can't remove it. In the end it's the
same.

> I enjoy the feeling of removing cruft, even when it's an uphill battle.

I'm happy to see patches.

bye, Roman