public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: bruce.holzrichter@monster.com
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: my slab cache broken on sparc64
Date: Fri, 03 May 2002 14:05:07 -0700 (PDT)	[thread overview]
Message-ID: <20020503.140507.89264790.davem@redhat.com> (raw)
In-Reply-To: <61DB42B180EAB34E9D28346C11535A781780F2@nocmail101.ma.tmpw.net>

   From: "Holzrichter, Bruce" <bruce.holzrichter@monster.com>
   Date: Fri, 3 May 2002 14:18:55 -0500 

   I am trying to troubleshoot why in 2.5.13, (Though I also saw this in 2.5.7)
   on my UltraSparc, why my slabcache is broken.  Has anyone else seen this?
   
The technique used by the slabcache to verify to pointer
is %100 non-portable and totally wrong.

get_user() MUST be used only on "user pointers", it is being
used on a kernel pointer here.

It would work if the access was surrounded by:

	old_fs = get_fs();
	set_fs(KERNEL_DS);
	... get_user(kernel_pointer) ...
	set_fs (old_fs);

But it is not.

  reply	other threads:[~2002-05-03 21:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-03 19:18 my slab cache broken on sparc64 Holzrichter, Bruce
2002-05-03 21:05 ` David S. Miller [this message]
2002-05-03 22:58   ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2002-05-04  1:54 Holzrichter, Bruce
2002-05-04  3:15 Holzrichter, Bruce
2002-05-04  3:07 ` David S. Miller
2002-05-04  9:46   ` Roman Zippel
2002-05-05 12:44 Holzrichter, Bruce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020503.140507.89264790.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=bruce.holzrichter@monster.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox