Re: PATCH, IDE corruption, 2.4.18

Neil Conway
2002-05-05T02:10:13Z

Ah good stuff, an honest-to-god expert with brains for the picking :)

--- Andre Hedrick <andre@linux-ide.org> wrote: >
> It is a viable check but it the need for it shows another problem in
> the
> code. In the IDEDMA recovery kludges it must be losing the the
> hwgroup
> busy state.

Have I misunderstood then? My understanding was this:
ide_config_drive_speed is doing a SELECT_DRIVE, which is quite liable
to happen during a DMA transfer to/from the other unit on the hwif, and
thus screw up that transfer.

The recovery or not (from the screw-up) is a secondary factor (and it
would be nice if such recoveries worked) but the primary fix is surely
to make sure we don't gratuitously screw up transfers in the first
place.

Or have I just demonstrated my utter ignorance of IDE?

Neil
PS: a secondary issue is that after ide_config_drive_speed buggers up a
transfer, the selected drive is NOT the one that ide_intr expects to be
selected. I haven't yet got any clue if this is also relevant though.