Re: PATCH, IDE corruption, 2.4.18

Neil Conway
2002-05-05T20:44:33Z

--- Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl> wrote:
>
> You've got been mistaken by unfortunate name (Martin changed
> name dmaproc() to udma() in 2.5.12).
> [snip]
> btw. udma() name is really misleading,
> it should be read (u)dma() not udma() :)

Ouch, thanks for the wakeup. I was scanning the code a little too
rapidly it seems...

Martin: why? The old IDE code was admittedly in need of some work, but
a name like dmaproc is very obviously a function. A name like udma is
likely to be (a) misconstrued by lusers like me as a variable, and (b)
misconstrued by all and sundry as something UDMA-specific, rather than
DMA-specific. Would it really be too much grief to rename it back to
dmaproc()? Misleading code will mutate into buggy code.

:-)

Now that a few people have cast their eyes over my report+patch, is it
safe to assume that the problem is real and not specific to my systems?
Also, does anyone understand why screwing up a DMA transfer results in
the trashing of inodes? Even better, how come this hasn't bitten many
more people? Surely there are lots of people out there with disks and
CDs on the same IDE cable...

Neil
(PS: I have reproduced the problem on two systems so far.)