From: Dave Jones <davej@suse.de>
To: Peter Denison <lkml@marshadder.uklinux.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/net/depca.c tidyup
Date: Mon, 6 May 2002 21:41:55 +0200 [thread overview]
Message-ID: <20020506214154.G22215@suse.de> (raw)
In-Reply-To: <20020506193247.C22215@suse.de> <Pine.LNX.4.44.0205061944460.30139-100000@marshall.localnet>
On Mon, May 06, 2002 at 08:01:01PM +0100, Peter Denison wrote:
> - offset = (offset + ALIGN) & ~ALIGN;
> + offset = ALIGN(offset, 8);
>
> And from include/linux/cache.h:
>
> #define ALIGN(x,a) (((x)+(a)-1)&~((a)-1))
>
> So, we're replacing (offset + 8 - 1) & ~(8-1) = (offset + 7) & ~7
> with (((offset)+(8)-1)&~((8)-1)) = ((offset+7)&~7)
Argh, I was looking at the definition in linkage.h
Cursed ctags.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
prev parent reply other threads:[~2002-05-06 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020506193247.C22215@suse.de>
2002-05-06 19:01 ` [PATCH] drivers/net/depca.c tidyup Peter Denison
2002-05-06 19:41 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020506214154.G22215@suse.de \
--to=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@marshadder.uklinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox