Re: [reiserfs-dev] [BK] [2.4] Reiserfs changeset 2 out of 4, please apply.

[Oleg Drokin <green@namesys.com>]

Hello!

On Tue, May 07, 2002 at 11:27:32AM -0400, Chris Mason wrote:
> >  You can get this changeset from bk://thebsh.namesys.com/bk/reiser3-linux-2.4
> >  This changeset are cleaning up reiserfscode, removes stale comments, and
> >  rewrites some "borrowed" functions so that all of the code in reiserfs subdir
> >  should now only belong to NAMESYS.
> It is the end of a release cycle on a stable kernel with huge changes to
> the IDE layer, and we have at least one unconfirmed report of problems
> with reiserfs+IDE after a crash.

That's true.

> This is not the right time to send in cleanups like this, especially
> when they bits as useless as the stuff below.  #1, #2 and #4 look like
> valid fixes.  #3 should probably be mixed with the iput deadlock fix
> like Oleg did in 2.5, and should wait until after 2.4.19.

#2 and $4 are cleanups, #1 and #3 are bugfixes.
And iput deadlock fix is too big of a change for 2.4.19, so it is not included.
Let's see how will it behave in 2.5 first.
And cleanups are harmless ones, so there is no risk of getting these in.

In short, these changes are not "huge", and mostly non-intrusive.

Bye,
    Oleg