Re: Linux-2.5.14..

Daniel Pittman
2002-05-09T06:02:47Z

On Wed, 08 May 2002, Andrew Morton wrote:
> Daniel Pittman wrote:
>> On Mon, 6 May 2002, Linus Torvalds wrote:
>> > On Mon, 6 May 2002, Daniel Pittman wrote:
>> >>
>> >> From the look of the changelog at least a few of the file
>> >> corruption bugs with ext3, 2k block file systems and 2.5 have been
>> >> fixed. Should I expect this release to address the problems I was
>> >> seeing?
>> >
>> > "Expect" is too strong a word. I'd say "hope" - a number of
>> > truncate bugs were fixed, but whether that was what bit you, nobody
>> > knows.
>> >
>> > I suspect the real answer is that we'd love for you to test things
>> > out, but that if it ends up being too painful to recover if the
>> > problems happen again, you probably shouldn't..
>>
>> Right. I got brave enough to test it on a real, live system after
>> extensive fake testing. It seems to work well, at least so far as
>> running the same workload that cause massive file corruption
>> correctly.
>
> hmm.

Not conclusive, I know, but getting a panic after a brief test stopped
it at that point. :)

>> So, I believe that 2.5.14 is working correctly with 2k ext3
>> filesystems, at least for minimal use. I didn't do any sort of
>> extreme load testing or anything like that, being cautious about it.
>
> I've been testing 2.5.14 pretty hard for a couple of days.

[...]

> ext3-journalled is not happy.

Which probably explains my error, then, as I have not stepped back from
data journaled mode on my system.

[...]

> There's a known race between unmount and writeback which is probably
> impossible to trigger. (see the FIXME at __sync_list). Testing the
> fix for that at present.

Well, unmount wouldn't have happened for quite a long time in the
shutdown process, given it was at the initial 'send SIGTERM' stage...

[...]

> So unless you're a JFS or ext3-journalled user, 2.5.14 is OK.

The latter. Ah, well, at least you know.

[...]

> 04 60 -> line 1120. Yup, I get that one too. I assume you were
> testing with data=journal.

Confirmed.
Daniel

--
No, no, you're not thinking, you're just being logical.
-- Niels Bohr