[PATCH][2.5] opl3 OSS emulation compile fixes

[PATCH][2.5] opl3 OSS emulation compile fixes

[Zwane Mwaikambo]

Not so sure wether the ifeq change is what you want though...

--- linux-2.5/sound/drivers/opl3/Makefile.orig	Thu May  9 12:38:42 2002
+++ linux-2.5/sound/drivers/opl3/Makefile	Thu May  9 12:39:20 2002
@@ -9,7 +9,7 @@
 
 snd-opl3-lib-objs := opl3_lib.o opl3_synth.o
 snd-opl3-synth-objs := opl3_seq.o opl3_midi.o opl3_drums.o
-ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
+ifeq ($(subst m,y,$(CONFIG_SND_OSSEMUL)),y)
 snd-opl3-synth-objs += opl3_oss.o
 endif
 
--- linux-2.5/include/sound/opl3.h.orig	Thu May  9 12:34:10 2002
+++ linux-2.5/include/sound/opl3.h	Thu May  9 12:34:18 2002
@@ -287,8 +287,10 @@
 	snd_seq_device_t *seq_dev;	/* sequencer device */
 	snd_midi_channel_set_t * chset;
 
+#ifdef CONFIG_SND_OSSEMUL
 	snd_seq_device_t *oss_seq_dev;	/* OSS sequencer device, WIP */
 	snd_midi_channel_set_t * oss_chset;
+#endif
  
 	snd_seq_kinstr_ops_t fm_ops;
 	snd_seq_kinstr_list_t *ilist;

-- 
http://function.linuxpower.ca
		

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto]

        IMHO, this isn't good. I just gave this a run with 2.5.15, and 
opl3_oss.c wasn't even touched during compile (either into the kernel or as a 
module); it's completely passed over. more than likely when inserted with 
modprobe, OSS emulation would fail from functions not being there. I haven't 
tried that yet, but this would be my guess..

                                                        BL.
On Thu, May 09, 2002 at 02:21:32PM +0200, Zwane Mwaikambo wrote:
> Not so sure wether the ifeq change is what you want though...
> 
> --- linux-2.5/sound/drivers/opl3/Makefile.orig	Thu May  9 12:38:42 2002
> +++ linux-2.5/sound/drivers/opl3/Makefile	Thu May  9 12:39:20 2002
> @@ -9,7 +9,7 @@
>  
>  snd-opl3-lib-objs := opl3_lib.o opl3_synth.o
>  snd-opl3-synth-objs := opl3_seq.o opl3_midi.o opl3_drums.o
> -ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
> +ifeq ($(subst m,y,$(CONFIG_SND_OSSEMUL)),y)
>  snd-opl3-synth-objs += opl3_oss.o
>  endif
>  
> --- linux-2.5/include/sound/opl3.h.orig	Thu May  9 12:34:10 2002
> +++ linux-2.5/include/sound/opl3.h	Thu May  9 12:34:18 2002
> @@ -287,8 +287,10 @@
>  	snd_seq_device_t *seq_dev;	/* sequencer device */
>  	snd_midi_channel_set_t * chset;
>  
> +#ifdef CONFIG_SND_OSSEMUL
>  	snd_seq_device_t *oss_seq_dev;	/* OSS sequencer device, WIP */
>  	snd_midi_channel_set_t * oss_chset;
> +#endif
>   
>  	snd_seq_kinstr_ops_t fm_ops;
>  	snd_seq_kinstr_list_t *ilist;
> 
> -- 
> http://function.linuxpower.ca
> 		
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Brad Littlejohn                         | Email:        tyketto@wizard.com
Unix Systems Administrator,             |           tyketto@ozemail.com.au
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[Zwane Mwaikambo]

On Thu, 9 May 2002, A Guy Called Tyketto wrote:

> 
>         IMHO, this isn't good. I just gave this a run with 2.5.15, and 
> opl3_oss.c wasn't even touched during compile (either into the kernel or as a 
> module); it's completely passed over. more than likely when inserted with 
> modprobe, OSS emulation would fail from functions not being there. I haven't 
> tried that yet, but this would be my guess..

OSS emulation? Or OPL3 OSS emulation?

-- 
http://function.linuxpower.ca
		

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto]

On Fri, May 10, 2002 at 11:47:10AM +0200, Zwane Mwaikambo wrote:
> On Thu, 9 May 2002, A Guy Called Tyketto wrote:
> 
> > 
> >         IMHO, this isn't good. I just gave this a run with 2.5.15, and 
> > opl3_oss.c wasn't even touched during compile (either into the kernel or as a 
> > module); it's completely passed over. more than likely when inserted with 
> > modprobe, OSS emulation would fail from functions not being there. I haven't 
> > tried that yet, but this would be my guess..
> 
> OSS emulation? Or OPL3 OSS emulation?
> 

        This is for OPL3 OSS emulation. With your patch applied to 2.5.15, 
opl3_oss.c was not compiled at all, whether into the kernel, or as a module. 
Also, your patch for include/sound/opl3.h did not need to be applied as the 
#ifdef CONFIG_SND_OSSEMUL and #endif lines are already present sound the two 
variables listed.

                                                        BL.
-- 
Brad Littlejohn                         | Email:        tyketto@wizard.com
Unix Systems Administrator,             |           tyketto@ozemail.com.au
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[Zwane Mwaikambo]

On Fri, 10 May 2002, A Guy Called Tyketto wrote:

>         This is for OPL3 OSS emulation. With your patch applied to 2.5.15, 
> opl3_oss.c was not compiled at all, whether into the kernel, or as a module. 
> Also, your patch for include/sound/opl3.h did not need to be applied as the 
> #ifdef CONFIG_SND_OSSEMUL and #endif lines are already present sound the two 
> variables listed.

For my amusement, could you try loading the opl3 module, i didn't get 
unresolved symbols when i did a depmod. From what i understand of this, 
opl3_oss should not have been compiled indeed unless CONFIG_SND_OSSEMUL 
was specified, although Kysela would know best.

Thanks,
	Zwane

-- 
http://function.linuxpower.ca
		

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto]

On Fri, May 10, 2002 at 03:18:15PM +0200, Zwane Mwaikambo wrote:
> On Fri, 10 May 2002, A Guy Called Tyketto wrote:
> 
> >         This is for OPL3 OSS emulation. With your patch applied to 2.5.15, 
> > opl3_oss.c was not compiled at all, whether into the kernel, or as a module. 
> > Also, your patch for include/sound/opl3.h did not need to be applied as the 
> > #ifdef CONFIG_SND_OSSEMUL and #endif lines are already present sound the two 
> > variables listed.
> 
> For my amusement, could you try loading the opl3 module, i didn't get 
> unresolved symbols when i did a depmod. From what i understand of this, 
> opl3_oss should not have been compiled indeed unless CONFIG_SND_OSSEMUL 
> was specified, although Kysela would know best.
> 

        No problem.. modprobe ran cleanly without any unresolved symbols. 
however, with those programs needing OSS opl3 emulation (xmms, mpg123, 
realplayer to name a few), this won't do much good less they forsake OSS 
altogether. The 3 programs above (except xmms, which I believe works with 
ALSA) depend on /dev/dsp existing for them to run. /dev/dsp gets created 
(using DevFS here) when snd-pcm-oss.o is inserted at modprobe time. Hence, the 
below:

root@bellicha:~# modprobe snd-fm801
modprobe: Can't locate module snd-pcm-oss
/lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: post-install snd-fm801 failed
/lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: insmod snd-fm801 failed

/etc/modules.conf:

# This is for the new ForteMedia 801 card now, using ALSA.
alias char-major-116 snd
# OSS/Free emulation
alias char-major-14 soundcore
alias snd-card-0 snd-fm801
alias sound-slot-0 snd-card-0
alias sound-service-0-0 snd-mixer-oss
alias sound-service-0-1 snd-seq-oss
alias sound-service-0-3 snd-pcm-oss
alias sound-service-0-8 snd-seq-oss
alias sound-service-0-12 snd-pcm-oss
options snd snd_major=116 snd_cards_limit=1
post-install snd-fm801 modprobe "-k" "snd-pcm-oss"

        For those to run, opl3_oss.c needs to be compiled, which leads back to 
where we were before..

                                                        BL.
-- 
Brad Littlejohn                         | Email:        tyketto@wizard.com
Unix Systems Administrator,             |           tyketto@ozemail.com.au
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[Zwane Mwaikambo]

On Fri, 10 May 2002, A Guy Called Tyketto wrote:

>         No problem.. modprobe ran cleanly without any unresolved symbols. 
> however, with those programs needing OSS opl3 emulation (xmms, mpg123, 
> realplayer to name a few), this won't do much good less they forsake OSS 
> altogether. The 3 programs above (except xmms, which I believe works with 
> ALSA) depend on /dev/dsp existing for them to run. /dev/dsp gets created 
> (using DevFS here) when snd-pcm-oss.o is inserted at modprobe time. Hence, the 
> below:
> 
> root@bellicha:~# modprobe snd-fm801
> modprobe: Can't locate module snd-pcm-oss
> /lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: post-install snd-fm801 failed
> /lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: insmod snd-fm801 failed

But isn't that PCM OSS emulation? Did you compile with CONFIG_SND_PCM_OSS? 
>From what i see opl3_oss is WIP.

Forgive me if i'm missing something fundamental...

-- 
http://function.linuxpower.ca
		

Re: [PATCH][2.5] opl3 OSS emulation compile fixes

[A Guy Called Tyketto]

On Sat, May 11, 2002 at 01:51:33PM +0200, Zwane Mwaikambo wrote:
> On Fri, 10 May 2002, A Guy Called Tyketto wrote:
> 
> >         No problem.. modprobe ran cleanly without any unresolved symbols. 
> > however, with those programs needing OSS opl3 emulation (xmms, mpg123, 
> > realplayer to name a few), this won't do much good less they forsake OSS 
> > altogether. The 3 programs above (except xmms, which I believe works with 
> > ALSA) depend on /dev/dsp existing for them to run. /dev/dsp gets created 
> > (using DevFS here) when snd-pcm-oss.o is inserted at modprobe time. Hence, the 
> > below:
> > 
> > root@bellicha:~# modprobe snd-fm801
> > modprobe: Can't locate module snd-pcm-oss
> > /lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: post-install snd-fm801 failed
> > /lib/modules/2.5.15/kernel/sound/pci/snd-fm801.o: insmod snd-fm801 failed
> 
> But isn't that PCM OSS emulation? Did you compile with CONFIG_SND_PCM_OSS? 
> >From what i see opl3_oss is WIP.
> 
> Forgive me if i'm missing something fundamental...

        You're right. I did:

CONFIG_SND=m
CONFIG_SND_SEQUENCER=m
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=m
CONFIG_SND_PCM_OSS=m
CONFIG_SND_SEQUENCER_OSS=m
CONFIG_SND_DEBUG=y
CONFIG_SND_DEBUG_MEMORY=y
CONFIG_SND_DEBUG_DETECT=y

        But, according to sound/core/Config.in:

dep_bool '  OSS API emulation' CONFIG_SND_OSSEMUL $CONFIG_SND
 if [ "$CONFIG_SND_OSSEMUL" = "y" ]; then
   dep_tristate '    OSS Mixer API' CONFIG_SND_MIXER_OSS $CONFIG_SND
   dep_tristate '    OSS PCM API' CONFIG_SND_PCM_OSS $CONFIG_SND
  if [ "$CONFIG_SND_SEQUENCER" != "n" ]; then
    dep_tristate '    OSS Sequencer API' CONFIG_SND_SEQUENCER_OSS $CONFIG_SND_SEQUENCER
  fi
fi

        If I'm reading this right, CONFIG_SND_PCM_OSS would depend on 
CONFIG_SND_OSSEMUL being set.

        Interestingly enough, I just ran a diff -uNr between the sound/ TLDs 
of the 2.5.15 and 2.5.7 trees, and there hasn't been a change in 
sound/drivers/opl3/opl3_oss.c, although it could have changed between 2.5.7 
and 2.5.14. It was 2.5.14 where I originally noticed the breakage.

                                                        BL.
-- 
Brad Littlejohn                         | Email:        tyketto@wizard.com
Unix Systems Administrator,             |           tyketto@ozemail.com.au
Web + NewsMaster, BOFH.. Smeghead! :)   |   http://www.wizard.com/~tyketto
  PGP: 1024D/E319F0BF 6980 AAD6 7329 E9E6 D569  F620 C819 199A E319 F0BF