From: James Bottomley <James.Bottomley@SteelEye.com>
To: Russell King <rmk@arm.linux.org.uk>
Cc: James Bottomley <James.Bottomley@SteelEye.com>,
viro@math.psu.edu, linux-kernel@vger.kernel.org,
torvalds@transmeta.com
Subject: Re: [PATCH] fix for initrd breakage in 2.5.13+
Date: Wed, 15 May 2002 15:35:28 -0400 [thread overview]
Message-ID: <200205151935.g4FJZSL04191@localhost.localdomain> (raw)
In-Reply-To: Message from Russell King <rmk@arm.linux.org.uk> of "Wed, 15 May 2002 19:54:22 BST." <20020515195421.C28997@flint.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
rmk@arm.linux.org.uk said:
> --- drivers/block/rd.c Fri May 3 03:26:05 2002 +++ /tmp/rd.c Mon May
> 6 03:00:00 2002 @@ -376,6 +376,7 @@
> rd_bdev[unit] = bdget(kdev_t_to_nr(inode->i_rdev));
> rd_bdev[unit]->bd_openers++;
> rd_bdev[unit]->bd_inode->i_mapping->a_ops = &ramdisk_aops;
> + rd_bdev[unit]->bd_block_size = rd_blocksize;
> }
> return 0;
Ah Thanks!. Yes, that's the bit I was looking for. It also explains why
bd_openers was already incremented.
I think you still need to set the block queue hardsect size correctly as well,
so the final fix for the initrd problems should be the attached (which works
for me).
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 1137 bytes --]
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.513 -> 1.514
# drivers/block/rd.c 1.35 -> 1.36
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/05/15 jejb@mulgrave.(none) 1.514
# rd.c blocksize fix
# --------------------------------------------
#
diff -Nru a/drivers/block/rd.c b/drivers/block/rd.c
--- a/drivers/block/rd.c Wed May 15 15:21:55 2002
+++ b/drivers/block/rd.c Wed May 15 15:21:55 2002
@@ -376,6 +376,7 @@
rd_bdev[unit] = bdget(kdev_t_to_nr(inode->i_rdev));
rd_bdev[unit]->bd_openers++;
rd_bdev[unit]->bd_inode->i_mapping->a_ops = &ramdisk_aops;
+ rd_bdev[unit]->bd_block_size = rd_blocksize;
}
return 0;
@@ -424,6 +425,7 @@
}
blk_queue_make_request(BLK_DEFAULT_QUEUE(MAJOR_NR), &rd_make_request);
+ blk_queue_hardsect_size(BLK_DEFAULT_QUEUE(MAJOR_NR), rd_blocksize);
for (i = 0; i < NUM_RAMDISKS; i++) {
/* rd_size is given in kB */
prev parent reply other threads:[~2002-05-15 19:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-15 16:53 [PATCH] fix for initrd breakage in 2.5.13+ James Bottomley
2002-05-15 18:54 ` Russell King
2002-05-15 19:35 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200205151935.g4FJZSL04191@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox