public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Luethi <rl@hellgate.ch>
To: "Ivan G." <ivangurdiev@linuxfreemail.com>
Cc: Urban Widmark <urban@teststation.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VIA Rhine stalls: TxAbort handling
Date: Thu, 16 May 2002 16:19:44 +0200	[thread overview]
Message-ID: <20020516141944.GB31759@k3.hellgate.ch> (raw)
In-Reply-To: <20020514035318.GA20088@k3.hellgate.ch> <02051317475500.00917@cobra.linux> <20020516004927.GA13388@k3.hellgate.ch> <02051515523500.01017@cobra.linux>

On Wed, 15 May 2002 15:52:35 -0600, Ivan G. wrote:
> The slowdown I was talking about was actually with the new abort/underrun 
> handling - I had tried it by myself before your patch. That's the what that 
> quote was about. I think I handled both Abort and Underrun like that.
> I'll try that new patch that you're making to retest.

How a different abort handling could cause a slow down is beyond me,
especially if you used the old code where the aborted frame got
reactivated. With the vanilla code, you were bound to stall on the first tx
error, which should certainly decrease troughput by a fair bit. And unless
a tx error occurs, both versions (of the code) behave identically. I'm
afraid I don't understand what's going on with the VT86C100A.

> On Urban's question,  I test without MMIO so this is not a related issue. I 
> was merely curious since I don't feel comfortable trusting something which
> A) does not match any of the other Rhine-based cards (2's and 3's)
> B) says RESERVED in the docs which I have.
> 
> Funny, I was going to send you a link to the newer docs, but I ran into the 
> older ones which I had never seen before. Yes, they do agree with the current 
> code. Hmm. Perhaps we should ask VIA why it was changed...

I'd take the docs with a grain of salt, especially the VT86C100A data sheet
(the one I have, anyway) contains so blatant mistakes it's downright
confusing.

Roger

  reply	other threads:[~2002-05-16 14:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-14  3:53 [PATCH] VIA Rhine stalls: TxAbort handling Roger Luethi
2002-05-13 23:51 ` Ivan G.
2002-05-14 17:28   ` Urban Widmark
2002-05-16  0:49   ` Roger Luethi
2002-05-15 21:52     ` Ivan G.
2002-05-16 14:19       ` Roger Luethi [this message]
2002-05-14  0:03 ` Ivan G.
2002-05-14 14:11 ` Jeff Garzik
2002-05-14 15:08   ` Roger Luethi
2002-05-14 17:47 ` Urban Widmark
2002-05-16  0:51   ` Roger Luethi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020516141944.GB31759@k3.hellgate.ch \
    --to=rl@hellgate.ch \
    --cc=ivangurdiev@linuxfreemail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=urban@teststation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox