Re: AUDIT: copy_from_user is a deathtrap.

Linus Torvalds
2002-05-20T16:00:49Z

On Mon, 20 May 2002, Rusty Russell wrote:
>
> Not quite:
> copy_from_user(xxx);
>
> Is my suggestion. No error return.

The fact is, that that would still make you have to audit all the users,
AND you'd be left up shit creek for the users who _need_ the error return,
so now you not only have to fix all existing broken stuff, you have to fix
the _correct_ stuff too some strange way. I agree with returning SIGSEGV,
but it is NOT a _replacement_ for getting the right error return from
read/write.

So what's your point? You want to dumb down the interfaces until you can't
make mistakes, and only idiots will be able to use the system.

As long as you continue to push an interface that DOES NOT WORK, there's
no way you can win this argument. read()/write() _needs_ to work, and
that's not a "warm and fuzzy" kind of thing you can play with.

Linus