Re: AUDIT: copy_from_user is a deathtrap.

Rusty Russell
2002-05-17T12:19:57Z

In message <E178gfl-0006Ip-00@the-village.bc.nu> you write:
> > > I would much rather fix these instances than add yet another
> > > interface.
> >
> > I'll accept that if someone's volunteering to audit the kernel for
> > them every six months.
> >
> > Sorry I wasn't clear: I'm saying *replace*, not add,
>
> Replace requires you audit every single use, and then work out how to
> handle those that do care about the length and the point it faulted.

Read my original post. I have done this.

> From what I've seen of the stuff that has been fixed we have a mix
> of the following
>
> 1. Misports of ancient verify_* code - eg the serial ones
> 2. Not checking the return code - 100% legal and standards compliant

No, the 400+ are all of form:

/* of course this returns 0 or -EFAULT! */
return copy_from_user(xxx);

Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.