Re: AUDIT: copy_from_user is a deathtrap.

Rusty Russell
2002-05-19T03:35:23Z

> Um, what about delivering a SIGSEGV? So, copy_to/from_user always
> returns 0, but a signal is delivered. Then the only places which need
> to be clever are the mount option copying, and the signal delivery
> code for SIGSEGV (which uses copy_to_user).

Sorry, this doesn't work here either: this would return the wrong
value from read.

Of course, everyone who does more than one copy_to_user should be
checking that return value, and not doing:

if (copy_to_user(uptr....)
|| copy_to_user(uptr+10,....)
return -EFAULT

So that such gc schemes actually work,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.