Re: AUDIT of 2.5.15 copy_to/from_user

Alan Cox
2002-05-20T11:27:40Z

> Disagree. May not cause problems at the moment, but a function which
> does:
>
> if (!access_ok (VERIFY_WRITE, to, sizeof(siginfo_t)))
> return -EFAULT;
> if (from->si_code < 0)
> return __copy_to_user(to, from, sizeof(siginfo_t));
>
> Is clearly wrong,

Its a function that returns non zero for error. Its clearly right. It just
doesn't conform to Rusty's grand vision.