From: Andrey Panin <pazke@orbita1.ru>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SLC82C105 IDE driver: missing __init
Date: Wed, 22 May 2002 18:09:38 +0400 [thread overview]
Message-ID: <20020522140938.GA314@pazke.ipt> (raw)
In-Reply-To: <20020522091648.GB312@pazke.ipt> <E17AVsU-0001aF-00@the-village.bc.nu>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Wed, May 22, 2002 at 02:10:06PM +0100, Alan Cox wrote:
> > slc82c105_bridge_revision() functions lacks __init modifier.
> > Attached patch (against 2.5.17) fixes it.
> > Compiles, but untested. Please consider applying.
>
> I wouldnt get too carried away with these. Once the IDE core is clean
> enough to allow hot plugging of IDE interfaces those __init's are all going
> to need changing anyway
Then we'll grep and change them to __devinit.
But missing __init can't be changed :))
> (and yes you can get hot pluggable IDE setups already - the mobility stuff
> for example has a case with a PCI split bridge, 3 or 4 PCI slots and
> connects to the cardbus on a laptop)
--
Andrey Panin | Embedded systems software engineer
pazke@orbita1.ru | PGP key: wwwkeys.eu.pgp.net
[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]
prev parent reply other threads:[~2002-05-22 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-22 9:16 [PATCH] SLC82C105 IDE driver: missing __init Andrey Panin
2002-05-22 9:36 ` Russell King
2002-05-22 8:40 ` Martin Dalecki
2002-05-22 13:10 ` Alan Cox
2002-05-22 14:09 ` Andrey Panin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020522140938.GA314@pazke.ipt \
--to=pazke@orbita1.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox