[PATCH] SLC82C105 IDE driver: missing __init

[PATCH] SLC82C105 IDE driver: missing __init

[Andrey Panin]

[-- Attachment #1.1: Type: text/plain, Size: 302 bytes --]

Hi,

slc82c105_bridge_revision() functions lacks __init modifier.
Attached patch (against 2.5.17) fixes it.
Compiles, but untested. Please consider applying.

Best regards.

-- 
Andrey Panin            | Embedded systems software engineer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net

[-- Attachment #1.2: patch-slc82c105 --]
[-- Type: text/plain, Size: 521 bytes --]

diff -urN -X /usr/share/dontdiff linux.vanilla/drivers/ide/sl82c105.c linux/drivers/ide/sl82c105.c
--- linux.vanilla/drivers/ide/sl82c105.c	Tue May 21 01:56:18 2002
+++ linux/drivers/ide/sl82c105.c	Wed May 22 03:10:09 2002
@@ -185,7 +185,7 @@
  * Return the revision of the Winbond bridge
  * which this function is part of.
  */
-static unsigned int sl82c105_bridge_revision(struct pci_dev *dev)
+static unsigned int __init sl82c105_bridge_revision(struct pci_dev *dev)
 {
 	struct pci_dev *bridge;
 	unsigned char rev;

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [PATCH] SLC82C105 IDE driver: missing __init

[Russell King]

On Wed, May 22, 2002 at 01:16:48PM +0400, Andrey Panin wrote:
> slc82c105_bridge_revision() functions lacks __init modifier.
> Attached patch (against 2.5.17) fixes it.
> Compiles, but untested. Please consider applying.

I'm surprised it compiles.  I've got a rather major update to it here,
but I need to find time to pull it out of the ARM patch, and I need IDE
to settle down a bit so the two are actually in sync with each other.
(Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm
waiting for the fix to emerge, which I think is in 2.5.17, but the TLB
stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or
test anything on 2.5 currently.)

Too many things to do... too many problems to solve... too many patches
to look at... too much email... not enough hours in the day... not enough
fast machines to build kernels on... not enough rmk clones to run kernel
tests... 8)

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: [PATCH] SLC82C105 IDE driver: missing __init

[Martin Dalecki]

Uz.ytkownik Russell King napisa?:
> On Wed, May 22, 2002 at 01:16:48PM +0400, Andrey Panin wrote:
> 
>>slc82c105_bridge_revision() functions lacks __init modifier.
>>Attached patch (against 2.5.17) fixes it.
>>Compiles, but untested. Please consider applying.
> 
> 
> I'm surprised it compiles. 

I'm not :-). I wouldn't be even surprised if it works by accident...

> I've got a rather major update to it here,
> but I need to find time to pull it out of the ARM patch, and I need IDE
> to settle down a bit so the two are actually in sync with each other.
> (Martin messed up my DMA changes which'd prevent sl82c105 linking - I'm
> waiting for the fix to emerge, which I think is in 2.5.17, but the TLB

It should indeed be all in place right now. Other then this: If you feel like
something in the generic code has to be changed - don't hessitate just
do it. We can always sort it out.

> stuff in 2.5.17 has broken all my ARM builds, so I'm unable to build or
> test anything on 2.5 currently.)

Just to make it clean - this time it was not me ;-).

> 
> Too many things to do... too many problems to solve... too many patches
> to look at... too much email... not enough hours in the day... not enough
> fast machines to build kernels on... not enough rmk clones to run kernel
> tests... 8)

Re: [PATCH] SLC82C105 IDE driver: missing __init

[Alan Cox]

> slc82c105_bridge_revision() functions lacks __init modifier.
> Attached patch (against 2.5.17) fixes it.
> Compiles, but untested. Please consider applying.

I wouldnt get too carried away with these. Once the IDE core is clean
enough to allow hot plugging of IDE interfaces those __init's are all going
to need changing anyway

(and yes you can get hot pluggable IDE setups already - the mobility stuff
 for example has a case with a PCI split bridge, 3 or 4 PCI slots and
 connects to the cardbus on a laptop)

Re: [PATCH] SLC82C105 IDE driver: missing __init

[Andrey Panin]

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Wed, May 22, 2002 at 02:10:06PM +0100, Alan Cox wrote:
> > slc82c105_bridge_revision() functions lacks __init modifier.
> > Attached patch (against 2.5.17) fixes it.
> > Compiles, but untested. Please consider applying.
> 
> I wouldnt get too carried away with these. Once the IDE core is clean
> enough to allow hot plugging of IDE interfaces those __init's are all going
> to need changing anyway

Then we'll grep and change them to __devinit. 
But missing __init can't be changed :))

> (and yes you can get hot pluggable IDE setups already - the mobility stuff
>  for example has a case with a PCI split bridge, 3 or 4 PCI slots and
>  connects to the cardbus on a laptop)

-- 
Andrey Panin            | Embedded systems software engineer
pazke@orbita1.ru        | PGP key: wwwkeys.eu.pgp.net

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]