From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 22 May 2002 13:31:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 22 May 2002 13:31:54 -0400 Received: from cpe-24-221-152-185.az.sprintbbd.net ([24.221.152.185]:8328 "EHLO opus.bloom.county") by vger.kernel.org with ESMTP id ; Wed, 22 May 2002 13:31:51 -0400 Date: Wed, 22 May 2002 10:31:37 -0700 From: Tom Rini To: Martin Dalecki Cc: Linus Torvalds , Kernel Mailing List Subject: Re: [PATCH] 2.5.17 IDE 67 Message-ID: <20020522173137.GH1209@opus.bloom.county> In-Reply-To: <3CEB466B.3090604@evision-ventures.com> <20020522171329.GG1209@opus.bloom.county> <3CEBC576.4060703@evision-ventures.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 22, 2002 at 06:21:10PM +0200, Martin Dalecki wrote: > Uz.ytkownik Tom Rini napisa?: > >On Wed, May 22, 2002 at 09:19:07AM +0200, Martin Dalecki wrote: > > > > > >>Wed May 22 01:43:54 CEST 2002 ide-clean-67 > >> > >>- Nuke COMMERIAL and similar spurious configuration options... > >> The fact that every single default configuration option contained > >> those bits makes this trivial patch appear rather big. > > > > > >This also nukes CONFIG_DMA_NONPCI. While this probably shouldn't have > >been define_bool'ed to 'n' all of the time, there are cases where this > >seems to be properly used. I know PPC4xx uses it (or will be using it > >once the driver is ready to be submitted) and it looks like cris uses it > >as well. > > No I checked. PPC4xx had no functional code for the case > of CONFIG_DMA_NONPCI. It just looked like it had. You checked the kernel.org tree, not the PPC tree. > Look at the patch and see that it is removing the two > nonpci_xxx functions which are nowhere defined! Because the driver isn't quite ready to be submitted just yet. > The __CRIS__ behaviour is preserved and BTW. > not pretty as well. > But this can be fixed a bit later... And when the PPC4xx drivers are ready to be submitted we'll need to add in __powerpc__ tests too. Can't we just keep CONFIG_DMA_NONPCI for now? -- Tom Rini (TR1265) http://gate.crashing.org/~trini/