public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dan Kegel <dank@kegel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"khttpd-users@lists.alt.org" <khttpd-users@alt.org>,
	"linuxppc-embedded@lists.linuxppc.org" 
	<linuxppc-embedded@lists.linuxppc.org>,
	lord@sgi.com
Subject: Re: khttpd and tmpfs don't get along?
Date: Wed, 22 May 2002 20:33:28 +0100	[thread overview]
Message-ID: <20020522203328.A22461@infradead.org> (raw)
In-Reply-To: <3CEAF6F2.BB70395D@kegel.com> <20020522095440.A13744@infradead.org> <3CEBEF97.1BEBF36C@kegel.com>

On Wed, May 22, 2002 at 12:20:55PM -0700, Dan Kegel wrote:
> I just now crashed Red Hat 7.3 on x86 SMP by compiling in khttpd
> and serving files out of a tmpfs.  It crashed with or without my 
> earlier patch (http://www.kegel.com/linux/khttpd/khttpd-unbork.patch)
> that fixes khttpd crashes with other filesystems.
> Guess it wasn't a bug in linuxppc_2_4_devel after all.

I doubt it. the use of do_generic_file_read outside of code the filesystem
has selected to use (i.e. generic methods) is FUNDAMENTALLY broken.

Some time ago I though I found a similar bug in XFS, but Steve Lord says
it's not exploitable in real world (XFS uses the generic methods with
additional locking around it).

The only sane soloution is to get rid of that abuse in khttpd, loop and
sys_sendfile.


      reply	other threads:[~2002-05-22 19:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-22  1:40 khttpd and tmpfs don't get along? Dan Kegel
2002-05-22  8:54 ` Christoph Hellwig
2002-05-22 19:20   ` Dan Kegel
2002-05-22 19:33     ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020522203328.A22461@infradead.org \
    --to=hch@infradead.org \
    --cc=dank@kegel.com \
    --cc=khttpd-users@alt.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-embedded@lists.linuxppc.org \
    --cc=lord@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox