[2.5.17-cset1.656] patch to compile nfs (and maybe others)

[2.5.17-cset1.656] patch to compile nfs (and maybe others)

[Sebastian Droege]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

Hi,
this trivial patch adds 3 missing #includes
without them at least nfs won't compile

Bye

diff -Nur test/linux-2.5.17/include/linux/dcache.h linux-2.5.17/include/linux/dcache.h
--- test/linux-2.5.17/include/linux/dcache.h    Tue May 21 07:07:39 2002
+++ linux-2.5.17/include/linux/dcache.h Thu May 23 16:40:14 2002
@@ -6,6 +6,7 @@
 #include <asm/atomic.h>
 #include <linux/mount.h>
 #include <asm/page.h>                  /* for BUG() */
+#include <linux/spinlock.h>
 
 /*
  * linux/include/linux/dcache.h
diff -Nur test/linux-2.5.17/include/linux/mount.h linux-2.5.17/include/linux/mount.h
--- test/linux-2.5.17/include/linux/mount.h     Tue May 21 07:07:31 2002
+++ linux-2.5.17/include/linux/mount.h  Thu May 23 18:18:23 2002
@@ -12,6 +12,8 @@
 #define _LINUX_MOUNT_H
 #ifdef __KERNEL__
 
+#include <linux/list.h>
+
 #define MNT_NOSUID     1
 #define MNT_NODEV      2
 #define MNT_NOEXEC     4
diff -Nur test/linux-2.5.17/include/linux/namei.h linux-2.5.17/include/linux/namei.h
--- test/linux-2.5.17/include/linux/namei.h     Thu May 23 17:51:37 2002
+++ linux-2.5.17/include/linux/namei.h  Thu May 23 15:58:54 2002
@@ -1,6 +1,8 @@
 #ifndef _LINUX_NAMEI_H
 #define _LINUX_NAMEI_H
 
+#include <linux/linkage.h>
+
 struct vfsmount;
 
 struct nameidata {

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [2.5.17-cset1.656] patch to compile nfs (and maybe others)

[Christoph Hellwig]

On Thu, May 23, 2002 at 06:26:01PM +0200, Sebastian Droege wrote:
> Hi,
> this trivial patch adds 3 missing #includes
> without them at least nfs won't compile

Please don't add additional includes to namei.h - it's purpose is to
ubbork the headers instead of makeing them more complicated.

I have another bunch of header fixes (including the proper fixe for
this failure) queued up for Linux after the buffer_head.h stuff goes in.

Re: [2.5.17-cset1.656] patch to compile nfs (and maybe others)

[David S. Miller]

   From: Sebastian Droege <sebastian.droege@gmx.de>
   Date: Thu, 23 May 2002 18:41:41 +0200

   Ok... but then we've to copy the FASTCALL stuff (which is used
   elsewhere too) from linkage.h to namei.h or something else...

namei.h should include linkage.h and I sent precisely that
to Linus last evening...

Re: [2.5.17-cset1.656] patch to compile nfs (and maybe others)

[Sebastian Droege]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

On Thu, 23 May 2002 17:34:25 +0100
Christoph Hellwig <hch@infradead.org> wrote:

> On Thu, May 23, 2002 at 06:26:01PM +0200, Sebastian Droege wrote:
> > Hi,
> > this trivial patch adds 3 missing #includes
> > without them at least nfs won't compile
> 
> Please don't add additional includes to namei.h - it's purpose is to
> ubbork the headers instead of makeing them more complicated.
> 
> I have another bunch of header fixes (including the proper fixe for
> this failure) queued up for Linux after the buffer_head.h stuff goes in.
> 
Ok... but then we've to copy the FASTCALL stuff (which is used elsewhere too) from linkage.h to namei.h or something else...
Thanks anyway

Bye

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: [2.5.17-cset1.656] patch to compile nfs (and maybe others)

[Christoph Hellwig]

On Thu, May 23, 2002 at 09:36:01AM -0700, David S. Miller wrote:
>    From: Sebastian Droege <sebastian.droege@gmx.de>
>    Date: Thu, 23 May 2002 18:41:41 +0200
> 
>    Ok... but then we've to copy the FASTCALL stuff (which is used
>    elsewhere too) from linkage.h to namei.h or something else...
> 
> namei.h should include linkage.h and I sent precisely that
> to Linus last evening...

It is pulled in through kernel.h - one of the first headers kernel
sources are expected to include.  Please don't mess up the headers
again, I've spent lots of work to get rid of the horrible header
depencies Linux has.