From: Russell King <rmk@arm.linux.org.uk>
To: Tim Schmielau <tim@physik3.uni-rostock.de>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [rfc,patch] breaking up sched.h
Date: Fri, 24 May 2002 21:52:49 +0100 [thread overview]
Message-ID: <20020524215249.C11638@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.33.0205242219001.30843-100000@gans.physik3.uni-rostock.de>
On Fri, May 24, 2002 at 10:34:04PM +0200, Tim Schmielau wrote:
> While the latter three are probably better hosted in
> <linux/capability.h>, I'm unsure where to move the former two.
> <linux/irq.h> seems quite natural, but it starts with a comment
>
> /*
> * Please do not include this file in generic code. There is currently
> * no requirement for any architecture to implement anything held
> * within this file.
> *
> * Thanks. --rmk
> */
>
> so that seems to be no-go. Any alternative suggestions?
The problem with linux/irq.h is that it makes many assumptions about the
per-architecture irq code. If anyone needs to include it (in its current
form), then they're accessing architecture private data that may or may
not be present.
Maybe the correct thing would be to move linux/irq.h to linux/hw_irq.h
(so it matches asm/hw_irq.h) and move request_irq() and friends into a
new linux/irq.h
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-05-24 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-24 20:34 [rfc,patch] breaking up sched.h Tim Schmielau
2002-05-24 20:52 ` Russell King [this message]
2002-05-24 21:07 ` Tim Schmielau
2002-05-25 22:57 ` Daniel Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020524215249.C11638@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox