public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: A Guy Called Tyketto <tyketto@wizard.com>
Cc: Dave Jones <davej@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.5.18-dj1
Date: Sun, 26 May 2002 09:00:47 +0100	[thread overview]
Message-ID: <20020526090046.A32058@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020526014439.GA19527@suse.de> <20020526075314.GA1307@wizard.com>

On Sun, May 26, 2002 at 12:53:14AM -0700, A Guy Called Tyketto wrote:
> >>EIP; c01cbd2d <fb_copy_cmap+9d/2b0>   <=====

This oops has existed over several 2.5 versions.  The following was thrown
around to fix it (I don't remember who though).

--- orig/drivers/video/fbcmap.c	Fri May  3 11:12:44 2002
+++ linux/drivers/video/fbcmap.c	Fri May 10 19:39:38 2002
@@ -150,9 +150,9 @@
     else
 	tooff = from->start-to->start;
     size = to->len-tooff;
-    if (size > from->len-fromoff)
+    if (size > (int)(from->len-fromoff))
 	size = from->len-fromoff;
-    if (size < 0)
+    if (size <= 0)
 	return;
     size *= sizeof(u16);
     


-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


  reply	other threads:[~2002-05-26  8:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-26  1:44 Linux 2.5.18-dj1 Dave Jones
2002-05-26  7:53 ` A Guy Called Tyketto
2002-05-26  8:00   ` Russell King [this message]
2002-05-26 11:42     ` Paul Mackerras
2002-05-28 17:32       ` James Simmons
2002-05-28 17:31     ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020526090046.A32058@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=davej@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tyketto@wizard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox