From: David Weinehall <tao@acc.umu.se>
To: Pavel Machek <pavel@ucw.cz>
Cc: torvalds@transmeta.com, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: swsusp: fix compilation for other architectures
Date: Tue, 28 May 2002 07:33:03 +0200 [thread overview]
Message-ID: <20020528073303.K9911@khan.acc.umu.se> (raw)
In-Reply-To: <20020527172156.GA3907@elf.ucw.cz>
On Mon, May 27, 2002 at 07:21:56PM +0200, Pavel Machek wrote:
> Hi!
>
> Currently, on machine where suspend is not yet supported, compilation
> fails even in case user did not actually requested suspend. This
> "fixes" it -- compilation only fails when suspend is needed and not
> supported. Please apply,
> Pavel
>
> --- clean/include/asm-i386/suspend.h Sun May 26 19:32:03 2002
> +++ linux-swsusp/include/asm-i386/suspend.h Mon May 27 19:11:25 2002
> @@ -1,13 +1,8 @@
> -#ifndef __ASM_I386_SUSPEND_H
> -#define __ASM_I386_SUSPEND_H
> -#endif
You probably want to move the #endif to the end of the file instead of
removing it; having #ifndef/#define/#endif-traps for all header-files is
good practice.
/David Weinehall
_ _
// David Weinehall <tao@acc.umu.se> /> Northern lights wander \\
// Maintainer of the v2.0 kernel // Dance across the winter sky //
\> http://www.acc.umu.se/~tao/ </ Full colour fire </
next prev parent reply other threads:[~2002-05-28 5:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-27 17:21 swsusp: fix compilation for other architectures Pavel Machek
2002-05-28 5:33 ` David Weinehall [this message]
2002-05-28 8:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020528073303.K9911@khan.acc.umu.se \
--to=tao@acc.umu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox