* trivial: reiserfs whitespace
@ 2002-05-26 18:31 Pavel Machek
2002-05-27 2:43 ` Chris Wedgwood
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Machek @ 2002-05-26 18:31 UTC (permalink / raw)
To: kernel list, Rusty trivial patch monkey Russell
Hi!
Kill space at EOLN.
Pavel
--- clean/fs/reiserfs/journal.c Sun May 26 19:32:02 2002
+++ linux-swsusp/fs/reiserfs/journal.c Sun May 26 19:52:04 2002
@@ -57,7 +57,7 @@
#include <linux/stat.h>
#include <linux/string.h>
#include <linux/smp_lock.h>
-#include <linux/suspend.h>
+#include <linux/suspend.h>
#include <linux/buffer_head.h>
/* the number of mounted filesystems. This is used to decide when to
--
(about SSSCA) "I don't say this lightly. However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: trivial: reiserfs whitespace
2002-05-26 18:31 trivial: reiserfs whitespace Pavel Machek
@ 2002-05-27 2:43 ` Chris Wedgwood
2002-05-25 14:53 ` Arnaldo Carvalho de Melo
2002-05-27 10:33 ` Pavel Machek
0 siblings, 2 replies; 6+ messages in thread
From: Chris Wedgwood @ 2002-05-27 2:43 UTC (permalink / raw)
To: Pavel Machek; +Cc: kernel list, Rusty trivial patch monkey Russell
On Sun, May 26, 2002 at 08:31:28PM +0200, Pavel Machek wrote:
Kill space at EOLN.
I have a trivial script to remove this for an entire tree. I decided
it was a bad idea when I saw how many lines are indeed affected.
--cw
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: trivial: reiserfs whitespace
2002-05-27 2:43 ` Chris Wedgwood
@ 2002-05-25 14:53 ` Arnaldo Carvalho de Melo
2002-05-28 7:59 ` Chris Wedgwood
2002-05-27 10:33 ` Pavel Machek
1 sibling, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2002-05-25 14:53 UTC (permalink / raw)
To: Chris Wedgwood
Cc: Pavel Machek, kernel list, Rusty trivial patch monkey Russell
Em Sun, May 26, 2002 at 07:43:54PM -0700, Chris Wedgwood escreveu:
> On Sun, May 26, 2002 at 08:31:28PM +0200, Pavel Machek wrote:
>
> Kill space at EOLN.
>
> I have a trivial script to remove this for an entire tree. I decided
> it was a bad idea when I saw how many lines are indeed affected.
But doing it slowly, together with other patches, is not a bad idea.
- Arnaldo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: trivial: reiserfs whitespace
2002-05-25 14:53 ` Arnaldo Carvalho de Melo
@ 2002-05-28 7:59 ` Chris Wedgwood
2002-05-28 23:10 ` jw schultz
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wedgwood @ 2002-05-28 7:59 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Pavel Machek, kernel list,
Rusty trivial patch monkey Russell
Cc: Larry McVoy
On Sat, May 25, 2002 at 11:53:25AM -0300, Arnaldo Carvalho de Melo wrote:
But doing it slowly, together with other patches, is not a bad
idea.
Well, in that case is there some kind of bk or command that can be
made to automagically run to purge white-space from the end
patches/changesets as they are produced? It would also be nice to
have hunks such as[1]:
--- 1 Tue May 28 00:56:35 2002
+++ 2 Tue May 28 00:56:34 2002
@@ -1 +1 @@
-
+
stripped completely as they have no functional value and just add
bloat patches and such like.
This can be done with CVS but as it works very differently to bk
(which to be honest I really don't understand very well at all) I'm
not even sure if the above suggestion is meaningful.
--cw
[1] View this email with something that makes white-space visible.
Basically, 1 is ' ' and 2 is '\t\t'.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: trivial: reiserfs whitespace
2002-05-28 7:59 ` Chris Wedgwood
@ 2002-05-28 23:10 ` jw schultz
0 siblings, 0 replies; 6+ messages in thread
From: jw schultz @ 2002-05-28 23:10 UTC (permalink / raw)
To: kernel list
On Tue, May 28, 2002 at 12:59:37AM -0700, Chris Wedgwood wrote:
> On Sat, May 25, 2002 at 11:53:25AM -0300, Arnaldo Carvalho de Melo wrote:
>
> But doing it slowly, together with other patches, is not a bad
> idea.
>
> Well, in that case is there some kind of bk or command that can be
> made to automagically run to purge white-space from the end
> patches/changesets as they are produced? It would also be nice to
> have hunks such as[1]:
>
> --- 1 Tue May 28 00:56:35 2002
> +++ 2 Tue May 28 00:56:34 2002
> @@ -1 +1 @@
> -
> +
>
> stripped completely as they have no functional value and just add
> bloat patches and such like.
>
> This can be done with CVS but as it works very differently to bk
> (which to be honest I really don't understand very well at all) I'm
> not even sure if the above suggestion is meaningful.
>
> --cw
CW makes an interesting point. Perhaps bk could be
configured to check for / +\t/ and /\s+$/ on changed lines,
and possibly their contigious neighbors, and ask about purging
the superfluous whitespace. Comments Larry?
--
________________________________________________________________
J.W. Schultz Pegasystems Technologies
email address: jw@pegasys.ws
Remember Cernan and Schmitt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: trivial: reiserfs whitespace
2002-05-27 2:43 ` Chris Wedgwood
2002-05-25 14:53 ` Arnaldo Carvalho de Melo
@ 2002-05-27 10:33 ` Pavel Machek
1 sibling, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2002-05-27 10:33 UTC (permalink / raw)
To: Chris Wedgwood; +Cc: kernel list, Rusty trivial patch monkey Russell
Hi!
> Kill space at EOLN.
>
> I have a trivial script to remove this for an entire tree. I decided
> it was a bad idea when I saw how many lines are indeed affected.
It was my fault it got introduced, so I thought it is my
responsibility to kill it.
Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-05-28 23:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-05-26 18:31 trivial: reiserfs whitespace Pavel Machek
2002-05-27 2:43 ` Chris Wedgwood
2002-05-25 14:53 ` Arnaldo Carvalho de Melo
2002-05-28 7:59 ` Chris Wedgwood
2002-05-28 23:10 ` jw schultz
2002-05-27 10:33 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox