From: Jens Axboe <axboe@suse.de>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Christoph Hellwig <hch@infradead.org>,
Linus Torvalds <torvalds@transmeta.com>,
Martin Dalecki <dalecki@evision-ventures.com>,
linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] ide-tape.c must include buffer_head.h
Date: Wed, 29 May 2002 12:51:07 +0200 [thread overview]
Message-ID: <20020529105107.GM17674@suse.de> (raw)
In-Reply-To: <Pine.NEB.4.44.0205262258180.20535-100000@mimas.fachschaften.tu-muenchen.de>
On Sun, May 26 2002, Adrian Bunk wrote:
> Hi Christoph,
>
> after your removal of #include <linux/buffer_head.h> from fs.h ide-tape.c
> no longer compiles:
The usage of BH_Lock is completely wrong in ide-tape! BH_Lock is a
buffer_head flag, but it's setting/clearing the bio flags. Whoever did
that 2.5 conversion messed that part up.
--
Jens Axboe
prev parent reply other threads:[~2002-05-29 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-26 21:06 [2.5 patch] ide-tape.c must include buffer_head.h Adrian Bunk
2002-05-29 10:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020529105107.GM17674@suse.de \
--to=axboe@suse.de \
--cc=bunk@fs.tum.de \
--cc=dalecki@evision-ventures.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox