Re: [PATCH] intel-x86 model config cleanup

Albert D. Cahalan
2002-05-29T22:05:46Z

Jeff Garzik writes:

> +choice 'Processor vendor' \
> + "AMD CONFIG_VENDOR_AMD \
> + Cyrix CONFIG_VENDOR_CYRIX \
> + Generic CONFIG_VENDOR_GENERIC \
> + IDT CONFIG_VENDOR_IDT \
> + Intel CONFIG_VENDOR_INTEL \
> + NationalSemiconductor CONFIG_VENDOR_NATSEMI \
> + RiSE CONFIG_VENDOR_RISE \
> + Transmeta CONFIG_VENDOR_TRANSMETA \
> + VIA CONFIG_VENDOR_VIA" Generic
> +
> +if [ "$CONFIG_VENDOR_AMD" = "y" ]; then
> + choice 'Processor family' \
> + "386 CONFIG_M386 \
> + 486 CONFIG_M486 \
> + K5/5x86 CONFIG_M586 \
> + K6/K6-II/K6-III CONFIG_MK6 \
> + Athlon/Duron CONFIG_MK7" Athlon
> +fi

This is still a mess. It's better to have one boolean
per processor, and order the processors by the year
in which they were most commonly sold.