Re: [PATCH] intel-x86 model config cleanup

J.A. Magallon
2002-05-29T23:07:30Z

On 2002.05.30 Jeff Garzik wrote:
>
>The basic thing to remember is that "generic_foo" or "cpu_intel_foo"
>options should very rarely, if ever, appear in the config.in or sources.
> We simply want to use the generic or cpu-specific user selection to
>determine (a) compiler flags, (b) CONFIG_xxx symbols for specific CPU
>features and optimizations, [like CONFIG_X86_F00F_BUG] and maybe (c)
>enable and disable CPU-specific drivers. (c) will be a special case,
>since very few drivers should require a specific CPU type... but some
>drivers simply don't work on 386.
>

Grep on the tree showed this:

drivers/char/serial.c:

#if defined(__i386__) && (defined(CONFIG_M386) || defined(CONFIG_M486))
#define SERIAL_INLINE
#endif

include/asm-i386/processor.h:

/* Prefetch instructions for Pentium III and AMD Athlon */
#ifdef CONFIG_MPENTIUMIII

#define ARCH_HAS_PREFETCH
extern inline void prefetch(const void *x)
{
__asm__ __volatile__ ("prefetchnta (%0)" : : "r"(x));
}

#elif CONFIG_X86_USE_3DNOW

#define ARCH_HAS_PREFETCH
#define ARCH_HAS_PREFETCHW
#define ARCH_HAS_SPINLOCK_PREFETCH

More candidates for CONFIG_X86_xxxxx.
But these spawn over other architextures:
include/asm-alpha/processor.h:#define ARCH_HAS_PREFETCH
include/asm-ppc/processor.h:#define ARCH_HAS_PREFETCH
...

--
J.A. Magallon # Let the source be with you...
mailto:jamagallon@able.es
Mandrake Linux release 8.3 (Cooker) for i586
Linux werewolf 2.4.19-pre9-jam1 #1 SMP mié may 29 02:20:48 CEST 2002 i686