Re: [PATCH] 2.5.19 IDE 78

Paul Dickson
2002-06-02T08:16:28Z

On Sun, 02 Jun 2002 08:04:59 +0200, Martin Dalecki wrote:

> static void hpt3xx_maskproc(struct ata_device *drive)
> {
> struct pci_dev *dev = drive->channel->pci_dev;
> - const int mask = 0;
> + struct ata_channel *ch = drive->channel;
>
> if (drive->quirk_list) {
> if (hpt_min_rev(dev, 3)) {
> u8 reg5a;
> pci_read_config_byte(dev, 0x5a, &reg5a);
> - if (((reg5a & 0x10) >> 4) != mask)
> - pci_write_config_byte(dev, 0x5a, mask ? (reg5a | 0x10) : (reg5a & ~0x10));

[...]

> + if ((reg5a & 0x10) >> 4)
> + pci_write_config_byte(dev, 0x5a, reg5a & ~0x10);

Perhaps you can remove the " >> 4" too.

-Paul