Re: [PATCH] 2.5.19 IDE 78

Bartlomiej Zolnierkiewicz
2002-06-02T21:36:25Z

On Sun, 2 Jun 2002, Martin Dalecki wrote:

> Paul Mackerras wrote:
> > Martin,
> >
> > I think you have a typo here:
> >
> >
> >>diff -urN linux-2.5.19/drivers/ide/ide-pmac.c linux/drivers/ide/ide-pmac.c
> >>--- linux-2.5.19/drivers/ide/ide-pmac.c 2002-06-01 18:53:06.000000000 +0200
> >>+++ linux/drivers/ide/ide-pmac.c 2002-06-01 18:17:36.000000000 +0200
> >>@@ -434,7 +434,7 @@
> >> goto out;
> >> }
> >> udelay(10);
> >>- OUT_BYTE(drive->ctl | 2, IDE_CONTROL_REG);
> >>+ ata_irq_enale(drive, 0);
>

I think Paul was talking about ata_irq_enale() ;)

> For sure not. The nIEN bit is *negated* on the part of the
> device - please look at the ata_irq_enable() functions definition.
> I have explained it there.
>
> > ata_irq_enable surely?
>
> The toggle is the second parameter becouse I didn't wan't to
> provide two functions. - 0 measn disable it 1 means enable it.>

--
Bartlomiej