From: Jens Axboe <axboe@suse.de>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.19 : drivers/mtd/nftlcore.c
Date: Fri, 31 May 2002 09:14:25 +0200 [thread overview]
Message-ID: <20020531071425.GH841@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0205301946500.22691-100000@localhost.localdomain>
On Thu, May 30 2002, Frank Davis wrote:
> @@ -899,7 +899,7 @@
> DEBUG(MTD_DEBUG_LEVEL2,"NFTL read request completed OK\n");
> up(&nftl->mutex);
> goto repeat;
> - } else if (req->cmd == WRITE) {
> + } else if ((int)req->cmd == WRITE) {
Irk, this is very wrong :-)
} else if (rq_data_dir(rq) == WRITE) {
should work.
> @@ -1015,10 +1015,11 @@
> };
>
> extern char nftlmountrev[];
> +static spinlock_t nftl_lock = SPIN_LOCK_UNLOCKED;
>
> int __init init_nftl(void)
> {
> - int i;
> +spin_lock_init(&nftl_lock);
You don't need the spin_lock_init(), you just set it SPIN_LOCK_UNLOCKED
above.
The rest looks ok.
--
Jens Axboe
next prev parent reply other threads:[~2002-05-31 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-30 23:52 [PATCH] 2.5.19 : drivers/mtd/nftlcore.c Frank Davis
2002-05-31 7:14 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-05-31 12:53 Frank Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020531071425.GH841@suse.de \
--to=axboe@suse.de \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox