From: Paul Dickson <dickson@permanentmail.com>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.19 IDE 78
Date: Sun, 2 Jun 2002 01:16:13 -0700 [thread overview]
Message-ID: <20020602011613.2b3dc7e3.dickson@permanentmail.com> (raw)
In-Reply-To: <3CF9B58B.9080509@evision-ventures.com>
On Sun, 02 Jun 2002 08:04:59 +0200, Martin Dalecki wrote:
> static void hpt3xx_maskproc(struct ata_device *drive)
> {
> struct pci_dev *dev = drive->channel->pci_dev;
> - const int mask = 0;
> + struct ata_channel *ch = drive->channel;
>
> if (drive->quirk_list) {
> if (hpt_min_rev(dev, 3)) {
> u8 reg5a;
> pci_read_config_byte(dev, 0x5a, ®5a);
> - if (((reg5a & 0x10) >> 4) != mask)
> - pci_write_config_byte(dev, 0x5a, mask ? (reg5a | 0x10) : (reg5a & ~0x10));
[...]
> + if ((reg5a & 0x10) >> 4)
> + pci_write_config_byte(dev, 0x5a, reg5a & ~0x10);
Perhaps you can remove the " >> 4" too.
-Paul
next prev parent reply other threads:[~2002-06-02 8:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-29 18:50 Linux 2.5.19 Linus Torvalds
2002-05-29 19:42 ` Jason Lunz
2002-05-29 20:17 ` Russell King
2002-05-29 20:38 ` Eli Carter
2002-05-29 20:44 ` James Simmons
2002-05-29 20:47 ` Russell King
2002-05-29 22:22 ` Martin Dalecki
2002-05-29 23:25 ` Russell King
2002-05-29 22:42 ` Martin Dalecki
2002-05-29 23:52 ` Russell King
2002-05-29 23:00 ` Martin Dalecki
2002-05-29 22:43 ` James Simmons
2002-05-29 22:29 ` Martin Dalecki
2002-05-29 23:31 ` Russell King
2002-05-30 5:10 ` Framebuffer policy [ was Re: Linux 2.5.19] James Simmons
2002-05-29 20:37 ` [PATCH] Missing include in drivers/base/bus.c and drivers/pci/pci-driver.c Tom Rini
2002-05-29 22:24 ` Linux 2.5.19 Tom Rini
2002-05-30 1:29 ` Rusty Russell
2002-05-29 23:01 ` Matthias Andree
2002-05-29 23:35 ` J.A. Magallon
2002-05-30 14:15 ` [PATCH] 2.5.19 blk.h and more about the ugly kids Martin Dalecki
2002-05-31 11:09 ` [PATCH] 2.5.19 IDE 76 Martin Dalecki
2002-05-31 18:17 ` [PATCH] 2.5.19 IDE 77 Martin Dalecki
2002-06-02 6:04 ` [PATCH] 2.5.19 IDE 78 Martin Dalecki
2002-06-02 8:16 ` Paul Dickson [this message]
2002-06-02 9:21 ` Paul Mackerras
2002-06-02 19:34 ` Martin Dalecki
2002-06-02 21:36 ` Bartlomiej Zolnierkiewicz
2002-06-02 21:59 ` Paul Mackerras
2002-06-03 4:47 ` Martin Dalecki
2002-06-02 6:06 ` [PATCH} 2.5.19 IDE 79 Martin Dalecki
2002-06-02 6:07 ` [PATCH] 2.5.19 IDE 80 Martin Dalecki
2002-06-02 19:45 ` [PATCH] 2.5.19 IDE 81 Martin Dalecki
2002-06-02 20:13 ` [PATCH] 2.5.19 IDE 82 Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020602011613.2b3dc7e3.dickson@permanentmail.com \
--to=dickson@permanentmail.com \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox