Re: [PATCH] TRIVIAL: rwhron@earthlink.net: remove space in cache names

Re: [PATCH] TRIVIAL: rwhron@earthlink.net: remove space in cache names

[Martin Dalecki]

Rusty Russell wrote:
> rwhron@earthlink.net: remove space in _proc_slabinfo cache_name:
>   Most /proc/slabinfo cache_names are in the format:
>   cache_name.  There are a couple with spaces in the
>   name, which is inconsistent and requires a special case
>   when scripting.
>   
>   Changes "fasync cache" and "file lock cache" to have
>   the usual underscore.
>   
>   Tested on 2.5.18.  Applies to 2.4.19-pre8 with offset.


If you are looking in this area already plese remove
the completely redundant and inconsistently used cache
suffix for some entry names too. Slabinfo is about allocation
caches and nothing else.

[PATCH] TRIVIAL: rwhron@earthlink.net: remove space in cache names

[Rusty Russell]

rwhron@earthlink.net: remove space in _proc_slabinfo cache_name:
  Most /proc/slabinfo cache_names are in the format:
  cache_name.  There are a couple with spaces in the
  name, which is inconsistent and requires a special case
  when scripting.
  
  Changes "fasync cache" and "file lock cache" to have
  the usual underscore.
  
  Tested on 2.5.18.  Applies to 2.4.19-pre8 with offset.
  

--- trivial-2.5.20/fs/fcntl.c.orig	Mon Jun  3 15:25:18 2002
+++ trivial-2.5.20/fs/fcntl.c	Mon Jun  3 15:25:18 2002
@@ -551,7 +551,7 @@
 
 static int __init fasync_init(void)
 {
-	fasync_cache = kmem_cache_create("fasync cache",
+	fasync_cache = kmem_cache_create("fasync_cache",
 		sizeof(struct fasync_struct), 0, 0, NULL, NULL);
 	if (!fasync_cache)
 		panic("cannot create fasync slab cache");
--- trivial-2.5.20/fs/locks.c.orig	Mon Jun  3 15:25:18 2002
+++ trivial-2.5.20/fs/locks.c	Mon Jun  3 15:25:18 2002
@@ -1940,7 +1940,7 @@
 
 static int __init filelock_init(void)
 {
-	filelock_cache = kmem_cache_create("file lock cache",
+	filelock_cache = kmem_cache_create("file_lock_cache",
 			sizeof(struct file_lock), 0, 0, init_once, NULL);
 	if (!filelock_cache)
 		panic("cannot create file lock slab cache");

--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

Re: [PATCH] TRIVIAL: rwhron@earthlink.net: remove space in cache names

[rwhron]

>>>   Changes "fasync cache" and "file lock cache" to have
>>>   the usual underscore.

>> If you are looking in this area already plese remove
>> the completely redundant and inconsistently used cache
>> suffix for some entry names too. 

> Well, that's a decent idea, sure. 

Somewhat tangential, but are the DMA entries in /proc/slabinfo
every incremented/used?  I've watched them on various x86 boxes
for a while and never noticed a non-zero num_active_objs,
total_objs, num_active_slabs, or total_slabs entry.

size-131072(DMA)       0      0 131072    0    0   32
size-65536(DMA)        0      0  65536    0    0   16
size-32768(DMA)        0      0  32768    0    0    8
..
size-128(DMA)          0      0    128    0    0    1
size-64(DMA)           0      0     64    0    0    1
size-32(DMA)           0      0     64    0    0    1

-- 
Randy Hron

Re: [PATCH] TRIVIAL: rwhron@earthlink.net: remove space in cache names

[Daniel Phillips]

On Monday 03 June 2002 07:20, Martin Dalecki wrote:
> Rusty Russell wrote:
> > rwhron@earthlink.net: remove space in _proc_slabinfo cache_name:
> >   Most /proc/slabinfo cache_names are in the format:
> >   cache_name.  There are a couple with spaces in the
> >   name, which is inconsistent and requires a special case
> >   when scripting.
> >   
> >   Changes "fasync cache" and "file lock cache" to have
> >   the usual underscore.
> >   
> >   Tested on 2.5.18.  Applies to 2.4.19-pre8 with offset.
> 
> If you are looking in this area already plese remove
> the completely redundant and inconsistently used cache
> suffix for some entry names too. Slabinfo is about allocation
> caches and nothing else.

Amen.

-- 
Daniel