From: Russell King <rmk@arm.linux.org.uk>
To: linux-kernel@vger.kernel.org
Cc: Jens Axboe <axboe@suse.de>
Subject: PATCH/RFC: fix 2.5.20 ramdisk
Date: Mon, 3 Jun 2002 18:06:27 +0100 [thread overview]
Message-ID: <20020603180627.A23056@flint.arm.linux.org.uk> (raw)
2.5.20 seems to be incapable of executing binaries in a ramdisk-based
root filesystem. The ramdisk in question is an ext2fs, with a 1K
block size loaded via the compressed ramdisk loader in do_mounts().
It appears that, in the case of a 1K block sized filesystem, we attempt
to read two 512-byte sectors into a BIO vector. The first one is copied
into the first 512 bytes. The second sector, however, is copied over
the first 512 bytes. Obviously not what we really want.
Here is _a_ patch which solves this for me, which may not be correct.
Jens?
--- orig/drivers/block/rd.c Wed May 29 21:40:26 2002
+++ linux/drivers/block/rd.c Mon Jun 3 17:59:08 2002
@@ -144,7 +144,7 @@
{
struct address_space * mapping;
unsigned long index;
- int offset, size, err;
+ int offset, vec_offset, size, err;
err = 0;
mapping = rd_bdev[minor]->bd_inode->i_mapping;
@@ -152,6 +152,7 @@
index = sector >> (PAGE_CACHE_SHIFT - 9);
offset = (sector << 9) & ~PAGE_CACHE_MASK;
size = vec->bv_len;
+ vec_offset = 0;
do {
int count;
@@ -186,13 +187,14 @@
if (rw == READ) {
src = kmap(page);
src += offset;
- dst = kmap(vec->bv_page) + vec->bv_offset;
+ dst = kmap(vec->bv_page) + vec->bv_offset + vec_offset;
} else {
dst = kmap(page);
dst += offset;
- src = kmap(vec->bv_page) + vec->bv_offset;
+ src = kmap(vec->bv_page) + vec->bv_offset + vec_offset;
}
offset = 0;
+ vec_offset += count;
memcpy(dst, src, count);
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next reply other threads:[~2002-06-03 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-03 17:06 Russell King [this message]
2002-06-04 8:35 ` PATCH/RFC: fix 2.5.20 ramdisk Jens Axboe
2002-06-04 8:45 ` Russell King
2002-06-04 7:54 ` Martin Dalecki
2002-06-04 8:53 ` Jens Axboe
2002-06-04 8:54 ` Russell King
2002-06-04 8:08 ` Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020603180627.A23056@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox