Re: [PATCH] page coloring for 2.4.18 kernel

David S. Miller
2002-06-04T13:19:49Z

From: Jason Papadopoulos <jasonp@boo.net>
Date: Sun, 07 Apr 2002 11:01:00 -0400

Hello. This is a re-diff of the 2.4.17 patch I posted
previously.

www.boo.net/~jasonp/page_color-2.2.20-20020108.patch
www.boo.net/~jasonp/page_color-2.4.17-20020113.patch
www.boo.net/~jasonp/page_color-2.4.18-20020323.patch

I'm not subscribed to LKML, so please cc responses
to this email address.

Hi Jason. I noticed that your code assumes zones begin on well
aligned physical addresses. This is not true.

For example, in page_color_start you use the raw
(page - zone->zone_mem_map) index as the color. This
is wrong, what if the zone starts at page 1? In such
a case all of your colors will be computed incorrectly
and pages with different colors in different zones can actually be of
the same color.