public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: mochel@osdl.org
Cc: anton@samba.org, linux-kernel@vger.kernel.org
Subject: Re: [2.5.19] Oops during PCI scan on Alpha
Date: Tue, 04 Jun 2002 12:42:41 -0700 (PDT)	[thread overview]
Message-ID: <20020604.124241.78709149.davem@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.33.0206041227410.654-100000@geena.pdx.osdl.net>

   From: Patrick Mochel <mochel@osdl.org>
   Date: Tue, 4 Jun 2002 12:38:06 -0700 (PDT)

   
   > There's this middle area between core and subsys, why not
   > just be explicit about it's existence?
   > 
   > Short of making the true dependencies describable, I think my
   > postcore_initcall solution is fine.
   
   What sense is there in naming it postcore_initcall? What does it tell you 
   about the intent of the function? 
   
It says "this has to be initialized, but after core initcalls because
it expects core to be setup."  That's what "postcore" means. :-)

   The initcall levels are not a means to bypass true dependency resolution. 
   They're an alternative means to solving some of the dependency problems 
   without having a ton of #ifdefs and hardcoded, explicit calls to 
   initialization routines. 
   
I added no ifdefs, what are you talking about.

   We can add more levels and change names. But, we should make them 
   meaningful for at least two reasons:
   
   - It's obvious to people who are using them what they should use
   - It's obvious to someone looking at the code when it gets initialized
   
How much more meaning do you want than "this requires core to be
setup"  That describes a lot to me.

   That said, how about doing this:
   
   - core

+- postcore

   - subsys
   - arch
   - driver
   
   core initializes the core, as always.
   
   subsys initializes bus and device class subsystems and registers them with 
   the core.
   
But there are things between subsys and core as demonstrated by the
very bug we are trying to fix right now.

You people are blowing this shit WAY out of proportion.  Just fix the
bug now and reinplement the initcall hierarchy in a seperate changeset
so people can actually get work done in the 2.5.x tree while you do
that ok?

  reply	other threads:[~2002-06-04 19:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-02 20:06 [2.5.19] Oops during PCI scan on Alpha Jan-Benedict Glaw
2002-06-03  4:27 ` Anton Blanchard
2002-06-03  3:39   ` David S. Miller
2002-06-04 15:50     ` Patrick Mochel
2002-06-04 17:07       ` Ivan Kokshaysky
2002-06-04 18:58         ` Patrick Mochel
2002-06-04 18:26           ` Benjamin Herrenschmidt
2002-06-05 14:20           ` Ivan Kokshaysky
2002-06-04 18:13       ` David S. Miller
2002-06-04 19:38         ` Patrick Mochel
2002-06-04 19:42           ` David S. Miller [this message]
2002-06-04 20:56             ` Tom Rini
2002-06-04 21:10             ` Patrick Mochel
2002-06-04 21:14               ` David S. Miller
2002-06-04 21:14                 ` Patrick Mochel
2002-06-04 21:23                   ` David S. Miller
2002-06-04 21:29                     ` Patrick Mochel
2002-06-04 21:34                       ` David S. Miller
2002-06-04 22:03                         ` Patrick Mochel
2002-06-04 22:06                           ` Patrick Mochel
2002-06-05 14:23                           ` Ivan Kokshaysky
2002-06-05 22:29                             ` David S. Miller
2002-06-06  0:01                             ` Patrick Mochel
2002-06-06 13:22                               ` Ivan Kokshaysky
2002-06-23 17:03       ` Jan-Benedict Glaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020604.124241.78709149.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox