Re: kernel 2.5.20 on alpha (RE: [patch] Re: kernel 2.5.18 on alpha)

David Mosberger
2002-06-04T20:06:14Z

>>>>> On Tue, 4 Jun 2002 12:11:05 +0200, "Oliver Pitzeier" <o.pitzeier@uptime.at> said:

>> `copy_user_page' undeclared (first use in this function) make[1]:
>> *** [main.o] Error 1 make[1]: Leaving directory
>> `/usr/src/linux-2.5.20/init' make: *** [init] Error 2

Oliver> I guess I found where the error comes from:

Oliver> (from the 2.5.20 Changelog):
>> <davidm@napali.hpl.hp.com> [PATCH] pass "page" pointer to
>> clear_user_page()/copy_user_page()
>>
>> Hi Linus,
>>
>> Are you willing to change the interfaces of clear_user_page() and
>> copy_user_page() so that they can receive the relevant page
>> pointer as a separate argument? I need this on ia64 to implement
>> the lazy-cache flushing scheme.
>>
>> I believe PPC would also benefit from this.
>>
>> --david

Oliver> Now I believe, that Alpha also benefits from this. :o) The
Oliver> only thing I have to do - I guess - is to change the defines
Oliver> for copy_user_page() and clear_user_page. Adding the not
Oliver> used parameter >pg< should not make any problems.

Yes, you can simply ignore the page pointer argument. It's there for
those arches that want to take advantage of it. Sorry about causing
breakage...

--david