Re: PATCH/RFC: fix 2.5.20 ramdisk

Martin Dalecki
2002-06-04T09:07:21Z

Russell King wrote:
> On Tue, Jun 04, 2002 at 09:54:14AM +0200, Martin Dalecki wrote:
>
>>>--- orig/drivers/block/rd.c Wed May 29 21:40:26 2002
>>>+++ linux/drivers/block/rd.c Tue Jun 4 09:44:21 2002
>>>@@ -144,6 +144,7 @@
>>> {
>>> struct address_space * mapping;
>>> unsigned long index;
>>>+ unsigned int vec_offset;
>>
>>Just a small nit. Shouldn't taht be size_t ?
>
>
> I really don't see where you got that thought from. A bio_vec is:
>
> struct bio_vec {
> struct page *bv_page;
> unsigned int bv_len;
> unsigned int bv_offset;
> };
>
> bv_offset is unsigned int. Therefore, vec_offset should be likewise.

Ahh. Of course I see. Thank you for explaining.