From: Russell King <rmk@arm.linux.org.uk>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: Jens Axboe <axboe@suse.de>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org
Subject: Re: PATCH/RFC: fix 2.5.20 ramdisk
Date: Tue, 4 Jun 2002 09:54:27 +0100 [thread overview]
Message-ID: <20020604095427.B30552@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020603180627.A23056@flint.arm.linux.org.uk> <20020604083525.GA2512@suse.de> <20020604094532.A30552@flint.arm.linux.org.uk> <3CFC7226.2010101@evision-ventures.com>
On Tue, Jun 04, 2002 at 09:54:14AM +0200, Martin Dalecki wrote:
> > --- orig/drivers/block/rd.c Wed May 29 21:40:26 2002
> > +++ linux/drivers/block/rd.c Tue Jun 4 09:44:21 2002
> > @@ -144,6 +144,7 @@
> > {
> > struct address_space * mapping;
> > unsigned long index;
> > + unsigned int vec_offset;
>
> Just a small nit. Shouldn't taht be size_t ?
I really don't see where you got that thought from. A bio_vec is:
struct bio_vec {
struct page *bv_page;
unsigned int bv_len;
unsigned int bv_offset;
};
bv_offset is unsigned int. Therefore, vec_offset should be likewise.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-06-04 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-03 17:06 PATCH/RFC: fix 2.5.20 ramdisk Russell King
2002-06-04 8:35 ` Jens Axboe
2002-06-04 8:45 ` Russell King
2002-06-04 7:54 ` Martin Dalecki
2002-06-04 8:53 ` Jens Axboe
2002-06-04 8:54 ` Russell King [this message]
2002-06-04 8:08 ` Martin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020604095427.B30552@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=axboe@suse.de \
--cc=dalecki@evision-ventures.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox