public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Mike Black <mblack@csihq.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.5.20 RAID5 compile error
Date: Tue, 4 Jun 2002 14:21:05 +0200	[thread overview]
Message-ID: <20020604122105.GB1105@suse.de> (raw)
In-Reply-To: <04cf01c20b2d$96097030$f6de11cc@black> <20020604115132.GZ1105@suse.de> <15612.43734.121255.771451@notabene.cse.unsw.edu.au> <20020604115842.GA5143@suse.de> <15612.44897.858819.455679@notabene.cse.unsw.edu.au>

On Tue, Jun 04 2002, Neil Brown wrote:
> On Tuesday June 4, axboe@suse.de wrote:
> > 
> > What changes did you have in mind?
> 
> http://www.cse.unsw.edu.au/~neilb/patches/linux-devel/2.5.20/patch-A-NewPlug
> 
> Is what I had against 2.5.20.  A quick look at the mail that you sent
> with improvements suggest that I can be even less intrusive..  But it
> will have to wait until tomorrow (my time).

Ah ok, I see what you have in mind. Right now you are completely
mimicking the tq_struct setup -- any reason a simple q->plug_fn is not
enough? Do you ever need anything else than the queue passed in with the
plug? Wrt umem, it seems you could keep 'card' in the queuedata. Same
for raid5 and conf.

-- 
Jens Axboe


  reply	other threads:[~2002-06-04 12:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03 18:36 2.5.20 RAID5 compile error Mike Black
2002-06-04 11:51 ` Jens Axboe
2002-06-04 11:56   ` Neil Brown
2002-06-04 11:58     ` Jens Axboe
2002-06-04 12:15       ` Neil Brown
2002-06-04 12:21         ` Jens Axboe [this message]
2002-06-04 12:32           ` Jens Axboe
2002-06-04 12:38             ` Jens Axboe
2002-06-04 14:23               ` Jens Axboe
2002-06-04 13:45                 ` Martin Dalecki
2002-06-04 14:55                   ` Jens Axboe
2002-06-04 14:24                     ` Martin Dalecki
2002-06-04 18:22                       ` Horst von Brand
2002-06-05 10:19                       ` Jens Axboe
2002-06-04 17:00                   ` Ingo Oeser
2002-06-05  1:16               ` Neil Brown
2002-06-05 10:13                 ` Jens Axboe
2002-06-06  2:58                   ` Neil Brown
2002-06-06  5:31                     ` Jens Axboe
2002-06-04 21:48   ` Miles Lane

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020604122105.GB1105@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mblack@csihq.com \
    --cc=neilb@cse.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox