* Definition conflict in 2.4.19-pre?? code
@ 2002-06-05 7:36 Roger W. Brown
2002-06-05 10:02 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Roger W. Brown @ 2002-06-05 7:36 UTC (permalink / raw)
To: linux-kernel
Hi,
I am not able to compile 2.4 series kernels after
linux-2.4.19-pre1 and I don't understand how others can !
Consider the "struct request_queue" definition in blkdev.h
In the 2.4.19-pre1 version, the last few lines read:
/*
* Tasks wait here for free read and write requests
*/
wait_queue_head_t wait_for_requests[2];
};
and for later versions this is changed to:
/*
* Tasks wait here for free request
*/
wait_queue_head_t wait_for_request;
};
yet drivers/block/ll_rw_blk.c still makes references to
wait_for_requests[?] in the void blk_init_free_list()
and blkdev_release_request() functions and elsewhere.
Roger
--
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Definition conflict in 2.4.19-pre?? code
2002-06-05 7:36 Definition conflict in 2.4.19-pre?? code Roger W. Brown
@ 2002-06-05 10:02 ` Jens Axboe
2002-06-05 12:03 ` Roger W. Brown
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2002-06-05 10:02 UTC (permalink / raw)
To: Roger W. Brown; +Cc: linux-kernel
On Wed, Jun 05 2002, Roger W. Brown wrote:
>
> Hi,
>
> I am not able to compile 2.4 series kernels after
> linux-2.4.19-pre1 and I don't understand how others can !
>
> Consider the "struct request_queue" definition in blkdev.h
>
> In the 2.4.19-pre1 version, the last few lines read:
> /*
> * Tasks wait here for free read and write requests
> */
> wait_queue_head_t wait_for_requests[2];
> };
> and for later versions this is changed to:
> /*
> * Tasks wait here for free request
> */
> wait_queue_head_t wait_for_request;
> };
>
> yet drivers/block/ll_rw_blk.c still makes references to
> wait_for_requests[?] in the void blk_init_free_list()
> and blkdev_release_request() functions and elsewhere.
Your kernel tree must be corrupted, there's no such change in later
2.4.19-pre. pre10 still uses two request wait queues.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Definition conflict in 2.4.19-pre?? code
2002-06-05 10:02 ` Jens Axboe
@ 2002-06-05 12:03 ` Roger W. Brown
0 siblings, 0 replies; 3+ messages in thread
From: Roger W. Brown @ 2002-06-05 12:03 UTC (permalink / raw)
To: linux-kernel; +Cc: axobe, akpm
( Original message deleted )
>
> Your kernel tree must be corrupted, there's no such change in later
> 2.4.19-pre. pre10 still uses two request wait queues.
Yes indeed !! My patch program trips and falls whenever it encounters the
line: "\ No newline at end of file" I hadn't noticed. Sorry.
--
Roger Brown
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-06-05 12:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-06-05 7:36 Definition conflict in 2.4.19-pre?? code Roger W. Brown
2002-06-05 10:02 ` Jens Axboe
2002-06-05 12:03 ` Roger W. Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox