From: Dave Jones <davej@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Keith Owens <kaos@ocs.com.au>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.20 i2c uses nonexistent linux/i2c-old.h
Date: Wed, 5 Jun 2002 19:17:19 +0200 [thread overview]
Message-ID: <20020605191719.H11945@suse.de> (raw)
In-Reply-To: <20279.1023240470@kao2.melbourne.sgi.com> <1023298545.2442.16.camel@irongate.swansea.linux.org.uk>
On Wed, Jun 05, 2002 at 06:35:45PM +0100, Alan Cox wrote:
> > drivers/media/video/i2c-old.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7110.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7111.c:#include <linux/i2c-old.h>
> > drivers/media/video/saa7185.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36067.c:#include <linux/i2c-old.h>
> > drivers/media/video/zr36120.h:#include <linux/i2c-old.h>
> >
> > There is no file called i2c-old.h in 2.5.20. These only build because
> > they pick up i2c-old.h from /usr/include/linux :(.
>
> i2c-old was back compatibility for obsolete code from 2.2 into 2.4. Its
> dead its gone, and now folks need to go fix the drivers
Which makes me wonder why it compiled for Keith.
Why is kbuild2.5 expanding <linux/foo.h> to /usr/include/linux/foo.h ?
If $sourcetree/include/linux/foo.h doesn't exist, it should stop
compiling, not look in /usr/include/ for a (obsolete/wrong) alternative.
Dave.
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-06-05 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-05 1:27 2.5.20 i2c uses nonexistent linux/i2c-old.h Keith Owens
2002-06-05 17:35 ` Alan Cox
2002-06-05 17:17 ` Dave Jones [this message]
2002-06-05 23:41 ` Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020605191719.H11945@suse.de \
--to=davej@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox