* [PATCH] 2.4.19-pre10 bug in disable_APIC_timer
@ 2002-06-06 20:59 Joe Korty
2002-06-07 15:23 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Joe Korty @ 2002-06-06 20:59 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-kernel
Marcelo,
This one bit me when I actually started using the (relatively) new
services disable_APIC_timer() and enable_APIC_timer(). Enable_APIC_timer()
is coded correctly; this patch fixes the bug in the disable service.
Please apply. Patch is against 2.4.19-pre10.
Joe
--- linux/arch/i386/kernel/apic.c.orig Thu Jun 6 15:21:26 2002
+++ linux/arch/i386/kernel/apic.c Thu Jun 6 15:24:05 2002
@@ -941,7 +941,7 @@
smp_call_function(setup_APIC_timer, (void *)calibration_result, 1, 1);
}
-void __init disable_APIC_timer(void)
+void disable_APIC_timer(void)
{
if (using_apic_timer) {
unsigned long v;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 2.4.19-pre10 bug in disable_APIC_timer
2002-06-07 15:23 ` Alan Cox
@ 2002-06-07 14:49 ` Joe Korty
2002-06-07 15:58 ` Alan Cox
0 siblings, 1 reply; 5+ messages in thread
From: Joe Korty @ 2002-06-07 14:49 UTC (permalink / raw)
To: Alan Cox; +Cc: Joe Korty, Marcelo Tosatti, linux-kernel
> On Thu, 2002-06-06 at 21:59, Joe Korty wrote:
>> Marcelo,
>> This one bit me when I actually started using the (relatively) new
>> services disable_APIC_timer() and enable_APIC_timer(). Enable_APIC_timer()
>> is coded correctly; this patch fixes the bug in the disable service.
>
> When is this getting called from a non boot up situation ?
I am calling it from some cpu shielding code I've written and am
debugging.
Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 2.4.19-pre10 bug in disable_APIC_timer
2002-06-07 15:58 ` Alan Cox
@ 2002-06-07 15:06 ` Joe Korty
0 siblings, 0 replies; 5+ messages in thread
From: Joe Korty @ 2002-06-07 15:06 UTC (permalink / raw)
To: Alan Cox; +Cc: Joe Korty, Marcelo Tosatti, linux-kernel
> On Fri, 2002-06-07 at 15:49, Joe Korty wrote:
> >
> > I am calling it from some cpu shielding code I've written and am
> > debugging.
>
> So the __init isnt actually a bug. It might be an appropriate change if
> your code ever becomes part of the main tree thats all
True. In that case, an __init should be added to enable_APIC_timer.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 2.4.19-pre10 bug in disable_APIC_timer
2002-06-06 20:59 [PATCH] 2.4.19-pre10 bug in disable_APIC_timer Joe Korty
@ 2002-06-07 15:23 ` Alan Cox
2002-06-07 14:49 ` Joe Korty
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2002-06-07 15:23 UTC (permalink / raw)
To: Joe Korty; +Cc: Marcelo Tosatti, linux-kernel
On Thu, 2002-06-06 at 21:59, Joe Korty wrote:
> Marcelo,
> This one bit me when I actually started using the (relatively) new
> services disable_APIC_timer() and enable_APIC_timer(). Enable_APIC_timer()
> is coded correctly; this patch fixes the bug in the disable service.
When is this getting called from a non boot up situation ?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] 2.4.19-pre10 bug in disable_APIC_timer
2002-06-07 14:49 ` Joe Korty
@ 2002-06-07 15:58 ` Alan Cox
2002-06-07 15:06 ` Joe Korty
0 siblings, 1 reply; 5+ messages in thread
From: Alan Cox @ 2002-06-07 15:58 UTC (permalink / raw)
To: Joe Korty; +Cc: Marcelo Tosatti, linux-kernel
On Fri, 2002-06-07 at 15:49, Joe Korty wrote:
>
> I am calling it from some cpu shielding code I've written and am
> debugging.
So the __init isnt actually a bug. It might be an appropriate change if
your code ever becomes part of the main tree thats all
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2002-06-07 15:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-06-06 20:59 [PATCH] 2.4.19-pre10 bug in disable_APIC_timer Joe Korty
2002-06-07 15:23 ` Alan Cox
2002-06-07 14:49 ` Joe Korty
2002-06-07 15:58 ` Alan Cox
2002-06-07 15:06 ` Joe Korty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox